Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <d12bede2-4b76-fcdf-60c1-38616fab7ded@lwfinger.net>
Date:   Fri, 21 Jan 2022 12:29:50 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 19/31] net: realtek: changing LED_* from enum
 led_brightness to actual value
Content-Language: en-US
To:     htl10@users.sourceforge.net, Luiz Sampaio <sampaio.ime@gmail.com>,
        Herton Ronaldo Krzesinski <herton@canonical.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
References: <1735835679.1273895.1642785160493.ref@mail.yahoo.com>
 <1735835679.1273895.1642785160493@mail.yahoo.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <1735835679.1273895.1642785160493@mail.yahoo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/21/22 11:12, Hin-Tak Leung wrote:
>> -        if (brightness == LED_FULL) {
>> +        if (brightness == 255) {
> 
>> -        if (brightness == LED_OFF) {
>> +        if (brightness == 0) {
> 
> NAKed. I haven't received the other 30 patches in this series so I don't know the full context, but I don't think replacing meaningful enum names with numerical values is an improvement. If the ENUMs are gone from a common include (and why is the ENUM removed, if drivers use them??), and the realtek driver still have such a functionality, it probably should be defined in one of the rtl818*.h as RTL818X_LED_FULL and RTL818X_LED_OFF .
> 
> My $0.02, based on this one only of the 31.

I agree. Substituting magic numbers for enum names should not be done. NACK.

Larry