Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3086846pxb; Mon, 24 Jan 2022 02:02:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxI/G/AnPLmha36/c9jq/2MPykVzhEW8d9Ek+MmQWBQikYj3NCG3Q8ag1uKx04zTg2pIe/1 X-Received: by 2002:aa7:9562:0:b0:4c9:f1a0:e0d0 with SMTP id x2-20020aa79562000000b004c9f1a0e0d0mr1256752pfq.53.1643018555639; Mon, 24 Jan 2022 02:02:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643018555; cv=none; d=google.com; s=arc-20160816; b=tS2v5hairbaP0VsxtClGqMy6vuIX2npsCTkGllT0Z0ceTfH49AXyOg/lYEI5GrYhTN IVL1AE2QsacNDon5JCmOyAQ6yjk3IHAANJmhAnqnm+rKNiH8WDXfX3yzAH757LkO4wcA 4+QAEfH1R8CCPc3zRaBLnSJw7E7yy5OQcAEf3m7eMxDdGdyuaGpTkbVjFzVFWzrkf5dF BCnhW3oWGBERe33q8x7Z2PNeVq/OEWLwA/EOI/+BNTAbG8wLYxVRLL8S0LgWqDQWvqHM e/knxHFKYT0J87EGi87prxXjj7yNgRgQneO2ncCQ5AB54dy/H03rqxGrA3ZQuj9OS583 //EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=JDzawVaacO7nDED/OrTheVfoJSIEDNadjEMcex4v2ko=; b=bODdjE9G21UnEErh9eUHyVrynKdeD7GfMHVdsNdywTBeGdKftAQrGDuBzXyvCFOO69 I6MLjwkWGPNBBqKMsLKsHJ6Fl52gQ0/nv16bxid0oFq9duMWYXKBQxgs/4YeCmUaA1fL D3Woe+trvv0SF0UoPSg935o7yO+RKF6EApUySmvivi42cWOhVjzYVJy4kK//xQSdE5OG 6xfzq4FqqlTATicD7BFcXiSU4k3uIDDR7kjIY4Wo9mcpn6Jx3qaVEZNHDiV9yZPyvoND jzRiGezt3O/pqmB3MpUoyAUBegwoq+bo+7H5ZAQBlbr4gunW8DI5TR9SWoedfrpCAUkL 31og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si9054150plx.544.2022.01.24.02.02.18; Mon, 24 Jan 2022 02:02:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235107AbiAWPmb convert rfc822-to-8bit (ORCPT + 71 others); Sun, 23 Jan 2022 10:42:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230339AbiAWPma (ORCPT ); Sun, 23 Jan 2022 10:42:30 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B2C9C06173B; Sun, 23 Jan 2022 07:42:28 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7FAF8FF803; Sun, 23 Jan 2022 15:42:21 +0000 (UTC) Date: Sun, 23 Jan 2022 16:42:20 +0100 From: Miquel Raynal To: Florian Fainelli Cc: linux-mtd@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Weinberger , Vignesh Raghavendra , Brian Norris , Kamal Dasu , Arnd Bergmann , Cai Huoqing , Colin Ian King , linux-kernel@vger.kernel.org (open list), linux-wireless@vger.kernel.org (open list:BROADCOM SPECIFIC AMBA DRIVER (BCMA)), bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM STB NAND FLASH DRIVER) Subject: Re: [PATCH v3 0/9] BCMA support for brcmnand Message-ID: <20220123164220.58f01b76@xps13> In-Reply-To: <20220107184614.2670254-1-f.fainelli@gmail.com> References: <20220107184614.2670254-1-f.fainelli@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Florian, f.fainelli@gmail.com wrote on Fri, 7 Jan 2022 10:46:05 -0800: > Hi all, > > This patch series adds support for the BRCMNAND controller revision 3.4 > embedded in MIPS-based SoCs such as 5357, typically found in the Netgear > WNR3500L v2 and other kinds of Wi-Fi routers. The upstream platform that > uses this controller is under arch/mips/bcm47xx/ and does not use Device > Tree (and probably never will by now). BCMA (Broadcom AMBA) is a special > kind of discoverable memory mapped interface which requires the use of > special accessors to read from/write to the hardware block. > > The integration of brcmnand into that SoC is a bit quirky in that every > register offering byte level data about the flash (OOB, device ID, etc.) > requires byte swapping. The command shift should also have been 24, but > is in fact 0, took me a while to understand why no reads were actually > working because of that. > > This has been tested with Linux 5.10.82 and Linus' master with OpenWrt > and confirmed that the squashfs + jffs2 overlay that OpenWrt creates is > entirely functional and that written data is made persistent. Series applied on nand/next. Thanks, Miquèl