Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp11795pxb; Thu, 27 Jan 2022 13:52:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjQqEanJJC093XYASlIJ6f7F4/LtWGjcvs1tnmkdUbTgFvbhFu/EzBfDY5wciryCcTnY9u X-Received: by 2002:a17:907:6d81:: with SMTP id sb1mr1504300ejc.633.1643320363157; Thu, 27 Jan 2022 13:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643320363; cv=none; d=google.com; s=arc-20160816; b=mR6nA9eog6imnOrWAZEAhHVaeWAsdHbbzJcYJAOh31d/+8w233ovCBEitv4e0U9Gr1 /6yORu01VTuEhlVvK2+krY5YkiICq6uI73a3fJTHQ5uBfhKXWiNytlAT88AntQT08++Y +lm0bAbR1qJuH+PjLgYFhP0BEGDybx8zXrq/zUZgFkpZm7UPx3okep+o+nWwkfh2xLE1 ZmxB8Zzp5ZBFlhEtPqh59tQl6tHIICH8Rpgv/6psysJg6iFOZ+acbJYQDbXl9g7Xgu+e b8rqxZYDEEzeeOllE2yB//672v5o4TYLhGcjyq61L81fch9Q1Fi2gKcDJxxgQLFpTMP9 ayRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=jw7HB0W4GoTcqbrIhgkUi6AF2K9gvZZi+U4J/jPhOPQ=; b=jKr3Nhrzyn5MZIkjKTu5X18cpmSkuzYMhGk4VXt1DUgm2KLLH90b8FrFo+CjzWm2SD qcmF93AM0fEr3Iwufw1Xox9UOtNuRJKhOYvHRDboZ+5nltPjj6yi9j4l9T++UPx9ffez mOff5t6LfaNAH2mgm2ZxW1DzOzDZwZjl1eojnp4SyGmhzwBuYUDiN08jDooxKHDi21pl +1g0R9+N5fAAkdWxn2VZPKiBFxNxFID5wOSXu6/F0kSrNPhpA5MRhcnH0ms4SxZROhLh JcrR/NK3rEWwdlGjsmPJy8SuGHeM+Hz0mZ7cKyujBr4AyS1Ft3PtNLJDeKa6BX1253MX OVbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kda1foNq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t24si1841456eds.484.2022.01.27.13.52.25; Thu, 27 Jan 2022 13:52:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kda1foNq; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240218AbiA0MLX (ORCPT + 72 others); Thu, 27 Jan 2022 07:11:23 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:43750 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234481AbiA0MLW (ORCPT ); Thu, 27 Jan 2022 07:11:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F1F2B82227; Thu, 27 Jan 2022 12:11:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40EA1C340E4; Thu, 27 Jan 2022 12:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643285480; bh=l6TRy4jFk0Trxh8+yK9kI1v0jsEYunfLcp1/XiEleh8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kda1foNqREMz9pKhLX9F6Jrq8C1fgqA/P2pVwJzWbJ3rXX1MHuzhq7EJ9q99Hbw+C u0UEB9YScQdiQCy7e3OEya4I2PtqJjc/SlGo2b2waVmgiWikvqtNhzHhcs80GmiwLi ebxiH0PbRkD7Hbudc3X3p9J8y9nsWElkTjn9o6DTAD0XoJQI6fluSqukZV3BWjWrU8 d+XK8lyWxKDxtMXRTbjZS/aKVQvTGPDIVMT8qHW581O/fImoxhv18Q4kBvPQfAFhkS xC6ByS0UQmJf4MdxkNM1HZXnRQgjhYr+GVa6wASYHeU9XlizjPUUZzumAZpLjSXt8z ohCI2MilfYfLw== From: Kalle Valo To: Martin Blumenstingl Cc: Pkshih , "linux-wireless\@vger.kernel.org" , "tony0620emma\@gmail.com" , "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , Neo Jou , Jernej Skrabec Subject: Re: [PATCH 3/4] rtw88: Move enum rtw_tx_queue_type mapping code to tx.{c,h} References: <20220114234825.110502-1-martin.blumenstingl@googlemail.com> <20220114234825.110502-4-martin.blumenstingl@googlemail.com> <87czkogsc4.fsf@kernel.org> Date: Thu, 27 Jan 2022 14:11:14 +0200 In-Reply-To: (Martin Blumenstingl's message of "Sun, 23 Jan 2022 19:34:18 +0100") Message-ID: <87mtjhjs4d.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Martin Blumenstingl writes: > Hi Kalle, > > On Wed, Jan 19, 2022 at 7:20 AM Kalle Valo wrote: > [...] >> I was about to answer that with a helper function it's easier to catch >> out of bands access, but then noticed the helper doesn't have a check >> for that. Should it have one? > > you mean something like: > if (ac >= IEEE80211_NUM_ACS) > return RTW_TX_QUEUE_BE; > > Possibly also with a WARN_ON/WARN_ON_ONCE Yeah, something like that would be good. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches