Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 Jan 2022 17:51:51 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Stefan Schmidt <stefan@datenfreihafen.org>
Cc:     Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org,
        David Girault <david.girault@qorvo.com>,
        Romuald Despres <romuald.despres@qorvo.com>,
        Frederic Blain <frederic.blain@qorvo.com>,
        Nicolas Schodet <nico@ni.fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [wpan-next 4/4] net: ieee802154: Add a kernel doc header to the
 ieee802154_addr structure
Message-ID: <20220127175151.1d6f70bb@xps13>
In-Reply-To: <6903cb13-2fc9-8c8a-f247-8cbeddf51103@datenfreihafen.org>
References: <20220120004350.308866-1-miquel.raynal@bootlin.com>
        <20220120004350.308866-5-miquel.raynal@bootlin.com>
        <6903cb13-2fc9-8c8a-f247-8cbeddf51103@datenfreihafen.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Stefan,

stefan@datenfreihafen.org wrote on Thu, 27 Jan 2022 17:05:42 +0100:

> Hello.
>=20
> On 20.01.22 01:43, Miquel Raynal wrote:
> > From: David Girault <david.girault@qorvo.com>
> >=20
> > While not being absolutely needed, it at least explain the mode vs. enum
> > fields.
> >=20
> > Signed-off-by: David Girault <david.girault@qorvo.com>
> > [miquel.raynal@bootlin.com: Isolate this change from a bigger commit and
> >                              reword the comment]
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >   include/net/cfg802154.h | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> >=20
> > diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> > index 4193c242d96e..0b8b1812cea1 100644
> > --- a/include/net/cfg802154.h
> > +++ b/include/net/cfg802154.h
> > @@ -29,6 +29,16 @@ struct ieee802154_llsec_key_id;
> >   struct ieee802154_llsec_key;
> >   #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */ =20
> >   > +/** =20
> > + * struct ieee802154_addr - IEEE802.15.4 device address
> > + * @mode: Address mode from frame header. Can be one of:
> > + *        - @IEEE802154_ADDR_NONE
> > + *        - @IEEE802154_ADDR_SHORT
> > + *        - @IEEE802154_ADDR_LONG
> > + * @pan_id: The PAN ID this address belongs to
> > + * @short_addr: address if @mode is @IEEE802154_ADDR_SHORT
> > + * @extended_addr: address if @mode is @IEEE802154_ADDR_LONG
> > + */
> >   struct ieee802154_addr {
> >   	u8 mode;
> >   	__le16 pan_id;
> >  =20
>=20
> Same here, please fold into the addr moving patch. I see no reason why sp=
litting these would make it easier or do I miss something?

I really split every change that I could as a habit, but there is no
problem with squashing them both.

Thanks,
Miqu=C3=A8l