Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2728410pxb; Mon, 31 Jan 2022 03:03:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJycgvweBJyv5ztL04CFaOzPr4cnlmYNsC0zkxSv6oTI3xPeihNIcFDEeZHkhS1raYe2sP15 X-Received: by 2002:a17:903:110d:: with SMTP id n13mr19657995plh.5.1643627036653; Mon, 31 Jan 2022 03:03:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643627036; cv=none; d=google.com; s=arc-20160816; b=qgaL6Fpt0sQuDqPF0DRYNb0BCdrbv7l5dacvKiKa3isoRKSguNsaAqF8F5+wfqEAvS JtftG3RCIe76ML/Fb3p5YY+EMTP+YI70lwp2TAH78qQYptgxnXFx1P4dTGmTkgswrtiS 5/l3tRVsSB9mIhTlDqhat8nDCWF0TTeUMcAl9aWfleke+07ZuJf6kJF/dskXKfrF5/xK 9gvxTiLtFfgr0kWa7gXaJsRWHTsKZDh7U4nm/qj8JHDJnB2sJdNqAvZH9PaAoaH2B5jp UatfY2hePTDv+Z326IJhyAXuAobE7qZstLrFF5UqCMHlOaB7/n26LqmNrwHX2FigsY7g v7GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=TVffce0tR9wNbLGTehq44D+nWT8LBrAw9spbpZyYoBU=; b=dgMfO1+NSooDFjPaTw1O+Zkl9MVsx0URIg3dl2yDCpXp6X8Tsq3IDmhs9e8R0vQdmo WH1TogRAh+AoPM5HUCbPNsV7q94UTiaWzPHMV3a+hJcWLiSbqZG0Kj6F1R8VAjs11OQ8 kGxpXsr+9ZXScVJKLzobextFVGeUp1OzdiZZpIf3tcmKtcXCskLvJg/sRpzbm+xBKIUJ 1m9IWH4Z0qz6MXt/ypW87e8fui42teuUAQ2+sKNJkjoFbGtLgldxGNSPJ9rIXHgspGJl WAX2frHaVThvLljvNQJU34pNxL+iUnwgsz9C1GW7a4rX1ClXpsc2NpSvwL0cbYRxdcoY lGcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx11si11676812pjb.118.2022.01.31.03.03.48; Mon, 31 Jan 2022 03:03:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348911AbiA1Nen (ORCPT + 72 others); Fri, 28 Jan 2022 08:34:43 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:37848 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1348905AbiA1Nem (ORCPT ); Fri, 28 Jan 2022 08:34:42 -0500 Received: from 91-155-254-253.elisa-laajakaista.fi ([91.155.254.253] helo=kveik.lan) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1nDROh-0002DK-Je; Fri, 28 Jan 2022 15:34:40 +0200 From: Luca Coelho To: kvalo@kernel.org Cc: luca@coelho.fi, linux-wireless@vger.kernel.org Date: Fri, 28 Jan 2022 15:34:24 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220128133433.591765-1-luca@coelho.fi> References: <20220128133433.591765-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH 04/13] iwlwifi: mvm: fw: clean up hcmd struct creation Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg This is valid, but pretty uncommon in the driver, clean up the code here a bit to use an initializer. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index 0bb288a17353..61741f07dd7f 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -814,7 +814,11 @@ int iwl_mvm_get_sar_geo_profile(struct iwl_mvm *mvm) struct iwl_geo_tx_power_profiles_resp *resp; u16 len; int ret; - struct iwl_host_cmd cmd; + struct iwl_host_cmd cmd = { + .id = WIDE_ID(PHY_OPS_GROUP, PER_CHAIN_LIMIT_OFFSET_CMD), + .flags = CMD_WANT_SKB, + .data = { &geo_tx_cmd }, + }; u8 cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, PHY_OPS_GROUP, PER_CHAIN_LIMIT_OFFSET_CMD, IWL_FW_CMD_VER_UNKNOWN); @@ -838,12 +842,7 @@ int iwl_mvm_get_sar_geo_profile(struct iwl_mvm *mvm) if (!iwl_sar_geo_support(&mvm->fwrt)) return -EOPNOTSUPP; - cmd = (struct iwl_host_cmd){ - .id = WIDE_ID(PHY_OPS_GROUP, PER_CHAIN_LIMIT_OFFSET_CMD), - .len = { len, }, - .flags = CMD_WANT_SKB, - .data = { &geo_tx_cmd }, - }; + cmd.len[0] = len; ret = iwl_mvm_send_cmd(mvm, &cmd); if (ret) { -- 2.34.1