Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] brcmfmac: firmware: Fix crash in brcm_alt_fw_path
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220118154514.3245524-1-phil@raspberrypi.com>
References: <20220118154514.3245524-1-phil@raspberrypi.com>
To:     Phil Elwell <phil@raspberrypi.com>
Cc:     Arend van Spriel <aspriel@gmail.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Phil Elwell <phil@raspberrypi.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164337882901.4682.2390001655219643717.kvalo@kernel.org>
Date:   Fri, 28 Jan 2022 14:07:10 +0000 (UTC)
Precedence: bulk

Phil Elwell <phil@raspberrypi.com> wrote:

> The call to brcm_alt_fw_path in brcmf_fw_get_firmwares is not protected
> by a check to the validity of the fwctx->req->board_type pointer. This
> results in a crash in strlcat when, for example, the WLAN chip is found
> in a USB dongle.
> 
> Prevent the crash by adding the necessary check.
> 
> See: https://github.com/raspberrypi/linux/issues/4833
> 
> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries")
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>

Patch applied to wireless.git, thanks.

665408f4c3a5 brcmfmac: firmware: Fix crash in brcm_alt_fw_path

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220118154514.3245524-1-phil@raspberrypi.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches