Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2736443pxb; Mon, 31 Jan 2022 03:14:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTRif28bA/ZtciPeZ0XlVU48VnhH4OJkhWXI6LXFIUZ+l7hYuQKMvyqHrYjjdjRZJofO4I X-Received: by 2002:a17:907:3e90:: with SMTP id hs16mr16767823ejc.731.1643627656566; Mon, 31 Jan 2022 03:14:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643627656; cv=none; d=google.com; s=arc-20160816; b=bvKF+AVQSAF3k+P1CpgeyCV+FHgOTI/GWP3CMj7+aNNo6EHx/2cnL5tKafqpoo4tkg gRuK1NiDsZ/0fJHtKuNeeqarN2dQ1p7pN2ZcFJYmlpwANtab0bzvh+XmUCEz+q23CyU4 1L4pnsNs3zxQdM8S4+pO8OEAQh0BhOPm9J5GQd0XpWHDXx7mHFRsDxzAbAMe1OVdqSwv KHvkIFT14CoNw6Shmpbl8Ibgrgojd1Mr9kHvhpiCrbhsZtuBiuj7qBR72/DWa5Nr99B6 y7S6R0WRzrP+HUboATgC0KgAyKQEP8LbNi06zyzatp9FMOz9q/iM/XgRHoKjtQc4ANOg qYoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=WKtFqoS65Cq26v6Ko+cUd6ZElA847djBFQQfKIhHHWE=; b=zGrqEHfCugMkmZ0vOdNkxQg11kS7HDlBcw0bfEY6AdMzN0qxLtE4BCfWF41HKb9CFc OyE8wfnmCkYG7OEjMIZhTA8M/EIVDVA2GWiAfd2SH+sZkNeR10syQnRPt2roB+Tka+8i Qks6GQXHzR4blIWlNXPnrLxCwi8Tmh2x/XOK1x1twxGpPxUJlk5yafPVWVF+/wBcE01f g+umXrlgHMGeu1Crb7EdGGca3IHRKFqYBM+EUXkPX+HRAz9E59vx9rZ6WQGrEDG0Cxdy /JhBRhM4ZGEpKeWgXcUdC/dkZ+zAMoAp8a3as/jocVJKLbRXvFRpr6/ShnCdkZB+kXfm 2RGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eZ4fGFxf; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si8269841edd.159.2022.01.31.03.13.59; Mon, 31 Jan 2022 03:14:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eZ4fGFxf; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349775AbiA1P6D (ORCPT + 72 others); Fri, 28 Jan 2022 10:58:03 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:52878 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349768AbiA1P54 (ORCPT ); Fri, 28 Jan 2022 10:57:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DAA67B82630 for ; Fri, 28 Jan 2022 15:57:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC2DFC340E7; Fri, 28 Jan 2022 15:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643385474; bh=N/5p0X1Jz7WuX9DCTycV1w05lEaIDIp/K1o48q3CS8s=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=eZ4fGFxfRDykYWJTL9xXxE3Svyal3OWEKGwOhSYONRfdSuiAM1rpbnoF1TurAYsbx iuVumMJnlNnytL+DO+CTmAGRlvnH8kN0zZhlj9wWMHsCVNd1fYb/7QalnrJLy7xlT8 YI6NIC46YW900deSDWC3DPKXMxPUlN0mS6C2NfykkyUOKqvuTuDo0qHQEuDFbXjZUE VTCj1BXjZPTFR/l5ULDCiaUnayq8ahPV5M9VKQslSAyCRsbZGE7ZZqN2IYYDrkxNYT xbMRk/SBs9x9++NsLuZtJ+FaqoG0Mkqis3OqimfylD4Z79Vq+yMgtR379meY2Xcr2Q +3FvXsX8i2NKg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] rtw89: fix maybe uninitialized `qempty` variable From: Kalle Valo In-Reply-To: <20220113094253.73370-1-ihuguet@redhat.com> References: <20220113094253.73370-1-ihuguet@redhat.com> To: =?utf-8?b?w43DsWlnbyBIdWd1ZXQ=?= Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com, =?utf-8?b?w43DsWlnbyBIdWd1ZXQ=?= User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164338547212.19531.3599554444244239620.kvalo@kernel.org> Date: Fri, 28 Jan 2022 15:57:53 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Íñigo Huguet wrote: > Call to dle_dfi_qempty might fail, leaving qempty.qempty untouched, which > is latter used to control the for loop. If that happens, it's not > initialized anywhere. > > Initialize it so the loop doesn't iterate unless it's modified by the > call to dle_dfi_qempty. > > Signed-off-by: Íñigo Huguet > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 89e4a00ff3c0 rtw89: fix maybe uninitialized `qempty` variable -- https://patchwork.kernel.org/project/linux-wireless/patch/20220113094253.73370-1-ihuguet@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches