Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAMP44s2vAmfHU+h5bSp5FJvks7T+b_tpdU1U4pBvK9jFF6C=eQ@mail.gmail.com>
 <YfY+C9hiX2V7LnT6@kroah.com>
In-Reply-To: <YfY+C9hiX2V7LnT6@kroah.com>
From:   Felipe Contreras <felipe.contreras@gmail.com>
Date:   Sun, 30 Jan 2022 02:07:32 -0600
Message-ID: <CAMP44s0b93nO9uVYB3_p_c=cq8BR3WCtnQA=7jJxyAxYC6rxNQ@mail.gmail.com>
Subject: Re: Regression in 5.16.3 with mt7921e
To:     Greg KH <greg@kroah.com>
Cc:     Linux stable <stable@vger.kernel.org>,
        Linux wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 30, 2022 at 1:28 AM Greg KH <greg@kroah.com> wrote:
>
> On Sat, Jan 29, 2022 at 01:05:50PM -0600, Felipe Contreras wrote:
> > Hello,
> >
> > I've always had trouble with this driver in my Asus Zephyrus laptop,
> > but I was able to use it eventually, that's until 5.16.3 landed.
> >
> > This version completely broke it. I'm unable to bring the interface
> > up, no matter what I try.
> >
> > Before, sometimes I was able to make the chip work by suspending the
> > laptop, but in 5.16.3 the machine doesn't wake up (which is probably
> > another issue).
> >
> > Reverting back to 5.16.2 makes it work.
> >
> > Let me know if you need more information, or if you would like me to
> > bisect the issue.
>
> Using 'git bisect' would be best, so we know what commit exactly causes
> the problems.

I know, but it has been a while since I've created a decent config
file to build a kernel.

Either way, I pushed forward and the commit is a38b94c43943.

Upstream commit 547224024579 introduced a regression that was fixed by
the next commit 680a2ead741a, but the second commit was never merged
to stable.

I've sent the second commit to fix the regression.

-- 
Felipe Contreras