Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kalle Valo <kvalo@kernel.org>
To:     Thorsten Leemhuis <regressions@leemhuis.info>
Cc:     Luca Coelho <luca@coelho.fi>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH for v5.17 1/2] iwlwifi: remove deprecated broadcast filtering feature
References: <20220128124851.538580-1-luca@coelho.fi>
        <iwlwifi.20220128144623.9241e049f13e.Ia4f282813ca2ddd24c13427823519113f2bbebf2@changeid>
        <b784b942-6346-7005-b71a-5682cf0452b1@leemhuis.info>
Date:   Mon, 31 Jan 2022 13:12:20 +0200
In-Reply-To: <b784b942-6346-7005-b71a-5682cf0452b1@leemhuis.info> (Thorsten
        Leemhuis's message of "Mon, 31 Jan 2022 09:08:00 +0100")
Message-ID: <87a6fccg6j.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Thorsten Leemhuis <regressions@leemhuis.info> writes:

> Hi, this is your Linux kernel regression tracker speaking.
>
> On 28.01.22 13:48, Luca Coelho wrote:
>> From: Luca Coelho <luciano.coelho@intel.com>
>> 
>> This feature has been deprecated and should not be used anymore.  With
>> newer firmwares, namely *-67.ucode and above, trying to use it causes an
>> assertion failure in the FW, similar to this:
>> 
>> [Tue Jan 11 20:05:24 2022] iwlwifi 0000:04:00.0: 0x00001062 | ADVANCED_SYSASSERT
>> 
>> In order to prevent this feature from being used, remove it entirely
>> and get rid of the Kconfig option that
>> enables it (IWLWIFI_BCAST_FILTERING).
>> 
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215488
>
> FWIW there was another report about it afaics:
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215550

If it's the same issue, it should be marked as a duplicate.

> That makes me hope that this is reviewed and merged to mainline relative
> quickly, otherwise more users will be bothered by this.
>
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> Fixes: cbaa6aeedee5 ("iwlwifi: bump FW API to 67 for AX devices")
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>
> Shouldn't this also have:
>
> Cc: stable@vger.kernel.org # 5.16.x

I can add that.

BTW, please trim your quotes. You left a really long (and unnecessary)
quote, which makes use of patchwork much harder for us maintainers.
Unfortunately patchwork is not able to trim them automatically:

https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20220128144623.9241e049f13e.Ia4f282813ca2ddd24c13427823519113f2bbebf2@changeid/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches