Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp898582pxb; Tue, 1 Feb 2022 12:43:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJz26s98fudohhILohwy5+GXpboRArsGkU2qaTxPKeQhs10cCia3a6T8ibwvI7v1YDkE288X X-Received: by 2002:a65:57cf:: with SMTP id q15mr21949679pgr.307.1643748235247; Tue, 01 Feb 2022 12:43:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643748235; cv=none; d=google.com; s=arc-20160816; b=H1ElqDghTM26L13uBkDfP06md+81m+IunVRwfVS7GCKOx4E1IMN5AQ+vk6xQLLJSpT wQj4lxyhe3m34jFWQrCdEUgx4FLAQNSI7qh0szKBXJepn7e6ExKmphDokRa7yXlm9hVe BVxDUxyotFKOhhc0qaJPkEQYusq+Z5uoNPQ9pt3hyowLh/lTjqwrPE+6FpxEbo5ZlSLa ozwTMA/29iX8YFBsCuGfo/5TevjTIKQ0Vu9XfvdFbw8zXL13Qr7GJySqRrCe7MoH1ZUd 3xnF5lq4b3303uZ9AX0zGVb21kvo0hUnCkaTKq1087Onc910/FsSrga/F4VEjo+AfkEM GfbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=uxHHXFbHW1/RQlw18h4JPmoav53haqAUjoPDPKIuHuM=; b=XW/c6jl6nnLhF/yVSZ0FIuQN6CTtkc0MJUAN9QWRp8EOypzHdEtDNT2cWUDpsnK+tR HZyDI9ihHksO6R0iyCwlE6NA4fsm1uRQ/8ofwntRGeTOaQdP6qXnFYhJR9xUygbLszCW 6PmQ4L7AqGMLhGlcLB8Q3LdWR8Hpfqw7iP/Ox1PrurijSjgkRy0eJ2vyocFjTjNenNks C6FDUVnoh1Q002MCujkB7RmBhYbFehxZNEFt37nazfY3Vjc8bT6a0iL/E23tVVVGenXD Q98jGCIwZ9lpSrL7ICb4libDy0dgfwIUdGz3xog0jwONkM73mdAI8PsmCRsblj/JJv3q FNLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=marcan.st Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v63si16776654pgd.332.2022.02.01.12.43.46; Tue, 01 Feb 2022 12:43:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=marcan.st Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380283AbiAaQVg (ORCPT + 70 others); Mon, 31 Jan 2022 11:21:36 -0500 Received: from marcansoft.com ([212.63.210.85]:38398 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380259AbiAaQV3 (ORCPT ); Mon, 31 Jan 2022 11:21:29 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id A809B419BC; Mon, 31 Jan 2022 16:21:20 +0000 (UTC) Subject: Re: [PATCH v2 22/35] brcmfmac: chip: Handle 1024-unit sizes for TCM blocks To: Arend van Spriel , Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Dmitry Osipenko Cc: Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , Andy Shevchenko , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20220104072658.69756-1-marcan@marcan.st> <20220104072658.69756-23-marcan@marcan.st> From: Hector Martin Message-ID: Date: Tue, 1 Feb 2022 01:21:17 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 19/01/2022 21.36, Arend van Spriel wrote: >> /** Return the TCM-RAM size of the ARMCR4 core. */ >> -static u32 brcmf_chip_tcm_ramsize(struct brcmf_core_priv *cr4) >> +static u32 brcmf_chip_tcm_ramsize(struct brcmf_chip_priv *ci, >> + struct brcmf_core_priv *cr4) > > Not sure why you add ci parameter here. It is not used below or am I > overlooking something. Oops, looks like junk left behind from when I was trying to figure this out. Removed. Sorry about that. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub