Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ipw2100: inproper error handling of ipw2100_pci_init_one
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <tencent_205AA371C910BBA2CF01B311811ABDF2560A@qq.com>
References: <tencent_205AA371C910BBA2CF01B311811ABDF2560A@qq.com>
To:     Peiwei Hu <jlu.hpw@foxmail.com>
Cc:     stas.yakovlev@gmail.com, kvalo@codeaurora.org, davem@davemloft.net,
        kuba@kernel.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        trivial@kernel.org, Peiwei Hu <jlu.hpw@foxmail.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164371770337.16633.7286807059175242667.kvalo@kernel.org>
Date:   Tue,  1 Feb 2022 12:15:04 +0000 (UTC)
Precedence: bulk

Peiwei Hu <jlu.hpw@foxmail.com> wrote:

> goto fail instead of returning directly in error exiting
> 
> Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com>

The commit log does not answer to "why?". Also looking at
ipw2100_pci_init_one() I think it would need more cleanup in error
handling, for example pci_ionumap() is called in different order etc.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/tencent_205AA371C910BBA2CF01B311811ABDF2560A@qq.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches