Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 04/19] ieee80211: Add EHT (802.11be) definitions
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
CC:     Ilan Peer <ilan.peer@intel.com>, Jia Ding <quic_jiad@quicinc.com>,
        Mordechay Goodstein <mordechay.goodstein@intel.com>,
        Sriram R <quic_srirrama@quicinc.com>
References: <20220204220255.448224-1-johannes@sipsolutions.net>
 <20220204230119.1ee92202ac30.Id30a3ef2844b296efbd5486fe1da9ca36a95c5cf@changeid>
 <d51984f5-a035-36a5-75f6-3bff67d60b12@quicinc.com>
 <12a77901c0f6b218c802db7434466d5eb49bcb46.camel@sipsolutions.net>
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Message-ID: <7e1a08c2-65b9-fafd-07e2-721b66e072f4@quicinc.com>
Date:   Mon, 7 Feb 2022 19:31:20 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <12a77901c0f6b218c802db7434466d5eb49bcb46.camel@sipsolutions.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 2/7/22 5:40 PM, Johannes Berg wrote:
>
>> Append _MASK for the macros representing multi bit fields like above?
>>
> I guess that'd make some sense.
>
>> Or we can use GENMASK() to represent values
>>
> I don't like GENMASK() that much to be honest, it always feels confusing
> which way around the arguments should be and whether the edges are
> included or not, and then I don't feel we gain much from it?
>
> johannes


Ok, I think we can go with appending _MASK


veeru