Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 04/19] ieee80211: Add EHT (802.11be) definitions
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
CC:     Ilan Peer <ilan.peer@intel.com>, Jia Ding <quic_jiad@quicinc.com>,
        Mordechay Goodstein <mordechay.goodstein@intel.com>,
        Sriram R <quic_srirrama@quicinc.com>
References: <20220204220255.448224-1-johannes@sipsolutions.net>
 <20220204230119.1ee92202ac30.Id30a3ef2844b296efbd5486fe1da9ca36a95c5cf@changeid>
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Message-ID: <d51984f5-a035-36a5-75f6-3bff67d60b12@quicinc.com>
Date:   Mon, 7 Feb 2022 12:37:24 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220204230119.1ee92202ac30.Id30a3ef2844b296efbd5486fe1da9ca36a95c5cf@changeid>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 2/5/22 3:32 AM, Johannes Berg wrote:
> From: Ilan Peer <ilan.peer@intel.com>
>
> Based on Draft P802.11be_D1.3.


"Based on Draft P802.11be_D1.0".

based on documentation and MACRO definitions, These changes are aligned 
with P802.11be_D1.0

> +
> +/**
> + * struct ieee80211_eht_mcs_nss_supp_bw - EHT max supported NSS per MCS (except
> + * 20MHz only stations).
> + *
> + * For each field below, bits 0 - 3 indicate the maximal number of spatial
> + * streams for Rx, and bits 4 - 7 indicate the maximal number of spatial streams
> + * for Tx.
> + *
> + * @rx_tx_mcs9_max_nss: indicates the maximum number of spatial streams
> + *     supported for reception and the maximum number of spatial streams
> + *     supported for transmission for MCS 8 - 9.


@rx_tx_mcs9_max_nss supported for transmission for MCS 0 - 9.

> +/**
> + * struct ieee80211_eht_mcs_nss_supp - EHT max supported NSS per MCS
> + *
> + * @only_20mhz: For a 20 MHz-only STA, indicates the maximum number of spatial
> + *     streams supported for reception and the maximum number of spatial streams
> + *     supported for transmission, for each MCS value. Optionally present in
> + *     &struct ieee80211_eht_cap_elem.
> + * @bw_80: If the operating channel width of the STA is greater than or equal to
> + *     80 MHz, indicates the maximum number of spatial streams supported fo

@bw_80 applicable for 20 and 40 MHz operating band widths also for non 20 MHz-only STA

> +/* EHT beamformee SU number of spatial streams <= 80MHz is split between octet 0
> + * and octet 1
> + */
> +#define IEEE80211_EHT_PHY_CAP0_SU_BEAMFORMEE_SS_80MHZ  0x80
> +
> +#define IEEE80211_EHT_PHY_CAP1_SU_BEAMFORMEE_SS_80MHZ  0x03
> +#define IEEE80211_EHT_PHY_CAP1_SU_BEAMFORMEE_SS_160MHZ 0x1c
> +#define IEEE80211_EHT_PHY_CAP1_SU_BEAMFORMEE_SS_320MHZ 0xe0
> +


Append _MASK for the macros representing multi bit fields like above?

Or we can use GENMASK() to represent values


- veeru