Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1315716pxb; Tue, 8 Feb 2022 14:29:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSp55fc5SjaAoYvEAy4v7IDdmN/MOFNBIiwppf5GGZu6nJ+AqqBvJlPcLBBbTi1Y/CPmBa X-Received: by 2002:a63:710c:: with SMTP id m12mr5109667pgc.591.1644359385059; Tue, 08 Feb 2022 14:29:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644359385; cv=none; d=google.com; s=arc-20160816; b=kDk90fX0ezGtOIIHM/eFHUvCzsNiIQ2irbTDdchQ9BYK6rXKfgVDXArPHXrNXwRSaw Z8Xzg0V4dw1Ih0l8XeZXUFZB4TLXEVYIkralZFBz2fRjQ2px3YVBHakbj8AWxfSTYED0 5tW6HiHsA2JfsK/hEcwr5kB4tNKuFwtcAyF36R/GS5lukzdGD6H9DiO+gHLUgia+Jvf3 7xIePgs4rgvZRKQS7RBEqtCgb8ebNQGYsPqgypTdyJ2q6sKy70aH3cRSmV+J2vXY9cH1 bJ+VPgNewPeYfTq03etZHsnXKh0D6zeXpgzwggm83XeJ1KYQJgzsT1ix2eH+4NIsAnlD HCPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=dFW5UNBOvFEJyEHkUsN32jISdlHB8+hVBvwEzzBVoYc=; b=HxwLAeVFoBI/hulK+t39fHty6TtvWU2uIyS01+Au/Ym/uYUAenBW5ujIYG2czhEasQ RS76TKiOzJnr4kqEbB3cXS6EbBk5a6uL+Y4X9k6re1DjszV9BWr+xBGCwO9CRrCAwTnw joIDZ9SWXSAAAirHReuJ851r8nGrwTFRV9Mk4turdXduwYIReYjRJyniGx+kklzbyIQE u+WviJrdqg1Og5fYt99Ra+qcRP/bObG9ONF8yBkbaZKL6t/7Flr0XVJwbfnSR6AUm3Mz v86z1yi9wCQctwnEC7XDkmf64KxUiIjJl7yDSazAvEO+KST9RdI74ziLjYQYO1GsuJXq S4IQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v4si12880140pfm.273.2022.02.08.14.29.34; Tue, 08 Feb 2022 14:29:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354682AbiBEJVz (ORCPT + 72 others); Sat, 5 Feb 2022 04:21:55 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:38002 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1347508AbiBEJVy (ORCPT ); Sat, 5 Feb 2022 04:21:54 -0500 Received: from 91-156-4-210.elisa-laajakaista.fi ([91.156.4.210] helo=kveik.lan) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1nGHGS-0006b7-HH; Sat, 05 Feb 2022 11:21:53 +0200 From: Luca Coelho To: kvalo@kernel.org Cc: luca@coelho.fi, linux-wireless@vger.kernel.org Date: Sat, 5 Feb 2022 11:21:38 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220205092140.751171-1-luca@coelho.fi> References: <20220205092140.751171-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH 10/12] iwlwifi: mvm: always remove the session protection after association Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Emmanuel Grumbach The firmware will soon stop removing the session protection for us after association. While this was convenient, it was not symmetric. Always remove the session protection after association, even for devices that support the new API. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index 8b0124a40ee9..6a9d9ce0007a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -2628,11 +2628,8 @@ static void iwl_mvm_bss_info_changed_station(struct iwl_mvm *mvm, /* * We received a beacon from the associated AP so * remove the session protection. - * A firmware with the new API will remove it automatically. */ - if (!fw_has_capa(&mvm->fw->ucode_capa, - IWL_UCODE_TLV_CAPA_SESSION_PROT_CMD)) - iwl_mvm_stop_session_protection(mvm, vif); + iwl_mvm_stop_session_protection(mvm, vif); iwl_mvm_sf_update(mvm, vif, false); WARN_ON(iwl_mvm_enable_beacon_filter(mvm, vif, 0)); -- 2.34.1