Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <536bba7d-38f6-18ae-e09d-dfcd30f73f9d@quicinc.com>
Date:   Tue, 8 Feb 2022 14:45:36 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH 09/14] mac80211: mlme: add documentation from spec to code
Content-Language: en-US
To:     Luca Coelho <luca@coelho.fi>, <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <20220202084947.370289-1-luca@coelho.fi>
 <iwlwifi.20220202104617.f1bafd0861b7.I566612d99bca5245dc06cbcc70369b94a525389c@changeid>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <iwlwifi.20220202104617.f1bafd0861b7.I566612d99bca5245dc06cbcc70369b94a525389c@changeid>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/2/2022 12:49 AM, Luca Coelho wrote:
> From: Mordechay Goodstein <mordechay.goodstein@intel.com>
> 
> Reference the spec why we decline HE support in
> case STA don't support all HE basic rates recurred by AP.
> 
> Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>   net/mac80211/mlme.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 291226a1599d..bf777943cacd 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -5052,7 +5052,15 @@ ieee80211_verify_sta_he_mcs_support(struct ieee80211_sub_if_data *sdata,
>   
>   			/*
>   			 * Make sure the HE AP doesn't require MCSs that aren't
> -			 * supported by the client
> +			 * supported by the client as required by spec
> +			 *
> +			 * P802.11-REVme/D0.3

curious why you reference a draft spec instead of referencing the 
approved IEEE Std 802.11ax™-2021

> +			 * 26.17.1 Basic HE BSS operation
> +			 *
> +			 * An HE STA shall not attempt to join * (MLME-JOIN.request primitive)
> +			 * a BSS, unless it supports (i.e., is able to both transmit and
> +			 * receive using) all of the <HE-MCS, NSS> tuples in the basic
> +			 * HE-MCS and NSS set.
>   			 */
>   			if (sta_rx_val == IEEE80211_HE_MCS_NOT_SUPPORTED ||
>   			    sta_tx_val == IEEE80211_HE_MCS_NOT_SUPPORTED ||