Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3762611pxb; Fri, 11 Feb 2022 07:14:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRFz6odGuunAgSmrlusV7eeKQKFDjRyFR8riVMmU5GuiXXHiXPKNtyQisc+7e9AKDijnNG X-Received: by 2002:a17:90b:4b83:: with SMTP id lr3mr835831pjb.135.1644592487715; Fri, 11 Feb 2022 07:14:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644592487; cv=none; d=google.com; s=arc-20160816; b=bIKwi9YrdLDX31XwSHfzbn0cw6rasMbKDc4zDIb/SQ2b9EzmHxoEblN1UOH/pwv7pf 3zAJnp0BuC7517iFgI0i6WjoI2Z0GzJE+wSxlOcUfetO1QdUufnVNj2UBFB7aFD/IPvT 4JxiNTAiEhEY40gO2DQ+Gzi66husu7x5E6At/RgZEzRtX4PeZf3dzcV5hiAjTdzHukLc i1xhdfLIA/Na4MK+A5L5QlDyNZ+WK3QjJHuGP7Max69FPV3DvpntE0qqiWXLrXK61c/0 rzeg0pIiy/uq5eWCJpsHA52hFwcQ1o4rjdU+kytE0zN3kM9jWhw2jscmZy/+ud2+LBth eSYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=0P8Co57LELgyYLgvrjkmd/DyNYUznRvdGUQ6k9Ktkok=; b=xAMsYhOzTDSv0yaOXSkXEHTf2y6BkhXekkGXvPcaxX+R/9LNWiRsYSLWqdLQuIvwv8 i6AELSnClWsHKsFOhqxI/BcqoEq2hvRnjHr6JDlWCFLNoweTU2RM9ioyGpTbD5cyb6p4 6VPTsf7yvL/reG1Jgv3YOgHyFS7JzdrZ25r42p2/vQGCQ7bKU+5p9erwsNi+wfT1PQKN aNfwWdtkaz0HZrtOWjDCKjORG6Q2l8i6wcTIq26gObA/v7hGu53l8b4AqIH1NIXD76Gn 4In9UJd/4jYeMny+ZLZu7fChwjr+X/jraddGLZczFhW/0aUT29/IdMCKOieKKx4uXHYz g0xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=iwuD7EWA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q4si5750336plh.423.2022.02.11.07.14.31; Fri, 11 Feb 2022 07:14:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=iwuD7EWA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351222AbiBKO67 (ORCPT + 73 others); Fri, 11 Feb 2022 09:58:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237878AbiBKO66 (ORCPT ); Fri, 11 Feb 2022 09:58:58 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A46C3FE for ; Fri, 11 Feb 2022 06:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=0P8Co57LELgyYLgvrjkmd/DyNYUznRvdGUQ6k9Ktkok=; t=1644591536; x=1645801136; b=iwuD7EWAd0rRbvrUmCc71GjloRW/M2pte2Sa32+sRmj9NZF pLu5hBf3wke9OW3+WN4LOHFwwK0pjQIvAEJCxFaPCidQ2R2MCPKL3FP8+Ftr+v4edjjA6boCLSyOF GWDuFIcU7GyDheUWgp9ShiRzSdxPeb6ezZAQwPIfQAXdfGQ+MAVvbdIU1xWXyhqL6NjhbdgftO9jQ 7K4s78qBELQxMvA7+HfD3MrtXAm8wAWxVHuTcIs7UYqhqtvtrxhPry/JbP8obwafvWYhvrIsGiaUR 8TIT1OybEkaMR+EvGahB2bF0lfNAOyGOC94PECCuAEMcpXdriUtW43wKkEkX68+Q==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nIXNZ-00HWWO-CD; Fri, 11 Feb 2022 15:58:33 +0100 Message-ID: Subject: Re: [PATCH 07/10] iwlwifi: fix leaks/bad data after failed firmware load From: Johannes Berg To: "Liu, Yongxin" , "luca@coelho.fi" , "luciano.coelho@intel.com" Cc: "kvalo@kernel.org" , "linux-wireless@vger.kernel.org" Date: Fri, 11 Feb 2022 15:58:32 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2022-02-11 at 14:52 +0000, Liu, Yongxin wrote: > Hi, > > If there is no suitable firmware found (no firmware loaded), this patch will cause the following general protection fault. > Please help to check. > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=bea2662e7818e15d7607d17d57912ac984275d94 johannes