Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liu, Yongxin" <Yongxin.Liu@windriver.com>
To:     "luca@coelho.fi" <luca@coelho.fi>,
        "johannes.berg@intel.com" <johannes.berg@intel.com>,
        "luciano.coelho@intel.com" <luciano.coelho@intel.com>
CC:     "kvalo@kernel.org" <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 07/10] iwlwifi: fix leaks/bad data after failed firmware
 load
Thread-Topic: Re: [PATCH 07/10] iwlwifi: fix leaks/bad data after failed
 firmware load
Thread-Index: AdgfVauCp5wZfrvxQ1Cb/o71sZvmVA==
Date:   Fri, 11 Feb 2022 14:52:43 +0000
Message-ID: <PH0PR11MB51755AE791AC9BBE5B97DCF9E5309@PH0PR11MB5175.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VGOfGYIeEGzSRMC8k0yVADeVBlVVdMxRPHh0gVga747+2bu+6sCdv5KR1OIe?=
 =?us-ascii?Q?YNl2v5C54hIOov4ZjXNjkmiqjJsUaqoT0wEBj3j5wXW5V9qGFDOuj272QF17?=
 =?us-ascii?Q?xCJDozq4VHZSYb7EarrvupBIQJeRIzwE4HMbiWA8Qb0FQ3MbAl2ilmAa9QvQ?=
 =?us-ascii?Q?0uYog8yAWtlGLZVg83K40C0O983gf63eKcoAuVmpXqnUv3yZV3IamAWdar8H?=
 =?us-ascii?Q?LYEXGwqjfWGeWw7vu23zc04BBkPK+LbGKnBopeQiz+LoyKCWxWUjNP1BhKAW?=
 =?us-ascii?Q?HaBNuVfxr0BUGVphWvUBhd/iErU8vRbHASziHfoG5JNTvXfkfqdAz4lSCng2?=
 =?us-ascii?Q?mv+IKo+I+civl/kNWQPQW5DTLvxurLi9AKNtrxyXArTbHFrpcpWVVQjwv+JD?=
 =?us-ascii?Q?O1dIZz8ZZ+uE0+pILwXXR6vC+MzeQs9Va/9Nh3/bhhKqkPCTjyQTbslzVJLA?=
 =?us-ascii?Q?MH+asOf0cYLF8vN4/pDeqFikgxHbTgGYXbxTU9h56u88uhF5RGGPZARcBLTq?=
 =?us-ascii?Q?J/DvrVUAwEtgdFQD6Cvfe8LOuhaqNEQlRa/htNlv2sl6RWDTHWSyGUVCMD5G?=
 =?us-ascii?Q?4uJrPu/ALN+H+ghojk462ib7l4upYJ8wV5b6W/f1tluVTlpI5gxdmSrlrI3J?=
 =?us-ascii?Q?ygZBvvGMliKIR2PBxuy/O/FpnzAIGlhMr5wQ2TIzcS8kOWp4sKbSCLKiVK0c?=
 =?us-ascii?Q?co3YD0Eqh14qi18Boy6zQxLmgNDSPauA6qOLy2R3/TylL/gj2em+uv7R887v?=
 =?us-ascii?Q?TvyZEPgt8EBENR+tmUfiQLjnpfaohneUlvF0Q1O19a27raOvtSbThnAGM6HO?=
 =?us-ascii?Q?zDZtn/UFRfTosN0blvNiprrvMVsCfjEW3I9zADh+GuEnebFZQtF8kfpZ0bJX?=
 =?us-ascii?Q?h5Z/D34t7kTQoE7f7r/PJIXLJDD96WuheGBau8kztaZ94Y92tVv5PnEIdzfw?=
 =?us-ascii?Q?0PIWfzm+bRwsQS+Tco0gHWLGOxNbu2qXS4ObLgBwBICC26e/nUPvfZ4DJuJh?=
 =?us-ascii?Q?iNJxakxLAqwI6mMGHTcGJr0inrOorKycIBoGiMIlajtCfcDpi15AzNl4BAXc?=
 =?us-ascii?Q?6XDbxRmn9W8rxCSRaj909VFdckLs3qZv+jXPKYomqUahag2BzRSM5kufVTk0?=
 =?us-ascii?Q?x5TM93tkSCyAAnISnVXRc/w/NvZnALVRQ9HN+WujVOt4QY7Jqe0sC35YbnO5?=
 =?us-ascii?Q?MWt90vYs+SAq3pSEF7wWWeaz1g3Bjpy1NdPS4mrxiztY/kQ89Dm+QwWzHcQr?=
 =?us-ascii?Q?T4ODwRz0XHO4O+0BkiEwYSS6uV8eRpuqr6Ic3vGb07NJLIMNub1lsOWeT/35?=
 =?us-ascii?Q?Tc8lkx/t7WlEtDpJ/it4avA5t1klZ/gOVFdETpvi0pkUpqJ2iI+ApxpE0CXt?=
 =?us-ascii?Q?KmT52UjEdUNfnuenfdHxIN6BRd5IJw4+zf/uy/1Qz0nlaebZYkIQ/w960w+c?=
 =?us-ascii?Q?zpmLKXTl9YPjBopkqA8hfJ8MLHgXxrsDYxD6fRCenwx5zorXyXog5GNmu4jE?=
 =?us-ascii?Q?X0wBtFz5k8CfTPrhlEoPJWJ3nAokNCY18CexgCASH442YdlKAgWshKyTKw7s?=
 =?us-ascii?Q?QZ30TWH3IR++qsuvIzPta6t5LMteCxYFLZzBHjJ3CP9EmoLxRWa7HXJpK1hg?=
 =?us-ascii?Q?y5Y+9mouHA0da2uNLdKEGWeWAPgQX2mCkmdR1tUwoEaUcDxa5Sf0fTifk1CV?=
 =?us-ascii?Q?HBp2rA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5175.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e88cf55-21cf-4081-4da3-08d9ed6e28d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 14:52:43.5377
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J8om+eypF3lHGPLERG6649RVuUtUCYRV8E4X+0800TqKV6SozI+LalrpXnVM8D2zyivkXanDRhUu4iuyYTOGSEGgmyIenjJHlkrLhUT51Gg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1907
X-Proofpoint-GUID: QLSAp7vHM4IIpwya3bp5-pC4meQIw8Wp
X-Proofpoint-ORIG-GUID: QLSAp7vHM4IIpwya3bp5-pC4meQIw8Wp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-11_05,2022-02-11_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0
 mlxlogscore=701 clxscore=1011 priorityscore=1501 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202110082
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi,

If there is no suitable firmware found (no firmware loaded), this patch wil=
l cause the following general protection fault.
Please help to check.

  Intel(R) Wireless WiFi driver for Linux
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-36.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-35.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-34.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-33.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-32.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-31.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-30.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-29.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-28.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-27.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-26.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-25.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-24.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-23.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: Direct firmware load for iwlwifi-8265-22.ucode fail=
ed with error -2
  iwlwifi 0000:01:00.0: no suitable firmware found!
  iwlwifi 0000:01:00.0: minimum version required: iwlwifi-8265-22
  iwlwifi 0000:01:00.0: maximum version supported: iwlwifi-8265-36
  iwlwifi 0000:01:00.0: check git://git.kernel.org/pub/scm/linux/kernel/git=
/firmware/linux-firmware.git
  general protection fault, probably for non-canonical address 0xd8fdf3bf00=
1008: 0000 [#1] PREEMPT SMP PTI
  CPU: 3 PID: 48 Comm: kworker/3:1 Not tainted 5.17.0-rc3 #3
  Hardware name: Intel Corporation NUC7i5DNKE/NUC7i5DNB, BIOS DNKBLi5v.86A.=
0074.2021.0716.1950 07/16/2021
  Workqueue: events request_firmware_work_func
  RIP: 0010:kfree+0x6a/0x410
  Code: 0f 82 b5 03 00 00 48 c7 c0 00 00 00 80 48 2b 05 4c 59 65 01 48 8b 1=
5 35 59 65 01 4d 8d 24 07 49 c1 ec 0c 49 c1 e4 06 49 01 d4 <49> 8b 44 24 08=
 48 8d 70 ff a8 01 4c 0f 45 e6 49 8b 04 24 f6 c4 02
  RSP: 0018:ffffaa8cc0247cb0 EFLAGS: 00010207
  RAX: 0000676040000000 RBX: 36415f5f0004000f RCX: 0000000000000000
  RDX: fffff6d8c0000000 RSI: ffffffffc071342b RDI: 36415f5f0004000f
  RBP: ffffaa8cc0247ce8 R08: 0000000000000000 R09: ffffaa8cc0247b80
  R10: 0000000000000000 R11: 0000000000000171 R12: 00d8fdf3bf001000
  R13: ffff98a043b04000 R14: ffff98a047f1d800 R15: 36415f5f8004000f
  FS:  0000000000000000(0000) GS:ffff98a1a5d80000(0000) knlGS:0000000000000=
000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007f2e28bb2738 CR3: 000000022880a002 CR4: 00000000003706e0
  DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
  DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
  Call Trace:
   <TASK>
   iwl_dealloc_ucode+0x3b/0x100 [iwlwifi]
   iwl_req_fw_callback+0x379/0x25e0 [iwlwifi]
   ? __dev_printk+0x52/0x6c
   ? _request_firmware+0x3f1/0x560
   request_firmware_work_func+0x51/0xa0
   process_one_work+0x1d2/0x3d0
   ? rescuer_thread+0x350/0x350
   worker_thread+0x50/0x3e0
   ? rescuer_thread+0x350/0x350
   kthread+0xfc/0x120
   ? kthread_complete_and_exit+0x20/0x20
   ret_from_fork+0x22/0x30
   </TASK>


Thanks,
Yongxin