Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <13d897bae6ac5bfd25c7b2e2c80fdaac392334ce.camel@sipsolutions.net>
Subject: Re: [PATCH v2 06/19] cfg80211: Add data structures to capture EHT
 capabilities
From:   Johannes Berg <johannes@sipsolutions.net>
To:     "Aloka Dixit (QUIC)" <quic_alokad@quicinc.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     "Vikram Kandukuri (QUIC)" <quic_vikram@quicinc.com>,
        "Jia Ding (QUIC)" <quic_jiad@quicinc.com>,
        "Karthikeyan Periyasamy (QUIC)" <quic_periyasa@quicinc.com>,
        "Muna Sinada (QUIC)" <quic_msinada@quicinc.com>,
        "Sriram R (QUIC)" <quic_srirrama@quicinc.com>,
        "ilan.peer@intel.com" <ilan.peer@intel.com>
Date:   Fri, 11 Feb 2022 20:03:04 +0100
In-Reply-To: <DM8PR02MB7958C66988E52F40F0ED8A6AFE309@DM8PR02MB7958.namprd02.prod.outlook.com>
References: <20220210192008.188166-1-johannes@sipsolutions.net>
         <20220210201853.c40044dc90e9.I2413a37c8f7d2d6d638038a3d95360a3fce0114d@changeid>
         <DM8PR02MB7958C66988E52F40F0ED8A6AFE309@DM8PR02MB7958.namprd02.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

(something weird happened with your quoting?)

> An instance of struct ieee80211_eht_cap_elem should be added in struct
> cfg80211_ap_settings (same goes for operation element) as well and
> parsing in nl80211_calculate_ap_params().

AP mode, especially non-mac80211, wasn't really high on our list ...

I'm also not sure it really belongs to this patch, since this patch was
just meant to capture the EHT capabilities of the device, not support AP
mode :-)

I think I'd prefer to have a separate patch, later, and we can discuss
whether I should submit that or you want to (I cannot really test it).
Any objections?

This is already 19 patches anyway, plus a few other prerequisites I sent
separately, so I think in the interest of getting anything done ...

I know we also don't connect with 320 MHz yet (the EHT operation element
is also not really well defined in the spec so far, we just have a bit
of a stub definition for it), and other things are for sure missing.

Any objections to doing things step by step?

johannes