Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Feb 2022 18:21:57 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Chad Monroe <chad.monroe@smartrg.com>
Cc:     Felix Fietkau <nbd@nbd.name>,
        Johannes Berg <johannes.berg@intel.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: connac: adjust wlan_idx size from u8 to u16
Message-ID: <Ygk+NbOPnIzphMSd@lore-desk>
References: <a0644f7da6ba09195ee247a5affa562179328207.1644688718.git.chad.monroe@smartrg.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hPEQp+DxvyZdzxkr"
Content-Disposition: inline
In-Reply-To: <a0644f7da6ba09195ee247a5affa562179328207.1644688718.git.chad.monroe@smartrg.com>
Precedence: bulk


--hPEQp+DxvyZdzxkr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Thx for fixing it.
I guess we can add the following Fixes tag:

Fixes: 49126ac1f8d26 ("mt76: connac: move mt76_connac_mcu_bss_basic_tlv in =
connac module")

Anyway:

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> Newer chips such as MT7915 require up to 16-bits for this field.
>=20
> Signed-off-by: Chad Monroe <chad.monroe@smartrg.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +-
>  drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drive=
rs/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> index cdd82a62eeb1..f3fdd755a3bb 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> @@ -2656,7 +2656,7 @@ EXPORT_SYMBOL_GPL(mt76_connac_mcu_bss_ext_tlv);
>  int mt76_connac_mcu_bss_basic_tlv(struct sk_buff *skb,
>  				  struct ieee80211_vif *vif,
>  				  struct ieee80211_sta *sta,
> -				  struct mt76_phy *phy, u8 wlan_idx,
> +				  struct mt76_phy *phy, u16 wlan_idx,
>  				  bool enable)
>  {
>  	struct mt76_vif *mvif =3D (struct mt76_vif *)vif->drv_priv;
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drive=
rs/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> index 7b9d82dd3f9d..384c3eab1c8a 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> @@ -1642,7 +1642,7 @@ void mt76_connac_mcu_bss_omac_tlv(struct sk_buff *s=
kb,
>  int mt76_connac_mcu_bss_basic_tlv(struct sk_buff *skb,
>  				  struct ieee80211_vif *vif,
>  				  struct ieee80211_sta *sta,
> -				  struct mt76_phy *phy, u8 wlan_idx,
> +				  struct mt76_phy *phy, u16 wlan_idx,
>  				  bool enable);
>  void mt76_connac_mcu_sta_uapsd(struct sk_buff *skb, struct ieee80211_vif=
 *vif,
>  			       struct ieee80211_sta *sta);
> --=20
> 2.32.0 (Apple Git-132)
>=20

--hPEQp+DxvyZdzxkr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYgk+NQAKCRA6cBh0uS2t
rMpAAQDwkrw5UKBqElKj8k80s9mWHyVwxadFBsfy8U6ooKJmBQEAuSFOvB0uw5sh
zVa82nYMLMqqBE86wcSD5HIMM/cgrwA=
=A9mv
-----END PGP SIGNATURE-----

--hPEQp+DxvyZdzxkr--