Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp860016pxb; Wed, 16 Feb 2022 06:04:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJy62AqbmfKqUWmUKn++AHixwiPtFK/sFvnX7AwNNNV4cIaA6wfFlxx5Ilrsozu5HD3njCE0 X-Received: by 2002:a05:6870:678d:b0:d3:115a:4046 with SMTP id gc13-20020a056870678d00b000d3115a4046mr522360oab.181.1645020257467; Wed, 16 Feb 2022 06:04:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645020257; cv=none; d=google.com; s=arc-20160816; b=VrtPWWSjtKH90p8CSuK+RKcjgnBJnTiIbl+yao8ESYjAY6OT+yKcQ3omJlbAVOSDh0 MHI2aBC1/X7klscTh+kIZC/DpFxyfNLHfN6zBNDOgAqFQZfk3jhdTfY7jlP6Rcn8bD2t DxkdYeo5RhUp+pYY8qOeMzCEcDWTa7Umf1RmsCxyZl2JOAj+csg3QX9OvvQQ+77CNklY UlLajpRB2kARbQUufBbQNL5XaWtXwWg6gd/fHA+f4zwudxfx/p/m1gQyov8FE5da7K1F 2aLk3dUm4ElJSQxfzuWP6z0IWvtchKfiyW5CLBUGufL0RQcoKO7QokioDjvV7FNvbxDp eEfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=W4NWQ4O/W36pB+bOALZ9wlT2YlOr6PG7OHv6tykJwH0=; b=m1vcsNEbV3NEFoCT07K5Bxl0yZ8NZDh34h9FszNS0luGV/geVfi6ID24n6FV6jI5in mumU7PtuddbNdKKPtxIqB1lwAZuHBnvLUQYAu5vtARp5VL1cf7byzFiiag9Awhmlii1D G/A9l22PUjCbPkTfsEV0oXa5VZNN+VHxpMvnPXcYTfVzrbO+RG52kdCEOJkAoYBKBMpK P+xbQqxcrjUHP0F/cv4SkUkkfxXtu6UxWgaUciNMRpbMKRlXY/MjOm5s2Iq44WU5qfN6 izvEL4bZCHbq4WEy5E0NtmrQdx7pKYK70JE10Hvm8evyOBVKeG6i/wDiKHa1gB0L+AtE TwLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lAHHTLBX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a18si14580836otp.77.2022.02.16.06.04.01; Wed, 16 Feb 2022 06:04:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lAHHTLBX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234223AbiBPN2H (ORCPT + 73 others); Wed, 16 Feb 2022 08:28:07 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234152AbiBPN2G (ORCPT ); Wed, 16 Feb 2022 08:28:06 -0500 Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA6F7151D3E; Wed, 16 Feb 2022 05:27:54 -0800 (PST) Received: by mail-vs1-xe36.google.com with SMTP id p7so2451142vsg.2; Wed, 16 Feb 2022 05:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W4NWQ4O/W36pB+bOALZ9wlT2YlOr6PG7OHv6tykJwH0=; b=lAHHTLBXwuKLLUHWaLseZjIP5cTvJsu69Q9thecmcZ3q0ffGHTCcOfDZJgQ+BsaU7X VJaGthSGbyLDnlUhzTNOirmBB5F7Qt2EEk+RrmOT7+T5WuR8cdDnJMknl0tWouNlGuVh 9mhATRhNi19QIAqUZHBI9t2YXVYTD5EUoVudmzAEgZdEoVQTZuF+8xlDPDcIFRRwOn8g aUi/maLv8i6RYOy6i+1AX3tkKmgBfUDfKVKAYtOhjVYzCjYnN86wGxGPqUL7SqtqgDe1 SUnNRDnQa+P+Bx++qp0oDSbhsRilT2mpDr7NtF0lcnwKAsJa1C4D94jqqd9Cy1g/0u0G Sy+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W4NWQ4O/W36pB+bOALZ9wlT2YlOr6PG7OHv6tykJwH0=; b=V2sejGUzsw+owRORLV0RcJtv+W8tZmQP0luzIB7ny4catcJ5jZgLqKjNXO0zosbK8Z K9hz4BZsoreztivnSTFi4YhG/x4c1v8caRdZnfqhVjsGDhWhAzmlCd6yyNrJBnIDbwkR Imoty/50X/c4hwfA0K1O9H/kMDCFCOkpV9DE0dik+zrT34d6Y2NGlsf6KtyW+E6F+uPW W6GF/AWvtnDxYgwOQmpdLhXuskmifoOEz29o+M0tO/nYXBSp7v9hFsIRKmR1d4QK9VGk L566R+wTVlfyXGayKgf7PDWb5WS99xR2sxWPmB7kYoFr5AuO1ZSdiCDwTntwzCYPw+Sm Q3Rw== X-Gm-Message-State: AOAM533xgAr5V0CWj2R4dQOnW2i3tVFTg4nRvA+kG13wwux6+KwMFHJj qQytLTX6qLDlU+GCoyVOcQPzAZ2QFLAj8YMy6A== X-Received: by 2002:a05:6102:2912:b0:31a:5ab3:f44b with SMTP id cz18-20020a056102291200b0031a5ab3f44bmr1066907vsb.53.1645018073916; Wed, 16 Feb 2022 05:27:53 -0800 (PST) MIME-Version: 1.0 References: <20220216113323.53332-1-Jason@zx2c4.com> In-Reply-To: <20220216113323.53332-1-Jason@zx2c4.com> From: Rui Salvaterra Date: Wed, 16 Feb 2022 13:27:42 +0000 Message-ID: Subject: Re: [PATCH v3] ath9k: use hw_random API instead of directly dumping into random.c To: "Jason A. Donenfeld" Cc: miaoqing@codeaurora.org, =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , "Sepehrdad, Pouyan" , ath9k-devel , "linux-wireless@vger.kernel.org" , Kalle Valo , Dominik Brodowski , Linux Crypto Mailing List , Herbert Xu , LKML , Netdev , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Florian Fainelli Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi again, Jason, On Wed, 16 Feb 2022 at 11:33, Jason A. Donenfeld wrote: [snipped] > Changes v2->v3: > - Use msleep_interruptable like other hwrng drivers. > - Give up after 110 tries. > - Return -EIO after giving up like other hwrng drivers. > - Use for loop for style nits. > - Append serial number for driver in case of multiple cards. [snipped] Everything working as expected here, so this patch (v3) is also Tested-by: Rui Salvaterra Thanks, Rui