Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp1230144pxb; Wed, 16 Feb 2022 14:09:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzq0wKhM4v/fLaI1MaW0Lk7m8H9RFfj/RGyyIrb1lkuujYimIYhnqbV+sxmHf0FFLptvInQ X-Received: by 2002:a05:6a00:1513:b0:4e1:7460:9b6b with SMTP id q19-20020a056a00151300b004e174609b6bmr5188829pfu.14.1645049369252; Wed, 16 Feb 2022 14:09:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645049369; cv=none; d=google.com; s=arc-20160816; b=kgEnp+A/2g2DLEP/iIBDo8v+eIwKdB/Yv8GJl4YkqTTxPaARgD2sYBdwZ4TEdomA/F i27Iaqiq00Z/Ul7T2HLDGeVeKl2d2DJU+ZLpD2gXAGcDfUeQUjFtUD4SAXe5EVykiWPo b0ujFT05pa9zTqZwflnB6SFLV+bUT3HPkPr2et6hcOZtrorUZiQUi0VA0vlARPxsmrcq z1fd5FN8hKFwelS6sy9RiPJxsnJ23rzgwgWRbkTQwgRmgEVCE5AntZOTpJ8LIIRx8krm tBjqDE8kVaQtEjndrQoTHoPAJAZrB0BlYAOT2ceb4wPaoEtOl+sR+uUOUdpIvuv6gEO7 2+Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=R+lMIcQ67ktVMGNdluwkKxWdPbWXdi+nQ98yG9idefk=; b=Kthy8ffW6XwEGDNA+OmQYN/S/rb03TRe5fubS1VM3wTtzHZVf3jvtYAPLS7gzSa9Pn 2mCsaPcd2TM5uHwDAQT3m1rtVdSBo4VLatEz2n4h14EU/pb3kAkN+8Lb6MofLHElNKNb 6yOvkknFFIhUzYaPmzpdK1UmsKOTmM/RNLg0cRFy8ohvEFaeVVIVPIyvtwdhkYHa25L/ SNWM2/gGNR7U8g2IJW2vRILz0aazoDkEoIPbs4HNgn7U03X3yPPJZe1SR31++gzkcqjI HHzJHsUINr7gTGXGiurjCueDtLEf26234RbYJ7q9lkzz9Zo7s74On0/+ZAp3IVZo1cZW dpVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c2FzKYUe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16si21501161plh.154.2022.02.16.14.09.17; Wed, 16 Feb 2022 14:09:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c2FzKYUe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238244AbiBPTnF (ORCPT + 73 others); Wed, 16 Feb 2022 14:43:05 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238080AbiBPTnE (ORCPT ); Wed, 16 Feb 2022 14:43:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99FB9DB872; Wed, 16 Feb 2022 11:42:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 388096185D; Wed, 16 Feb 2022 19:42:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF4F9C004E1; Wed, 16 Feb 2022 19:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645040570; bh=EpzO/qjFt4Dx1JWZ/24how7avVB7hBpk4SufEDsrHI4=; h=Date:From:To:Cc:Subject:From; b=c2FzKYUeXpvxpDysxrigYpGK3Mc7OPWQGEdNS1xMC5/CXFlGqk2lkOBupZXG067EA OWDBJkKwgbOUAi1Z61+D2TnXdM20/6rH9Ssc24DQxCNEKJVNHBd2zzh4UmAj9OUclE NIAafAqG8Ded2JUyL8TQTowzQ5CuxX9j/FGKG0rGMyG0iD7yCOqv7p6eOsxJddmC4y L+ys5UcznUjC72mI8uFKxnG/nXryjmqz6/rL1X0GoMs0cE34ly+dzEB3Y9uMPrzrgO L7k10uPIhJU2+vNUqZaKmhGfOjx+UMW44QK0vbrPWKf6lhnc0lO+VqbOqkB1iZ44wc 4/jkmy9qa58Ug== Date: Wed, 16 Feb 2022 13:50:30 -0600 From: "Gustavo A. R. Silva" To: Luca Coelho , Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] iwlwifi: mei: Replace zero-length array with flexible-array member Message-ID: <20220216195030.GA904170@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/intel/iwlwifi/mei/sap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mei/sap.h b/drivers/net/wireless/intel/iwlwifi/mei/sap.h index 11e3009121cc..be1456dea484 100644 --- a/drivers/net/wireless/intel/iwlwifi/mei/sap.h +++ b/drivers/net/wireless/intel/iwlwifi/mei/sap.h @@ -298,7 +298,7 @@ struct iwl_sap_hdr { __le16 type; __le16 len; __le32 seq_num; - u8 payload[0]; + u8 payload[]; }; /** -- 2.27.0