Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3691920pxb; Mon, 21 Feb 2022 03:52:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXmHsPjtOqZT14r6PJ7VaWGSj9JSMym/xBKmPj6gtTC++iZ88bxn1tE9u/geImLDE7bvQ5 X-Received: by 2002:a17:906:7c0c:b0:6b3:d16e:7e40 with SMTP id t12-20020a1709067c0c00b006b3d16e7e40mr15987022ejo.104.1645444320960; Mon, 21 Feb 2022 03:52:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645444320; cv=none; d=google.com; s=arc-20160816; b=usXQGgl1EMENmF6vtZ0A15pY3ToD22WPbGhltcKvI3rtneEjbNMecsV9Yk2FYDmBWI xnBMvSX74IuBi0aUz/5COiXvZJelfyt3nh8Sa7oWn/US5K5JCTLDECU8sLFTE9/YlIuu MYXp0xKvZsG05DWH87NTp1IUkhFLCcKqKuu8gy5zADkISSizHWzeoLJUtD/b4lRqaxL5 xND/FQ8qAUJaxD7/LmrksK4BN/zN/WIHKWK5AlXsxp5Rf0u2IT0xRn4TQFlrSSXjQKli spT6HfueImlajEW+EU45iuuIx5u3lSI16I72nYs23UrfcdyePrj5ahCRXY04++5ps2qW FuPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=FACknTaYY90k8k7UqF/i6oS98dNo56W2Lk9LeIMJ1vI=; b=pHjma1mjaz+IPDMiiKPzgvDFWeXw9N+EAAfjJkRu2JeHSDSwOGXeH47ESpAMwbc5mj 1i8StN79kzesbdeB04hv0cUkrnKe+nnRQmevUCCVww0sonkUR9AR9353yZAlLzng8b1a jJW9WmYbV0hzRf7btoWVsL3PZIidMFA8LWF2swFbdZJAuFKK7lbS9YB40CBAB3ws9SIk cMG+CkGxnop2Ql540zDj1uvgo67CiSjwmoACjP2lwQp1ZBeTlAGTXoEHs7TjU2jsbXY3 gDRAbb15F98AYeI3ud+HXxkU9MehgIsSkHmGcOkTdd98HGdL/GoZJw53vFWItZ/Gs4kn /JXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ByCHktco; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa37si8388937ejc.833.2022.02.21.03.51.37; Mon, 21 Feb 2022 03:52:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ByCHktco; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345230AbiBUK7X (ORCPT + 72 others); Mon, 21 Feb 2022 05:59:23 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344498AbiBUK60 (ORCPT ); Mon, 21 Feb 2022 05:58:26 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55C2831927 for ; Mon, 21 Feb 2022 02:28:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0977EB80DA4 for ; Mon, 21 Feb 2022 10:28:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7BA4C340E9; Mon, 21 Feb 2022 10:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645439324; bh=yTf6jL73vntZaHIBChTJh2VJ4HOTz4q/XMDKDrjD3Bw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ByCHktconmI8ixmMLXfyosbEkfgu/TDiUnLkP5aZ7+h5ecqwjOFdlcS9rsSlRXU1O gN+34kG8XOpJTgFn6wfIyQH5TXOc8lgAeIQf8v4IbPrC1wL68ynkjtpgYUFLxuz/zf zeQ03TOfTU5SQDfFm/u1xG6lwsNkSt/2Uie1bteBfw76eWii6g2gxMC+Mi5Kqj1jkA CuYfryIMsQVcoDs5m2W98F42Lecikrfx3IqgxS65Hye1eCwTmX6UfRYKh2Y1becDLH C4gQLLCLGSaodcJL4OZIV/7R52j8rRlwICM/tTm0zemuFJblhkgjZhxOV5PVu0Xjk8 Qoh2gA0T77AwQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Handle failure in qmi firmware ready From: Kalle Valo In-Reply-To: <1645079195-13564-1-git-send-email-quic_seevalam@quicinc.com> References: <1645079195-13564-1-git-send-email-quic_seevalam@quicinc.com> To: Seevalamuthu Mariappan Cc: , , Seevalamuthu Mariappan User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164543932220.26423.15078831707395923545.kvalo@kernel.org> Date: Mon, 21 Feb 2022 10:28:43 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Seevalamuthu Mariappan wrote: > In some scenarios like firmware crashes during init time > and hardware gets restarted after qmi firmware ready event. > During restart, ath11k_core_qmi_firmware_ready() returns timeout. > But, this failure is not handled and ATH11K_FLAG_REGISTERED is set. > > When hardware restart completed, firmware sends firmware ready event > again. Since ATH11K_FLAG_REGISTERED is already set, ath11k handles > this as core restart. Inits are not done because of previous timeout. > But ath11k_core_restart does deinit's which causes NULL pointer crash. > > Fix this by handling failure from ath11k_core_qmi_firmware_ready(). > > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-00881-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Seevalamuthu Mariappan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a19c0e104db9 ath11k: Handle failure in qmi firmware ready -- https://patchwork.kernel.org/project/linux-wireless/patch/1645079195-13564-1-git-send-email-quic_seevalam@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches