Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 4 Mar 2022 14:46:35 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Jouni Malinen <j@w1.fi>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, hostap@lists.infradead.org,
        linux-wireless@vger.kernel.org, nbd@nbd.name,
        ryder.lee@mediatek.com, evelyn.tsai@mediatek.com
Subject: Re: [PATCH 8/9] DFS: switch to background radar channel if available
Message-ID: <YiIYOzben74/wF/d@lore-desk>
References: <cover.1640014128.git.lorenzo@kernel.org>
 <ec706e090d7e44bcc9afd2f9789802f8c07e3c3f.1640014128.git.lorenzo@kernel.org>
 <20220303222009.GC33342@w1.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0kc95zljO+Fjl9/s"
Content-Disposition: inline
In-Reply-To: <20220303222009.GC33342@w1.fi>
Precedence: bulk


--0kc95zljO+Fjl9/s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Mon, Dec 20, 2021 at 04:48:23PM +0100, Lorenzo Bianconi wrote:
> > On radar detection on the main chain switch to the channel monitored
> > by the background chain if we have already performed the CAC there.
>=20
> Is it clear that the channel on the background chain, if one is
> available with CAC performed, comply with the ETSI uniform spreading
> requirements? The comment below feels a bit misleading, but the way
> patch 5/9 picks the channel for background CAC might be sufficient for
> this. If so, it would be good to note that in the comment here:

ack, got your point here. We should force channel_type to DFS_ANY_CHANNEL
for ETSI regdmain in hostpad_dfs_update_background_chain() and not just
DFS_NO_CAC_YET. I will fix it in next revision. Thanks.

Regards,
Lorenzo

>=20
> > diff --git a/src/ap/dfs.c b/src/ap/dfs.c
> > +hostapd_dfs_background_start_channel_switch(struct hostapd_iface *ifac=
e,
>=20
> > +	/*
> > +	 * If background radar detection is supported and radar channel
> > +	 * monitored by background chain is available switch to it without
> > +	 * waiting for the CAC otherwise let's keep a random channel.
>=20
> That first part leaves it a bit open whether the random channel part from
> the end of the sentence applies in practice for the new operating
> channel. It is important to make this clearly describe the functionality
> needed to meet uniform spreading requirement.
>=20
> --=20
> Jouni Malinen                                            PGP id EFC895FA
>=20

--0kc95zljO+Fjl9/s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYiIYOwAKCRA6cBh0uS2t
rMAtAQC74SmxQqvKrUhntSYvQS7xZI7Pal1eDgmxft1dG45NVQD/Yf0bqfb6g8Ug
u6QcANGr+2IzTV/KuLVZgQAySVF4Ngc=
=Bs87
-----END PGP SIGNATURE-----

--0kc95zljO+Fjl9/s--