Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220223223326.28021-1-ricardo.martinez@linux.intel.com> <20220223223326.28021-10-ricardo.martinez@linux.intel.com>
In-Reply-To: <20220223223326.28021-10-ricardo.martinez@linux.intel.com>
From:   Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date:   Mon, 7 Mar 2022 05:59:24 +0300
Message-ID: <CAHNKnsQqC1B+5c0jDqD2WUR2HB_-WKV4nvsRoCK-1Sn95x6xDA@mail.gmail.com>
Subject: Re: [PATCH net-next v5 09/13] net: wwan: t7xx: Add WWAN network interface
To:     Ricardo Martinez <ricardo.martinez@linux.intel.com>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        David Miller <davem@davemloft.net>,
        Johannes Berg <johannes@sipsolutions.net>,
        Loic Poulain <loic.poulain@linaro.org>,
        M Chetan Kumar <m.chetan.kumar@intel.com>,
        chandrashekar.devegowda@intel.com,
        Intel Corporation <linuxwwan@intel.com>,
        chiranjeevi.rapolu@linux.intel.com,
        =?UTF-8?B?SGFpanVuIExpdSAo5YiY5rW35YabKQ==?= 
        <haijun.liu@mediatek.com>, amir.hanania@intel.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        dinesh.sharma@intel.com, eliot.lee@intel.com,
        ilpo.johannes.jarvinen@intel.com, moises.veleta@intel.com,
        pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com,
        Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com,
        madhusmita.sahu@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 24, 2022 at 1:35 AM Ricardo Martinez
<ricardo.martinez@linux.intel.com> wrote:
> From: Haijun Liu <haijun.liu@mediatek.com>
>
> Creates the Cross Core Modem Network Interface (CCMNI) which implements
> the wwan_ops for registration with the WWAN framework, CCMNI also
> implements the net_device_ops functions used by the network device.
> Network device operations include open, close, start transmission, TX
> timeout, change MTU, and select queue.

[skipped]

> +static u16 t7xx_ccmni_select_queue(struct net_device *dev, struct sk_buff *skb,
> +                                  struct net_device *sb_dev)
> +{
> +       return DPMAIF_TX_DEFAULT_QUEUE;
> +}

[skipped]

> +static const struct net_device_ops ccmni_netdev_ops = {
> +       .ndo_open         = t7xx_ccmni_open,
> +       .ndo_stop         = t7xx_ccmni_close,
> +       .ndo_start_xmit   = t7xx_ccmni_start_xmit,
> +       .ndo_tx_timeout   = t7xx_ccmni_tx_timeout,
> +       .ndo_select_queue = t7xx_ccmni_select_queue,

Since the driver works in the single queue mode, this callback is unneeded.

> +};

--
Sergey