Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <f1ee04ce-3ac4-f68d-193a-25b09bd6cf41@quicinc.com>
Date:   Tue, 8 Mar 2022 15:59:04 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH] mac80211: correct legacy rates check in
 ieee80211_calc_rx_airtime
Content-Language: en-US
To:     MeiChia Chiu <MeiChia.Chiu@mediatek.com>,
        Johannes Berg <johannes@sipsolutions.net>
CC:     Ryder Lee <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        <linux-wireless@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>
References: <20220308021645.16272-1-MeiChia.Chiu@mediatek.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220308021645.16272-1-MeiChia.Chiu@mediatek.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/7/2022 6:16 PM, MeiChia Chiu wrote:
> There are no legacy rates on 60GHz or sub-1Ghz band, so modify the check.

nit: s/Ghz/GHz/ here and in the code comment

> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: MeiChia Chiu <MeiChia.Chiu@mediatek.com>
> ---
>   net/mac80211/airtime.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/airtime.c b/net/mac80211/airtime.c
> index 26d2f8ba7029..c0e58eb7c7fb 100644
> --- a/net/mac80211/airtime.c
> +++ b/net/mac80211/airtime.c
> @@ -477,7 +477,9 @@ u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
>   		bool sp = status->enc_flags & RX_ENC_FLAG_SHORTPRE;
>   		bool cck;
>   
> -		if (WARN_ON_ONCE(status->band > NL80211_BAND_5GHZ))
> +		/* on 60GHz or sub-1Ghz band, there are no legacy rates */
> +		if (WARN_ON_ONCE(status->band == NL80211_BAND_60GHZ ||
> +				 status->band == NL80211_BAND_S1GHZ))
>   			return 0;
>   
>   		sband = hw->wiphy->bands[status->band];