Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] brcmfmac: check the return value of devm_kzalloc() in
 brcmf_of_probe()
To:     Kalle Valo <kvalo@kernel.org>
Cc:     aspriel@gmail.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, chi-hsien.lin@infineon.com,
        wright.feng@infineon.com, chung-hsien.hsu@infineon.com,
        davem@davemloft.net, kuba@kernel.org, shawn.guo@linaro.org,
        gustavoars@kernel.org, len.baker@gmx.com,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220225132138.27722-1-baijiaju1990@gmail.com>
 <164692859274.6056.13961655347011053680.kvalo@kernel.org>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <adb61d50-8a17-de4b-2757-5c4da1b00ff7@gmail.com>
Date:   Fri, 11 Mar 2022 10:16:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <164692859274.6056.13961655347011053680.kvalo@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2022/3/11 0:09, Kalle Valo wrote:
> Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>
>> The function devm_kzalloc() in brcmf_of_probe() can fail, so its return
>> value should be checked.
>>
>> Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> You are not calling of_node_put() in the error path. And I don't think
> this even applies.
>
> Patch set to Changes Requested.
>

Hi Kalle,

Thanks for the reply :)
I will add of_node_put() and send a V2 patch.


Best wishes,
Jia-Ju Bai