Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp674669pxp; Fri, 11 Mar 2022 12:08:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfpdggGPgXrN7y1ea8Rxo9g5bRqZ7cwiNU+Dua8sDAvMMCcMZk94Ka0QCXc1PFXHKIkrLK X-Received: by 2002:a17:907:6e1b:b0:6db:30f5:980c with SMTP id sd27-20020a1709076e1b00b006db30f5980cmr9643646ejc.359.1647029283709; Fri, 11 Mar 2022 12:08:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647029283; cv=none; d=google.com; s=arc-20160816; b=MZQqXPycB9yyI4Jebgv1el/3kwh6CGLzF3lP0Vmd+OmJ+ige0E2FsGZkBHTFGJkhQC KL0jrbETrV8t4ZHH1VabzCzr/CJsHBHS5FsyzSEAqNRK+2qoYguRGnnvj5GmS0Hz2fTC 52oFQNv4rtxExb8oEugWfDdZ5l8kO7Ys0Md93/xAo76vSMIiAlzwgXClb5XeMWYQq19Y dRTZQSX5m6FJQHW6eNRJRygnNFNUbTEI74hxUjJ9GW0TPAX38natwaQAiSBLJUThkZ8M YecqWDH0FgwUuw2o/PNdnkwEls2K71PhGszhAzwx0G+cqmYqhnu5OKYPsWiO4A9cEcQE TLMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=RChqngkkOkfqZxUnk5T9mEkJiANxo7SnNQDYq5MExmw=; b=lZQw2rIV+hsrbJXO41BHvMLtGi0a2YcviC0Ogp9ZS1ps4Z7/63sK1EKRxGY7LkNfGW 2GWxV266ItAEdNKMvPsb11PhygRKqDaN/th1Pd1bW4+LLY7ERkRjGUBm4k1w5z1Bk2lp yc4azkztafH9fwUP0p3Y0YYennJHZk/YyKycmycdD1Fa0zvIq4jYtw2h1aigr1YiQ61s I0BQQqIucdONedcWVbyQLKvcBC/ZEMUZKbQdl+bxWd0SLzx1EhBlAYTyzMWbO+d/M26l YzfA3NlEdYjBTOUVrV8sFGQ78gZPYXRctnPNlqD72h1Fp35RHJYa+wUp53Eqbznvzc34 m3mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=UCAch1ua; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a056402524a00b00415b72360eesi5613484edd.119.2022.03.11.12.07.13; Fri, 11 Mar 2022 12:08:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=UCAch1ua; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349186AbiCKSFW (ORCPT + 70 others); Fri, 11 Mar 2022 13:05:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343712AbiCKSFW (ORCPT ); Fri, 11 Mar 2022 13:05:22 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FE991B0BD0 for ; Fri, 11 Mar 2022 10:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=RChqngkkOkfqZxUnk5T9mEkJiANxo7SnNQDYq5MExmw=; t=1647021858; x=1648231458; b=UCAch1uaom7ocMkKDmfXbsgbqBO3pGo378kPhrYvN3XqT6S IYck6bT5DlQq0j8dHjqZDs1IWSUiqBX66MVJGDq7Qm8z5MQlJ+qtyX9M+f8YDtuR2+KKKOEz3qFgm lo8sBA3Js6R8oaYXtteds6YZ2BaG00R94J0oNJILOfs0GJtG94gR+qPs1CdNBxUl55h5Bj3cF15JJ SQSUR4rDuUEUuwhseFrprsYi7PQpZKClG84uCVP0/0CVuPFAH2VL47s39inlpcn/8x0miGEaypPL0 3geJzui7SsCK2GlpYUAH6Pb3+LUpkFwA1uorMugaIBFReqsld1nwJXAUNFhzPndA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nSjcZ-00Bzof-H8; Fri, 11 Mar 2022 19:04:11 +0100 Message-ID: <23914231f7ec66a5552ff6cb3fb6ec91a7c6cc61.camel@sipsolutions.net> Subject: Re: [PATCH] qtnfmac: fix null check From: Johannes Berg To: Weiguo Li , igor.mitsyanko.os@quantenna.com Cc: kvalo@codeaurora.org, geomatsi@gmail.com, linux-wireless@vger.kernel.org Date: Fri, 11 Mar 2022 19:04:10 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2022-03-11 at 21:30 +0800, Weiguo Li wrote: > We did a null check after "mac_info->if_comb = kcalloc(...)", but we checked > "mac->macinfo.if_comb" instead of "mac_info->if_comb". Yeah well: mac_info = &mac->macinfo; johannes