Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <18140c6b-bb33-8f3d-b371-fe518d6da47a@lwfinger.net>
Date:   Sun, 13 Mar 2022 11:12:24 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: No support for Realtek 8821CE RFE Type 6
Content-Language: en-US
To:     Stuart Longland <stuartl@longlandclan.id.au>,
        Pkshih <pkshih@realtek.com>, Kalle Valo <kvalo@codeaurora.org>
Cc:     Bogdan Nicolae <bogdan.nicolae@acm.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <CA+ORkNR97EvqPzHu-CoJXwKGH-HQ4B++57RE88MEF-mG=D=Jeg@mail.gmail.com>
 <46a80ab50f594ec1af1016ca272e82fd@realtek.com>
 <CA+ORkNQ_shEZGYQUmRT-_uSp3xkFA2fvfUbyGXzGkP6AmqXf6Q@mail.gmail.com>
 <e57352ddd0644463b398d6dc0a6e6a86@realtek.com>
 <CA+ORkNSzju=Oj4wy8s258exeWOSLEHRAfCoS+ViF-rprdtEr6g@mail.gmail.com>
 <3f5e2f6eac344316b5dd518ebfea2f95@realtek.com>
 <20220313140141.6c736d8a@longlandclan.id.au>
 <20220313152451.692c1508@longlandclan.id.au>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20220313152451.692c1508@longlandclan.id.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/12/22 23:24, Stuart Longland wrote:
> On Sun, 13 Mar 2022 14:01:41 +1000
> Stuart Longland <stuartl@longlandclan.id.au> wrote:
> 
>> On Mon, 8 Nov 2021 03:28:07 +0000
>> Pkshih <pkshih@realtek.com> wrote:
>>
>>>>> 2. If you boot this system into Windows 10, does the 8821CE work properly?
>>>>>     If so, please give me its VID/PID of PCI.
> 
>> … now to try that patch.
> 
> The patch as given does not apply, but I managed to hand-fiddle it:
> 
> --- rtw8821c.c.orig     2022-03-13 15:13:34.406747572 +1000
> +++ rtw8821c.c  2022-03-13 15:14:20.292573052 +1000
> @@ -1498,6 +1498,7 @@
>   static const struct rtw_rfe_def rtw8821c_rfe_defs[] = {
>          [0] = RTW_DEF_RFE(8821c, 0, 0),
>          [2] = RTW_DEF_RFE_EXT(8821c, 0, 0, 2),
> +       [6] = RTW_DEF_RFE(8821c, 0, 0),
>   };
>   
>   static struct rtw_hw_reg rtw8821c_dig[] = {
> 
> This indeed fixes the problem:
> http://static.vk4msl.id.au/2022/03/13-rtl8821ce/patched-dmesg.txt
> 
> [    4.166495] rtw_8821ce 0000:03:00.0: enabling device (0000 -> 0003)
> [    4.173911] Loading firmware: rtw88/rtw8821c_fw.bin
> [    4.185625] rtw_8821ce 0000:03:00.0: Firmware version 24.8.0, H2C version 12
> [    4.273629] rtw_8821ce 0000:03:00.0 wlp3s0: renamed from wlan0
> [    7.186954] rtw_8821ce 0000:03:00.0: start vif 0c:cf:89:ac:ac:be on port 0
> [   16.074249] wlp3s0: authenticate with 7a:45:58:c8:b4:33
> [   16.692213] wlp3s0: send auth to 7a:45:58:c8:b4:33 (try 1/3)
> [   16.693038] wlp3s0: authenticated
> [   16.711971] wlp3s0: associate with 7a:45:58:c8:b4:33 (try 1/3)
> [   16.713480] wlp3s0: RX AssocResp from 7a:45:58:c8:b4:33 (capab=0x1111 status=0 aid=15)
> [   16.713526] rtw_8821ce 0000:03:00.0: sta 7a:45:58:c8:b4:33 joined with macid 0
> [   16.713795] wlp3s0: associated
> [   16.832337] IPv6: ADDRCONF(NETDEV_CHANGE): wlp3s0: link becomes ready
> [   17.241966] rtw_8821ce 0000:03:00.0: failed to get tx report from firmware

Stuart,

Yes, that patch has fallen through the cracks. It has been in my repo at 
git://github.com/lwfinger/rtw88.git since Dec. 31, 2021, but is not in 
wireless-drivers-next, and not in the mainline kernel. I have added the 
maintainer for the wireless drivers to this reply, and I will follow up with him.

Larry


I recommend the GitHub repo as it will get such fixes much more quickly.