Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Coelho, Luciano" <luciano.coelho@intel.com>,
        Kalle Valo <kvalo@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Beker, Ayala" <ayala.beker@intel.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iwlwifi: mei: fix building iwlmei
Thread-Topic: [PATCH] iwlwifi: mei: fix building iwlmei
Thread-Index: AQHYOWTH4D+qq7WbZEyldbmO8WiFsazCW9lA
Date:   Wed, 16 Mar 2022 18:55:41 +0000
Message-ID: <SA1PR11MB5825D9DDC4F622A9B8FA77B9F2119@SA1PR11MB5825.namprd11.prod.outlook.com>
References: <20220316183617.1470631-1-arnd@kernel.org>
In-Reply-To: <20220316183617.1470631-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kRPN67zsbTsYYoZtBos6w3boAm9DLdd5+IKI4bBBkYGUYoYv3kFE70Q1abCT?=
 =?us-ascii?Q?lBIJAU6klnCjSkCumYXYuqyLx43zCL6e1wmfr24nG6ItzA5QBYIGFayqGrXf?=
 =?us-ascii?Q?Ic7Yg5c+4oWNCMc0wB2r8cO1wKkzK2W9i9Im6sZ6FZOycRwQJUFkhRU0OGWF?=
 =?us-ascii?Q?H4LAqXjQ3/mdH0SPvVuqzB2fCchoVL7WYcibk1jJBmhezk8vo+dUNbr5/UNA?=
 =?us-ascii?Q?MAFtK+V4Bb2XGfpOGAhlbcEpwNr0wUuWnvtn+Ue5+82veGVyC3Eutce/d3sW?=
 =?us-ascii?Q?ZC+qe0VYNqXzIl/kd27KAuv5W1Es5XZZ85widEsylZ4FKybumUZHbWnlu5XQ?=
 =?us-ascii?Q?rkTngVpTrhHWA5CyE6WCwcdhHKfE+Vyetb4hSZMQveaTdZ0FOLc4+ly2oLwV?=
 =?us-ascii?Q?+f3cqDtQ0BLtWTmbWsL139ghX/hYoA6wvX9gOZLCoFMuZQ8heFXSYoxNnKo5?=
 =?us-ascii?Q?YzVPpMLsc0jiG6al5jLIEzL0vhgQ5xXFdcpQS7t8JA5m4jupZSJ33nlXYWgL?=
 =?us-ascii?Q?wfvtqsVFWjts4WYDqSFFTlJJrPF0B5cazyECugMfckQ7giSPPIYbCu7nwaHG?=
 =?us-ascii?Q?43EYTWyf3UHmUSi+Gf5rEtPvMboXwXKZlWZd/WZ+TS8g/pvQOGSqudX0sXUB?=
 =?us-ascii?Q?7BEmIrZ3f6wfo/l9EVw7MUZX/XjzyGDIgsxSG4IHLju3uZW21u5lVgEaiu9k?=
 =?us-ascii?Q?LmWiZE4Z/zPpH6HKzsfVcRu/oOYdOONxXqMI8xM+vq6zyPW5mAH5nWQfGdxJ?=
 =?us-ascii?Q?LoC6i+2ehn1q3p4a0L42+LH5fICZ/aKymd4s1Xxo2iXnGHoTyLNRllM2+feR?=
 =?us-ascii?Q?+FTzox65lRc7yOPFdbK6KTYhTrvTzWW35MiNPixBH95i9YgaIc7+2OQqCSL1?=
 =?us-ascii?Q?clyHXB83iDz2rLVZtT8fAur8hR3w0TDOCIVXgumtoQFhjYZAW/gphlEgmltM?=
 =?us-ascii?Q?bQovlUUkCY4Xh1hOTvSqPIrSlaOhjdZ1tZGqRFM7x5GKuD5qVo4zA+7C500R?=
 =?us-ascii?Q?D7er2HDOkp9iVqf/jkjiRuh7MhxBzHB/Lkhq3mDY2IE8IiwWx8yMlnkPx7dw?=
 =?us-ascii?Q?FNbyyor4V2JOx4Kf1fOrf+0a21DvzJkw4DV5TiNJHYDl8xM5iuqRV4runhd5?=
 =?us-ascii?Q?rCuBoJUQLKlMq6FnURfSW9vRO1droa4cH2TltUb1q5M0Gt181zBAEbCWaK3A?=
 =?us-ascii?Q?6go7VgtyN2HaYnU6ZPHSt0FYHaYJVCMAvpiZmh7ipewc8ybYGA8ONryBGDjH?=
 =?us-ascii?Q?2CvS8fdOw5kjHuSusHduEVtk+EDa/bYsFhk19BlMdEfFj3kg4Dc3KAO2XB0O?=
 =?us-ascii?Q?2Ait53dnbujAFvzsVxdTP7uo/01FeYQ+jhCmUjDz0RgOSSX7rVqcbkrIofM1?=
 =?us-ascii?Q?QHmvyWCX/I0neBqiRP1nBNPMevFl5he82KTGt+eQqE920ZZqugI5bRIZmArg?=
 =?us-ascii?Q?tikyUz29noZv9TUkPoqIcqGe6eWTgiGf/zVWCqJM2iVc6F6VoUR4rw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5825.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d8fa56a-b73c-42d6-92d1-08da077e915d
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 18:55:41.1355
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HYyWRb7nMQua36vVCrLlUbk2wNVnXvQAl5OYfB1Hmque/CXycqPpb5vV8H3aTBjE/g0bJd47XJ/5OTu6Re1NG1XlyFYNqWyW0na+Qh8XvEI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5608
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> Building iwlmei without CONFIG_CFG80211 causes a link-time warning:
>=20
> ld.lld: error: undefined symbol: ieee80211_hdrlen
> >>> referenced by net.c
> >>>
> >>> net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in
> >>> archive drivers/built-in.a
>=20
> Add an explicit dependency to avoid this. In theory it should not be need=
ed
> here, but it also seems pointless to allow IWLMEI for configurations with=
out
> CFG80211.
>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> I see this warning on 5.17-rc8, but did not test it on linux-next, which =
may
> already have a fix.
>=20
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig
> b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 85e704283755..a647a406b87b 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -139,6 +139,7 @@ config IWLMEI
>  	tristate "Intel Management Engine communication over WLAN"
>  	depends on INTEL_MEI
>  	depends on PM
> +	depends on CFG80211
>  	help
>  	  Enables the iwlmei kernel module.
>=20

FWIW: Luca just merged the exact same patch internally. So
Acked-by: Emmanuel Grumbach <Emmanuel.grumbach@intel.com>