Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp990156pxp; Wed, 16 Mar 2022 23:40:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweUTlYiF+u5y8ErOCK5vcBb20hZe/DRyChjkJMwaR8VBwJIel3dng65NdPlSQtFqERuFCT X-Received: by 2002:a63:1847:0:b0:381:8214:3a7d with SMTP id 7-20020a631847000000b0038182143a7dmr2549459pgy.134.1647499233964; Wed, 16 Mar 2022 23:40:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647499233; cv=none; d=google.com; s=arc-20160816; b=sleHzXuz6IzwcVzuxvV1Dcz6fhS92qHarxz5Fe3Mz3Y2ciPoUOK5/e/msDaw5gvzyh EW98fHKR6T75Eq4IKME1eoH3n5AkFzp7OVIXtY00MyQT7zZmiEOuy3Fj4BUXRKNX73+k nFSgviSDMY4ddfbIorse+KyhE07KXgmJg2g7zNYVmYK7N6EuqDg94imTs79s5+YWhHMK tjh86ogQchrmKrHprYsOe52cCO5USYNK2kDqNLrTdo/x9XxyTse6lTMxNiEwZxYtaOM8 P3mdsQQwdXdLKk27DIBEzuat5cRgUOTo/PWSuJujV2Cy14ytuajMQbKRh3UIeCYg953U ta5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=vHrqesPtzd8pPnA6T5S7KTvKCXIqpaPOSpwEBfzBtkM=; b=apOpt/DcYhc/81C5CppQ3DCv6O6opmeyjmTDU1ufAdJ2lb3usmjKGgKsVyYJEsteL2 xxEkdvi+ikrkROEqWUKgSeq4/+3d7GTCE3DE3hf8PttDsSm4pHDYVjhTyu8OB922H/Hf BKa+SIc8c64YyZ7INKvd0i0jjWwEUKy8X3IGUbvoKR5K6IumfGnug8YL5pzrd/FyLlsB GKx2y1MrWVSO2zRmV8fKj6L1URc4+E7oaQ6rQlFAa/IDQpUlI1qDUjZCafE6lM7X5/0O t6R7a+h/3oOD+g7CXwMc2/BLpT5RwAM0qrMFibz2malPXHYiENDHD0Px9PGY2StL9BqG jlbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m5V+cOhV; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f10-20020a170902684a00b0014f2a676e01si3714376pln.165.2022.03.16.23.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 23:40:33 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m5V+cOhV; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AA40C2D39CC; Wed, 16 Mar 2022 22:28:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344005AbiCPGOm (ORCPT + 70 others); Wed, 16 Mar 2022 02:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237256AbiCPGOk (ORCPT ); Wed, 16 Mar 2022 02:14:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BCCA29C8F for ; Tue, 15 Mar 2022 23:13:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EC17FB819DE for ; Wed, 16 Mar 2022 06:13:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C6DCC340E9; Wed, 16 Mar 2022 06:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647411201; bh=/gEn69FCXVyKJWnF/AyvAgLAHPy0NbgHxDfUNtsFnIQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=m5V+cOhV24K7n6z9Uby3kV4XgKuEC0JAkijn0tWdLK6Whpiy7P44RUhixsl41yxxi +wzoR9htC/YqjmIPy/Svons+dX5hlAMkIWjfJ52Qsk9IOO7GLC/biV6IkoLYXm09GY Bq5rtsHmX6IJXRxFRtE5xlBJs00jwRsmUkbrZhO0+CvF7dR5mLb8+h1MRYY0mXbdBo hShrCmMMQIv9DdEwbYS1VdveGqcJRtfJeb7BoHZkGE93UOCt+ek7HRINell3bY5gAP uV7rHWarck4O67wFKRAmWiGyZvAbhdsf6XB9ZXikUBSaveBKUC0aLkMmIuVaqrPyV4 KIPCQQOhuJAUQ== From: Kalle Valo To: Niels Dossche Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Carl Huang Subject: Re: [PATCH] ath11k: acquire ab->base_lock in unassign when finding the peer by addr References: <20220314215253.92658-1-dossche.niels@gmail.com> Date: Wed, 16 Mar 2022 08:13:16 +0200 In-Reply-To: <20220314215253.92658-1-dossche.niels@gmail.com> (Niels Dossche's message of "Mon, 14 Mar 2022 22:52:53 +0100") Message-ID: <87o826pgqr.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Niels Dossche writes: > ath11k_peer_find_by_addr states via lockdep that ab->base_lock must be > held when calling that function in order to protect the list. All > callers except ath11k_mac_op_unassign_vif_chanctx have that lock > acquired when calling ath11k_peer_find_by_addr. That lock is also not > transitively held by a path towards ath11k_mac_op_unassign_vif_chanctx. > The solution is to acquire the lock when calling > ath11k_peer_find_by_addr inside ath11k_mac_op_unassign_vif_chanctx. > > Fixes: 701e48a43e15 ("ath11k: add packet log support for QCA6390") > Signed-off-by: Niels Dossche On what hardware and firmware version did you test this? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches