Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Mar 2022 10:03:53 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Deren Wu <deren.wu@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
        Soul Huang <Soul.Huang@mediatek.com>,
        YN Chen <YN.Chen@mediatek.com>,
        Leon Yen <Leon.Yen@mediatek.com>,
        Eric-SY Chang <Eric-SY.Chang@mediatek.com>,
        KM Lin <km.lin@mediatek.com>,
        Robin Chiu <robin.chiu@mediatek.com>,
        CH Yeh <ch.yeh@mediatek.com>, Posh Sun <posh.sun@mediatek.com>,
        Eric Liang <Eric.Liang@mediatek.com>,
        Stella Chang <Stella.Chang@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: fix monitor rx FCS error in DFS channel
Message-ID: <YjL5ecm51SUyxxpb@lore-desk>
References: <7243650f3d51b1919bd4fd0017ff8b0186149e54.1647421054.git.deren.wu@mediatek.com>
 <YjH/GCCfQoZ5OPPM@localhost.localdomain>
 <ef6a0d876587e3efaa228f9d28f5a6f7b97e4aef.camel@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="AuwHAuPZagE1dC5E"
Content-Disposition: inline
In-Reply-To: <ef6a0d876587e3efaa228f9d28f5a6f7b97e4aef.camel@mediatek.com>
Precedence: bulk


--AuwHAuPZagE1dC5E
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Hi Lore,
>=20
> On Wed, 2022-03-16 at 16:15 +0100, Lorenzo Bianconi wrote:
> > > From: Deren Wu <deren.wu@mediatek.com>
> > >=20
> > > When setup monitor mode in DFS channel, mt76 send CH_SWITCH_DFS to
> > > fw for channel config. This would cause rx performance bad while
> > > monitoring frames. Settings CH_SWITCH_NORMAL in monitor mode would
> > > get the same performance as normal channels.
> >=20
> > Hi Deren,
> >=20
> > >=20
> > > Reviewed-by: Shayne Chen <shayne.chen@mediatek.com>
> > > Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> > > ---
> > >  drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 3 ++-
> > >  drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 3 ++-
> > >  drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 3 ++-
> > >  3 files changed, 6 insertions(+), 3 deletions(-)
> > >=20
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > > b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > > index 390add3144c2..97e2a85cb728 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > > @@ -2151,7 +2151,8 @@ int mt7615_mcu_set_chan_info(struct
> > > mt7615_phy *phy, int cmd)
> > >  		.center_chan2 =3D ieee80211_frequency_to_channel(freq2),
> > >  	};
> > > =20
> > > -	if (cmd =3D=3D MCU_EXT_CMD(SET_RX_PATH))
> > > +	if (cmd =3D=3D MCU_EXT_CMD(SET_RX_PATH) ||
> > > +	    dev->mt76.hw->conf.flags & IEEE80211_CONF_MONITOR)
> >=20
> > is this patch compliant with 802.11h DFS standard?
>=20
> Monitor mode would not tx packets and still follow standard. We will
> keep tracking this point to avoid violations.

Hi Deren,

this IEEE80211_CONF_MONITOR flags indicates there is a monitor interface,
not it is the only one so we can have multiple vifs on the device
(e.g. AP + monitor). I was wondering if CH_SWITCH_SCAN_BYPASS_DPD is used
to avoid transmitting packets during chip calibration on DFS channels.

Regards,
Lorenzo

>=20
>=20
> Regards,
> Deren
>=20
>=20
> >=20
> > Regards,
> > Lorenzo
> >=20
> > >  		req.switch_reason =3D CH_SWITCH_NORMAL;
> > >  	else if (phy->mt76->hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
> > >  		req.switch_reason =3D CH_SWITCH_SCAN_BYPASS_DPD;
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > > b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > > index 10dc4bf5adec..c56d48342aaf 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > > @@ -2833,7 +2833,8 @@ int mt7915_mcu_set_chan_info(struct
> > > mt7915_phy *phy, int cmd)
> > >  	}
> > >  #endif
> > > =20
> > > -	if (cmd =3D=3D MCU_EXT_CMD(SET_RX_PATH))
> > > +	if (cmd =3D=3D MCU_EXT_CMD(SET_RX_PATH) ||
> > > +	    dev->mt76.hw->conf.flags & IEEE80211_CONF_MONITOR)
> > >  		req.switch_reason =3D CH_SWITCH_NORMAL;
> > >  	else if (phy->mt76->hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
> > >  		req.switch_reason =3D CH_SWITCH_SCAN_BYPASS_DPD;
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > > b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > > index 5ef8b24f0ab3..da2be050ed7c 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > > @@ -863,7 +863,8 @@ int mt7921_mcu_set_chan_info(struct mt7921_phy
> > > *phy, int cmd)
> > >  	else
> > >  		req.channel_band =3D chandef->chan->band;
> > > =20
> > > -	if (cmd =3D=3D MCU_EXT_CMD(SET_RX_PATH))
> > > +	if (cmd =3D=3D MCU_EXT_CMD(SET_RX_PATH) ||
> > > +	    dev->mt76.hw->conf.flags & IEEE80211_CONF_MONITOR)
> > >  		req.switch_reason =3D CH_SWITCH_NORMAL;
> > >  	else if (dev->mt76.hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
> > >  		req.switch_reason =3D CH_SWITCH_SCAN_BYPASS_DPD;
> > > --=20
> > > 2.18.0
> > >=20
>=20

--AuwHAuPZagE1dC5E
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYjL5eQAKCRA6cBh0uS2t
rHeaAP9rpvWFTEXCqoSqp2KBbPfjlbHUhLkVwIYctyl72HZEXAD/TlpNfsswC5Of
65WCUQJGGY7nSTVIzV2Msoim8lT3RwY=
=e04/
-----END PGP SIGNATURE-----

--AuwHAuPZagE1dC5E--