Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <aaf86305-3b6e-aa8d-fa9f-b4b4ba9cb3c1@quicinc.com>
Date:   Thu, 17 Mar 2022 14:42:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v2 1/3] cfg80211: Add NL80211_IFTYPE_MLO_LINK type for MLO
 links on MLD STA
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        Veerendranath Jakkam <quic_vjakkam@quicinc.com>
CC:     <linux-wireless@vger.kernel.org>, <quic_usdutt@quicinc.com>,
        Aaron Komisar <akomisar@maxlinear.com>
References: <1645613200-30221-1-git-send-email-quic_vjakkam@quicinc.com>
 <1645613200-30221-2-git-send-email-quic_vjakkam@quicinc.com>
 <af96eba158c83a63cb9465b04373e909971d7676.camel@sipsolutions.net>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <af96eba158c83a63cb9465b04373e909971d7676.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/11/2022 4:17 AM, Johannes Berg wrote:
> On Wed, 2022-02-23 at 16:16 +0530, Veerendranath Jakkam wrote:
>>
>> Two link non-AP MLD representation:
>>
>>                   wlan0 (non-AP MLD)
>>                 IFTYPE_STATION (netdev + wdev)
>>                   /               \
>>                  /                 \
>>                link0             link1
>>        IFTYPE_MLO_LINK (wdev)  IFTYPE_MLO_LINK (wdev)
>>                |                   |
>>                |                   |
>>              radio(2G)           radio(5G)
>>
>> In contrast, NL80211_IFTYPE_MLO_LINK can't be used to represent AP MLO
>> link since an MLD AP must support pre-11be and 11be clients
>> simultaneously so each AP MLO link affiliated with AP MLD must also act
>> as independent AP for pre-11be clients so each AP MLO link must be
>> represented by NL80211_IFTYPE_AP associated with a separate netdev.
>>
>> Two link AP MLD representation:
>>
>>                   AP MLD
>>               (netdev + wdev)
>>                  /      \
>>                 /        \
>>            wlan0          wlan1
>>        IFTYPE_AP       IFTYPE_AP
>>     (netdev + wdev)  (netdev + wdev)
>>             |             |
>>             |             |
>>          radio(2G)      radio(5G)
> 
> So just for posterity's sake - we had more discussions on this out of
> band, and decided that the "netdev + wdev" on the wlan0/wlan1 will not
> actually happen - they both should be just "wdev" like in the non-AP
> MLD.
> 
> This solves the issue of broadcast (otherwise you'd need AP MLD + wlan0
> + wlan1 in a bridge and drop all multicast at wlan0 and wlan1), at the
> expense of a small amount of flexibility - you cannot consider legacy
> and MLD clients to be in different networks.
> 
> However, given the complexities around multicast, you probably cannot
> consider them to be in different networks _anyway_ because then you'd
> have to _not_ drop all the multicast on wlan0/wlan1, and then you send
> multicast twice to the MLD clients, which would be wrong too...
> 
> So the more reasonable thing to do is to treat this the same way as non-
> AP MLD with only a single netdev, and effectively behave as if there was
> an internal kind of bridge inside the AP MLD for the legacy clients.
> 
> As a consequence, of course this patch will change too.

Although this patch series is specific to non-AP MLD support I advocated 
during internal review to add this AP MLD description to initiate 
discussion about the differences between the two, and I'm glad to see 
that is happening.

Should we just omit the AP MLD representation in v2, and add that with 
the AP MLD support?

Did you have any other comments on the series other than your proposal 
to add a MLD wiphy flag, and as a result, not require driver to NULL 
check the wdev->netdev?

Thanks!
/jeff