Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     "Baochen Qiang \(QUIC\)" <quic_bqiang@quicinc.com>
Cc:     "ath11k\@lists.infradead.org" <ath11k@lists.infradead.org>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath11k: Add support for SAR
In-Reply-To: <BYAPR02MB543076C526E59CB0E98B3DBCE0169@BYAPR02MB5430.namprd02.prod.outlook.com>
        (Baochen Qiang's message of "Mon, 21 Mar 2022 02:24:47 +0000")
References: <20220317012728.18932-1-quic_bqiang@quicinc.com>
        <164761864196.8951.13534371903381562941.kvalo@kernel.org>
        <BYAPR02MB543076C526E59CB0E98B3DBCE0169@BYAPR02MB5430.namprd02.prod.outlook.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Mon, 21 Mar 2022 11:55:53 +0200
Message-ID: <87fsnbocie.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

"Baochen Qiang (QUIC)" <quic_bqiang@quicinc.com> writes:

>> -----Original Message-----
>> From: Kalle Valo <kvalo@kernel.org>
>> Sent: Friday, March 18, 2022 11:51 PM
>> To: Baochen Qiang (QUIC) <quic_bqiang@quicinc.com>
>> Cc: ath11k@lists.infradead.org; linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH] ath11k: Add support for SAR
>> 
>> Baochen Qiang <quic_bqiang@quicinc.com> wrote:
>> 
>> > ath11k assigns ath11k_mac_op_set_bios_sar_specs to ath11k_ops, and
>> > this function is called when user space application calls
>> > NL80211_CMD_SET_SAR_SPECS. ath11k also registers SAR type and
>> > frequency ranges to wiphy so user space can query SAR capabilities.
>> >
>> > This feature is currently enabled for WCN6855.
>> >
>> > Tested-on: WCN6855 hw2.0 PCI
>> > WLAN.HSP.1.1-02431-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>> >
>> > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
>> 
>> What did you use as the baseline? I could not able to find an ath- tag to which
>> this patch would apply. I strongly recommend using --base, that way I don't
>> need to waste time trying to guess what was the baseline.
>> 
>> Patch set to Changes Requested.
>> 
>
> Hi Kalle, I have added the base flag in v2.

Thanks.

> And please note this patch depends on
> https://patchwork.kernel.org/project/linux-wireless/patch/20211224085236.9064-2-quic_wgong@quicinc.com/
> which is now in public review.

If there are any dependencies, please document them clearly after the
"---" line. I don't have time to start guessing what dependencies there
might be for your patches, especially if the dependency is several
months as in this case.

But why are you using that patch as the baseline? It's marked as Changes
Requested and it's unclear then it can be merged. If you need that
patch, you should create a patchset with patch 1 being "ath11k: add
support for extended wmi service bit" and patch 2 being "ath11k: Add
support for SAR".

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches