Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
References: <20220320233010.123106-1-wlooi@ucalgary.ca> <20220320233010.123106-5-wlooi@ucalgary.ca>
 <87a6dj9uds.fsf@toke.dk>
In-Reply-To: <87a6dj9uds.fsf@toke.dk>
From:   Wenli Looi <wlooi@ucalgary.ca>
Date:   Mon, 21 Mar 2022 12:57:36 -0700
Message-ID: <CAKe_nd0huJzqsn=8bQfyZ0oPLTzCjJFCrPPhUCwTY5W8WL-H5g@mail.gmail.com>
Subject: Re: [PATCH 4/6] ath9k: fix ar9003_get_eepmisc
To:     =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        ath9k-devel@qca.qualcomm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFlIeEJGa0c4eVVGMG9EZlhEQ3NXajVseGZZSmV3VU1wS1lpVnF4WkZudGNn?=
 =?utf-8?B?UTU0LzZDcFNNL2dJbkcyMFRXOFdBNGVWZVVhNU0rS1JOVEtQMi9VY2dHMVZx?=
 =?utf-8?B?b0V6U2kyWnM1Y2ZrV3VrMnY1Tm9LbHJBN28wTW1SOS9FYW84eHlLRkgvbmMr?=
 =?utf-8?B?ejV6Nzkwd2xtTS9HYkRlRjV5K2NJQzhvRjhyM1BNOHg2V25IcE4ybUw2YjZO?=
 =?utf-8?B?YXIrSWVyZ0I0K2s0aUNaK2g0cmpjSGxKTjBGd0FxVXdZbWRadEFJNUJna0pv?=
 =?utf-8?B?QURpQjlUdTJVamtaZ0hYaXAvdGQ2SEJ5Z00yeGZ2UXV4alVkdHB5SFpLb2Ja?=
 =?utf-8?B?NXNTVVROa2txN3B2ZHgwSXJmUjN1VjF1SjZmNHZ3Y3UwU1dDWUZ6S3VDRTFJ?=
 =?utf-8?B?UU1mQXdjbldOUjVDOTlucVZFOHVkOTFFNXpyTTdxaEQxSWxsN1IzT1huZHUv?=
 =?utf-8?B?eTFDd041ajJGaEwzblFMektxeUFXVUJoSjB6Y1hOZ3dER3BORzQ2R240a2Mr?=
 =?utf-8?B?RWlsSTRNTHI2UmhLd0x3dy9ma2FCT09OYlhjbHBjLzBkQlB4NGx1cERvRi9S?=
 =?utf-8?B?TlpMcnV5bFJOZ3kwMFBnOXJ2b0lJWlBHTERvRUNVdHJRaDNHWkUwZ29kdGs3?=
 =?utf-8?B?b0lmdWF1TDRibGFGZzBvWmVRdVBSOE5Ta3JuUDA0eDZ1UUI3cHlOR2UyZlZO?=
 =?utf-8?B?bjVKK3cxT2twQnhrV2hsUGNXdCt1Q1J2Qm1FRTkxSU96dlpHemxuQkRHbSsy?=
 =?utf-8?B?bk55RzFVSVlRS01XOFFPbTd0Uk1ibkxZdnVhblVBTkdGb0xFNDR4UDhHcGNE?=
 =?utf-8?B?Zm9NVXI1U0JHQTVSUDRyTW1RekZ3aGxHSWR0bGxoN016M0NKL3F2RWM4Vlkr?=
 =?utf-8?B?ZFRFR1o4UzBrSGpoN2xSU3RDK290dEZlNmFZaFRhRjcyd3YwSGM0VDJjNzV5?=
 =?utf-8?B?QnAyZ3ppR2x5MFZtMDJUWEMycytQSzVvYjVJR3NsMXIvQTZtZ3dHZ09ZYTRx?=
 =?utf-8?B?VTY4VlFoWTF0UjVOcEl5MWV4R3l4Rkl2RStzNW4vbEVQMWpDN2RGeWZRK0Vi?=
 =?utf-8?B?aWRlNEhvd1R1WTFnK1FNZ3V5UTcwTnZJNWpETnBna01sYkNPcHIwTGh1ZVJr?=
 =?utf-8?B?RWh5bU12TytUd2NzaFVtb3FNbmxGa1hlTEJUc1NzY2N5OVJjREVtcENKOTY0?=
 =?utf-8?B?Sy9URE5GVlh6MGoxQ0pZdWVoMktjYVBMeFM1cmRXd2tpMzBVU29SVlRiM2tp?=
 =?utf-8?B?YTJ4SEZabTRlVk1od0E2ekZCenBHMmxZK3dqS1hzN0FZMXJ6V05qbUZpZEhs?=
 =?utf-8?B?cURzcEZ3VGRadHQ5U0IycE5TYVhRdjVZYjBMSVNwZ0dETmV3ZzFqM3BHR3Uw?=
 =?utf-8?B?WEFTbnkvcjR5bUdHL011UWQySUdMbDdXWUVNTFl2ZjBDdjNXelcwMUpma2No?=
 =?utf-8?B?ZzU3SUQ5MUFpZVBhaU5DalFSeWNlQ2JTQVVpK2l3bnJtY2FhMmVTa1dOQ3R6?=
 =?utf-8?B?VEtlYXBRTHFQSXJYQTZDa2l5YUZMeG9UdDQ5KzhKdVJOQWRTTmVTbEFTbyt6?=
 =?utf-8?B?VDBTbE1Xa04yK2pudnZUNmhuc3ZENzA0ZHdNZmVEWitmdHBwUWo5SldFWmxk?=
 =?utf-8?B?byt3N1JvVHVsYm4xdjdlT1B3OWx3Vmp4aVZBekdVQlc2Y2lIOFJMaTBGZE1X?=
 =?utf-8?B?NFZ6NGRjNVZnUkNSYS9UVDBvUHEySEQ5NDFWTEYvV1lJSVorN3BwUVpxSC9l?=
 =?utf-8?B?Nk9Kek5NS1pObnJSc1AvR1pXektQL0VNY1hTQkQ5MTlkUGdneTRLcWJEZXM4?=
 =?utf-8?B?c3JYbmRkeTh0dHM4dVBNWWhoVDRPTjBtSlN6TW9KWmdxbEhka3M5bzgvL2t1?=
 =?utf-8?B?RGR5VGxrZW4wL2FkY0NJK1lNV2RrazVyWWMzbzJVZlRWaGFScU5xbGROTjhI?=
 =?utf-8?Q?rjqaaKeCdN2nwFiSAb81kPSvyg4GdH/1?=
X-OriginatorOrg: ucalgary.ca
X-MS-Exchange-CrossTenant-Network-Message-Id: e5f508fb-668c-43a4-7996-08da0b7513e0
X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB3302.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 19:57:50.0778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: c609a0ec-a5e3-4631-9686-192280bd9151
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mlhDVQk0sxlj3iD4+Mti9P8/uLacTPeYlaHza3VjRnYCuOhClw+nlzEuqxevip55LplH1vNkNQnRvVJaEQU/6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB3568
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Mar 21, 2022 at 8:51 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> Wenli Looi <wlooi@ucalgary.ca> writes:
>
> > The current implementation is reading the wrong eeprom type.
> >
> > Fixes: d8ec2e ("ath9k: Add an eeprom_ops callback for retrieving the eepmisc value")
> > Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
> > ---
> >  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > index 669b49b56..a109a44a1 100644
> > --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > @@ -5615,7 +5615,7 @@ unsigned int ar9003_get_paprd_scale_factor(struct ath_hw *ah,
> >
> >  static u8 ar9003_get_eepmisc(struct ath_hw *ah)
> >  {
> > -     return ah->eeprom.map4k.baseEepHeader.eepMisc;
> > +     return ah->eeprom.ar9300_eep.baseEepHeader.opCapFlags.eepMisc;
> >  }
>
> Looks like this is only ever used to check for the
> AR5416_EEPMISC_BIG_ENDIAN flag - so is that never used by AR9300, or how
> was this ever working given that it's a completely different offset?
>
> -Toke

I think it's never used by AR9300, because get_eepmisc is only used in
ath9k_hw_nvram_swap_data, which is only used in the eeprom types other
than AR9300.