Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 22 Mar 2022 09:14:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Lorenzo Bianconi <lorenzo@kernel.org>,
        johannes@sipsolutions.net
Cc:     lkp@intel.com, kbuild-all@lists.01.org, nbd@nbd.name,
        linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
        ryder.lee@mediatek.com, evelyn.tsai@mediatek.com,
        chui-hao.chiu@mediatek.com, j@w1.fi
Subject: [kbuild] Re: [PATCH wireless-next] mac80211: introduce BSS color
 collision detection
Message-ID: <202203220555.BHvsEAhe-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6226a016389e034fd9c208b3a7a75edd01aba6f4.1647858505.git.lorenzo@kernel.org>
Message-ID-Hash: LN2PATJJB2GVA3QDIDNUFK4AIC4UQCWP
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h+FHDIpyEa9SxBaCBktla/41ZAybm1KH6RIH2Rus+aAedA3RDniv4Mpi8lJW?=
 =?us-ascii?Q?Ny3aTa9beiSTDlP7wr6zXl7MguTv/L27nXNzPhrIYEWqwACBjtXbZzOTjWlF?=
 =?us-ascii?Q?z0QpTbGbsC/xfpKUUtIQit8LZbabMpCo3xaLr1NwQSvbn6QCgVDjABJFeYhz?=
 =?us-ascii?Q?HvR+g9gDeg3PELx+FHCR3i8w+HeiI4hZKenMLO0RHL9gbuKlD3MdY53IOJxz?=
 =?us-ascii?Q?+vqE48sare+J3aWrRKd1rftXEjtooVBl+x73iXq85L5UvYv2LuExPUKkS5DD?=
 =?us-ascii?Q?sVfo8P6728VN9InFPDxdjU4svs6KYn6Ya3Pwh/lmDca0ug8m5Oevo/vsdbpe?=
 =?us-ascii?Q?SmSZw7WF3j0AY09rQKiKqb8Cb0KinRIKz2BvfluBml4Hu8M2e0rUPz2b8mMp?=
 =?us-ascii?Q?bK3oMLIdfjJTgVUJj0EnwOKsHSeb/FiVoi3LHsivuUSWCxTBZWmWtdi9fkRo?=
 =?us-ascii?Q?djS5f3i27NM9Qi0LOy5t/aDyfEFCqQZ6BW/hCIYDId0dPhASUVIReyGgIlY6?=
 =?us-ascii?Q?8v0y2NT3OYQ0SC1kHJIETN0s+n2P1HCnFvox1++xyXghnZpA53+XkWUp+nj+?=
 =?us-ascii?Q?BqZwtuiEphnKQqp6zFvIFoG5gKwrLIwEZz8blKErjVdPWGgYKM3FwEttOqtv?=
 =?us-ascii?Q?xvhIUzE+sI9oPPjZlhX0IRjkf4CSM0w+3DqBTgJyukBH8NgWpmBOQ0lVqBii?=
 =?us-ascii?Q?vhMmRvCskzV0oq6OE8FrTBY2lMv7ngsvY9nOBR7flDDCHhh2zd5/ke9+9QYW?=
 =?us-ascii?Q?eUXH0KtOn2Y/de0Ce4r3SYRQIuj4ouwC+0sfIHFVkT08HGM0WLxttLV6JBUD?=
 =?us-ascii?Q?rJHhmWs29OshA07v6Z22KiwigTGRMmGZKjT6ThTtNQqFZ7Sv3ALNVVX4JdLh?=
 =?us-ascii?Q?AtA/oL+5vCZsCscZZIhciuhb0VNjW28dPRYLscVPkD/quWOn9yn/zdG13AZp?=
 =?us-ascii?Q?WTUiofXD4I4uMWuXqY9XR6/iwetuGuULIQxgT/Tbkfre+PWXy3ArsvaA2AKD?=
 =?us-ascii?Q?hU4/vCbgy2xJ0jeBH+ZYgShmPjhLcUP05R+gnGaJxX1U1dCL0033neBmxfwQ?=
 =?us-ascii?Q?HskE0D7SvFaUQ7OQyPVq2R5AxKfYKelsBdTEcFeeXJRIcoeAm7OF9/3b46cN?=
 =?us-ascii?Q?ByZy/J6FfMCw/PIDfNbsAByo2EXojMJqFYpVR36DZIpdiJPsImIdS4Pif0vm?=
 =?us-ascii?Q?oyc0UwPvoDSg+ZGosgrDl27SLf47SJvufWxyZuULj4vzKK+0RB8tyieF2f8Y?=
 =?us-ascii?Q?47k4TQ4FzC8ue0nIFcfdjIWaiap2xVtLeBObv8iDvD2ahIGEfKLN9wIWQqVu?=
 =?us-ascii?Q?z+kHhZ23lluvI4qXEXYpvC6VyHM6Nn6S0WV3WO+66xf3L7NrmeNsWjQeQanV?=
 =?us-ascii?Q?6tHr2GHBxYP599OBXuwiwfU3tfTlbQznhTxdXvIYZTtpjw476OTtnRJa3QtZ?=
 =?us-ascii?Q?yJrUOgwZj2n5aNFbTove3G4glfU+uKBCzwyHvFm3ap2sU25Fu4IzGA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3abbec6a-fdfc-43f5-9aaf-08da0bcb3ca2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 06:14:35.9432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0OI8TzkNKe/5zUualmd+9+kIZqsWE3IQToZ3aGJjcSyOoqNzXYHk/9C4vsTnIgMwIgC4kLpTpiNp0QPsMAsOuijkJbri3fbsygUq5Kxqa/0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3156
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10293 signatures=694221
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203220037
X-Proofpoint-GUID: TELOnoIe1dzhXZF7q1fCwAhVJVWqkqUg
X-Proofpoint-ORIG-GUID: TELOnoIe1dzhXZF7q1fCwAhVJVWqkqUg
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Lorenzo,

url:    https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mac80211-introduce-BSS-color-collision-detection/20220321-183456 
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git  main
config: nios2-randconfig-m031-20220321 (https://download.01.org/0day-ci/archive/20220322/202203220555.BHvsEAhe-lkp@intel.com/config )
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
net/mac80211/rx.c:3218 ieee80211_rx_check_bss_color_collision() warn: should '(((1))) << color' be a 64 bit type?

vim +3218 net/mac80211/rx.c

964596b43c17b4 Lorenzo Bianconi 2022-03-21  3181  static void
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3182  ieee80211_rx_check_bss_color_collision(struct ieee80211_rx_data *rx)
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3183  {
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3184  	struct ieee80211_mgmt *mgmt = (void *)rx->skb->data;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3185  	const struct element *ie;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3186  	size_t baselen;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3187  
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3188  	if (!wiphy_ext_feature_isset(rx->local->hw.wiphy,
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3189  				     NL80211_EXT_FEATURE_BSS_COLOR))
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3190  		return;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3191  
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3192  	if (wiphy_ext_feature_isset(rx->local->hw.wiphy,
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3193  				    NL80211_EXT_FEATURE_HW_COLOR_COLLISION))
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3194  		return;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3195  
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3196  	baselen = mgmt->u.beacon.variable - rx->skb->data;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3197  	if (baselen > rx->skb->len)
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3198  		return;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3199  
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3200  	ie = cfg80211_find_ext_elem(WLAN_EID_EXT_HE_OPERATION,
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3201  				    mgmt->u.beacon.variable,
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3202  				    rx->skb->len - baselen);
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3203  	if (ie && ie->datalen >= sizeof(struct ieee80211_he_operation) &&
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3204  	    ie->datalen >= ieee80211_he_oper_size(ie->data + 1)) {
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3205  		struct ieee80211_bss_conf *bss_conf = &rx->sdata->vif.bss_conf;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3206  		const struct ieee80211_he_operation *he_oper;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3207  		u8 color;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3208  
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3209  		he_oper = (void *)(ie->data + 1);
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3210  		if (le32_get_bits(he_oper->he_oper_params,
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3211  				  IEEE80211_HE_OPERATION_BSS_COLOR_DISABLED))
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3212  			return;
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3213  
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3214  		color = le32_get_bits(he_oper->he_oper_params,
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3215  				      IEEE80211_HE_OPERATION_BSS_COLOR_MASK);

IEEE80211_HE_OPERATION_BSS_COLOR_MASK gives us 63

964596b43c17b4 Lorenzo Bianconi 2022-03-21  3216  		if (color == bss_conf->he_bss_color.color)
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3217  			ieeee80211_obss_color_collision_notify(&rx->sdata->vif,
964596b43c17b4 Lorenzo Bianconi 2022-03-21 @3218  							       BIT(color));

So this should be BIT_ULL()

964596b43c17b4 Lorenzo Bianconi 2022-03-21  3219  	}
964596b43c17b4 Lorenzo Bianconi 2022-03-21  3220  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp 
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org