Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 10:43:29 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     kbuild@lists.01.org, Lorenzo Bianconi <lorenzo@kernel.org>,
        johannes@sipsolutions.net, lkp@intel.com, kbuild-all@lists.01.org,
        nbd@nbd.name, linux-wireless@vger.kernel.org,
        ryder.lee@mediatek.com, evelyn.tsai@mediatek.com,
        chui-hao.chiu@mediatek.com, j@w1.fi
Subject: Re: [kbuild] Re: [PATCH wireless-next] mac80211: introduce BSS color
 collision detection
Message-ID: <YjmaQeDWT2G7wHzU@lore-desk>
References: <6226a016389e034fd9c208b3a7a75edd01aba6f4.1647858505.git.lorenzo@kernel.org>
 <202203220555.BHvsEAhe-lkp@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6c6FqmyFF63MIXN5"
Content-Disposition: inline
In-Reply-To: <202203220555.BHvsEAhe-lkp@intel.com>
Precedence: bulk


--6c6FqmyFF63MIXN5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Hi Lorenzo,
>=20
> url:    https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mac8021=
1-introduce-BSS-color-collision-detection/20220321-183456=20
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless=
-next.git  main
> config: nios2-randconfig-m031-20220321 (https://download.01.org/0day-ci/a=
rchive/20220322/202203220555.BHvsEAhe-lkp@intel.com/config )
> compiler: nios2-linux-gcc (GCC) 11.2.0
>=20
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>=20
> New smatch warnings:
> net/mac80211/rx.c:3218 ieee80211_rx_check_bss_color_collision() warn: sho=
uld '(((1))) << color' be a 64 bit type?
>=20
> vim +3218 net/mac80211/rx.c
>=20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3181  static void
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3182  ieee80211_rx_check_bss_=
color_collision(struct ieee80211_rx_data *rx)
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3183  {
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3184  	struct ieee80211_mgmt =
*mgmt =3D (void *)rx->skb->data;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3185  	const struct element *=
ie;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3186  	size_t baselen;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3187 =20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3188  	if (!wiphy_ext_feature=
_isset(rx->local->hw.wiphy,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3189  				     NL80211_EXT_FE=
ATURE_BSS_COLOR))
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3190  		return;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3191 =20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3192  	if (wiphy_ext_feature_=
isset(rx->local->hw.wiphy,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3193  				    NL80211_EXT_FEA=
TURE_HW_COLOR_COLLISION))
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3194  		return;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3195 =20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3196  	baselen =3D mgmt->u.be=
acon.variable - rx->skb->data;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3197  	if (baselen > rx->skb-=
>len)
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3198  		return;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3199 =20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3200  	ie =3D cfg80211_find_e=
xt_elem(WLAN_EID_EXT_HE_OPERATION,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3201  				    mgmt->u.beacon.=
variable,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3202  				    rx->skb->len - =
baselen);
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3203  	if (ie && ie->datalen =
>=3D sizeof(struct ieee80211_he_operation) &&
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3204  	    ie->datalen >=3D i=
eee80211_he_oper_size(ie->data + 1)) {
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3205  		struct ieee80211_bss_=
conf *bss_conf =3D &rx->sdata->vif.bss_conf;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3206  		const struct ieee8021=
1_he_operation *he_oper;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3207  		u8 color;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3208 =20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3209  		he_oper =3D (void *)(=
ie->data + 1);
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3210  		if (le32_get_bits(he_=
oper->he_oper_params,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3211  				  IEEE80211_HE_OPER=
ATION_BSS_COLOR_DISABLED))
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3212  			return;
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3213 =20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3214  		color =3D le32_get_bi=
ts(he_oper->he_oper_params,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3215  				      IEEE80211_HE_=
OPERATION_BSS_COLOR_MASK);
>=20
> IEEE80211_HE_OPERATION_BSS_COLOR_MASK gives us 63
>=20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3216  		if (color =3D=3D bss_=
conf->he_bss_color.color)
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3217  			ieeee80211_obss_colo=
r_collision_notify(&rx->sdata->vif,
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21 @3218  							       BIT(color=
));
>=20
> So this should be BIT_ULL()

ack, I will fix it in v2.

Regards,
Lorenzo

>=20
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3219  	}
> 964596b43c17b4 Lorenzo Bianconi 2022-03-21  3220  }
>=20
> --=20
> 0-DAY CI Kernel Test Service
> https://01.org/lkp=20
> _______________________________________________
> kbuild mailing list -- kbuild@lists.01.org
> To unsubscribe send an email to kbuild-leave@lists.01.org
>=20

--6c6FqmyFF63MIXN5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYjmaQQAKCRA6cBh0uS2t
rCFUAP430vetz1K7lv7+1f4YaRmuJIV42yFse17ZI6tNZjNkUwEAzkHfUrQ7jDYc
/gz1nivQw3U+gsv0XT9IXAaox3P8cAE=
=6ByS
-----END PGP SIGNATURE-----

--6c6FqmyFF63MIXN5--