Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3665942pxp; Wed, 23 Mar 2022 03:25:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeMDSW7yHEP8+DQ37XVqgmmcZleS5jD4HFsnphgK/Yq8yljsbQMRBPYcz5z6Pc7/zFmenw X-Received: by 2002:a63:f616:0:b0:386:66d:defe with SMTP id m22-20020a63f616000000b00386066ddefemr2903009pgh.117.1648031158718; Wed, 23 Mar 2022 03:25:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648031158; cv=none; d=google.com; s=arc-20160816; b=lefPKRs0xVdfwh5bBWJModjX7JfSl/q3S2O4R6hLQ0d5ZclEGLeRI3i+WUfgWbJAr8 Zi3RqLZxbdesA44DprEWcl9I5SDJquASVh21AOz6Pd84Q1qzlr0neXOqYW69dSNxtbmc /fn4yJz0RgB0Z+UjJ5QdIS1fvbfJhc5lN82KKyE+tZpzv0cDW+xry2nqqXmFv+Ija54K RTirk4CfC8xLw36KktctnliPsXdoZOTV8aHEEFL/tzbGAeiu25RC3Vvx7rMX7gB+O9ed PJw81gsn+e8KoxtBKZbAg3cjZkYyVETBDi02smTVY3qR13Nc2+YcUvH6C71YeMtTpDeZ x74A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=kefti953ZwDrcklufVHMyyZyUcem+f2vKjIInqqdoxI=; b=uwTDMXO4cn8/qmM8/TFKUg2kUvT9Zx64IXm07sZSMDWsKmAE+4NcQF7xIRZeqlPR9d PcnHQ71i++Mad8d5lW+5rtHqdhOXg2DEZFEBmDKOQBkX9K04Aq5118szLWn4hfu4XBZJ dwWZn+xRsRCmvFncf332Dkg1LK9ie7rpgv5mCCOBbEL3eccxOPSotzhcddKKU6PNcAfQ gv+A01CJPpWH915lfbjwBJg1QjLpUZV1Mn+sMg83oN0WzhikxkvlnUp8Acz713sP2EJn H8lrEnD9s9EhNhob5qU55Fu28tKkIW1z76Ngl6SugwRtCJ2FaHrQgHGuZ9pDK0wszBqN fVtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IBCyqHOL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l3-20020a170902eb0300b00153b2d165edsi15649329plb.501.2022.03.23.03.25.33; Wed, 23 Mar 2022 03:25:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IBCyqHOL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242222AbiCWHdL (ORCPT + 70 others); Wed, 23 Mar 2022 03:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232562AbiCWHdL (ORCPT ); Wed, 23 Mar 2022 03:33:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DCF072E36; Wed, 23 Mar 2022 00:31:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 103FAB81DC9; Wed, 23 Mar 2022 07:31:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CD96C340E8; Wed, 23 Mar 2022 07:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648020699; bh=xmpfDtMMsZeVIRw9r9g+fWtSN/SN5MNsLW7UTEV9McM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IBCyqHOLXNrlbiOTOo8IH2EftaGeTKVcQ/ZTBEM2LBP+7wIATYSO+t32nlNxUsEUT WqPOxuJHQb6BtHqGEaBBf3rgFHB4V4PnK87T2PYd5BmB/9SkTLf1Jijx4kYXMLUkvg wa33664W3GEZGeZaIev6rwm/GxoTK2/++PTXCEmzqticobTTM5HRg8ZZiwPPrpXMqH ayRApnKFzE2ZbEahrHuk+9llMSlntJxRE5Ij+3T1VaolGU2MQs4qbjGlzEdexe/zFf TGpaPDDvAOczg67f/uvTxfUfJPmeXicB6E9uR5wXoUSqxCjLZdihV7Bjdo/UrCDP41 BfrJOXhwdgxVw== From: Kalle Valo To: Brian Norris Cc: Francesco Dolcini , Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , linux-wireless@vger.kernel.org, Andrejs Cainikovs , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Jonas =?utf-8?Q?Dre=C3=9Fler?= Subject: Re: [RFC PATCH] mwifiex: Select firmware based on strapping References: <20220321161003.39214-1-francesco.dolcini@toradex.com> Date: Wed, 23 Mar 2022 09:31:32 +0200 In-Reply-To: (Brian Norris's message of "Mon, 21 Mar 2022 13:31:07 -0700") Message-ID: <87zglhktuz.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris writes: >> --- a/drivers/net/wireless/marvell/mwifiex/sdio.h >> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.h >> @@ -39,6 +39,7 @@ >> #define SD8977_DEFAULT_FW_NAME "mrvl/sdsd8977_combo_v2.bin" >> #define SD8987_DEFAULT_FW_NAME "mrvl/sd8987_uapsta.bin" >> #define SD8997_DEFAULT_FW_NAME "mrvl/sdsd8997_combo_v4.bin" >> +#define SD8997_SDIOUART_FW_NAME "nxp/sdiouart8997_combo_v4.bin" > > This isn't your main issue, but just because companies buy and sell IP > doesn't mean we'll change the firmware paths. Qualcomm drivers still use > "ath" prefixes, for one ;) > > Personally, I'd still keep the mrvl/ path. But that might be up to Kalle > and/or linux-firmware.git maintainers. I also prefer to have all the firmware files in the mrvl directory. Actually I would prefer that each driver has it's own firmware directory, but that's another topic. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches