Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Wenli Looi <wlooi@ucalgary.ca>
Cc:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH 4/6] ath9k: fix ar9003_get_eepmisc
References: <20220320233010.123106-1-wlooi@ucalgary.ca>
        <20220320233010.123106-5-wlooi@ucalgary.ca>
Date:   Wed, 23 Mar 2022 11:30:35 +0200
In-Reply-To: <20220320233010.123106-5-wlooi@ucalgary.ca> (Wenli Looi's message
        of "Sun, 20 Mar 2022 17:30:08 -0600")
Message-ID: <8735j9vww4.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Wenli Looi <wlooi@ucalgary.ca> writes:

> The current implementation is reading the wrong eeprom type.
>
> Fixes: d8ec2e ("ath9k: Add an eeprom_ops callback for retrieving the eepmisc value")
> Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>

The Fixes tag is wrong, I fixed it in the pending branch.

In commit

  265e303cc469 ("ath9k: fix ar9003_get_eepmisc")

Fixes tag

  Fixes: d8ec2e ("ath9k: Add an eeprom_ops callback for retrieving the eepmisc value")

has these problem(s):

  - SHA1 should be at least 12 digits long
      Can be fixed by setting core.abbrev to 12 (or more) or (for git
      v2.11 or later) just making sure it is not set (or set to "auto").
          

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches