Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Wen Gong <quic_wgong@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] ath11k: add read variant from SMBIOS for download board data
References: <20220315104721.26649-1-quic_wgong@quicinc.com>
        <20220315104721.26649-3-quic_wgong@quicinc.com>
        <87r16tkqbx.fsf@kernel.org>
        <1c4230e0-f01e-0db1-af95-65aa2d3ac508@quicinc.com>
Date:   Wed, 23 Mar 2022 15:05:42 +0200
In-Reply-To: <1c4230e0-f01e-0db1-af95-65aa2d3ac508@quicinc.com> (Wen Gong's
        message of "Wed, 23 Mar 2022 16:52:43 +0800")
Message-ID: <87h77okee1.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Wen Gong <quic_wgong@quicinc.com> writes:

> On 3/23/2022 4:47 PM, Kalle Valo wrote:
>> Wen Gong <quic_wgong@quicinc.com> writes:
>>
>>> This is to read variant from SMBIOS such as read from DT, the variant
>>> string will be used to one part of string which used to search board
>>> data from board-2.bin.
>>>
>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>>>
>>> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
>> [...]
>>
>>> +struct ath11k_smbios_bdf {
>>> +	struct dmi_header hdr;
>>> +	u32 padding;
>>> +	u8 bdf_enabled;
>>> +	u8 bdf_ext[1];
>>> +};
>> I was about to commit this but noticed bdf_ext[1], is there a reason for
>> that? Use of [1] in arrays is deprecated nowadays:
>
> Kalle,
>
> no reason for it, please change bdf_ext[1] to bdf_ext[0] or bdf_ext[].
> It will also work well.

[0] is deprecated as well so I changed it to [].

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches