Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2691629pxb; Sat, 26 Mar 2022 01:57:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzobONdMsbdzn3IjKVIokAL9Bm4E9pBosDsk9qqInUJ2W3Gp72fSi6+enZIYLw8Oz+uCGZK X-Received: by 2002:a17:906:af6b:b0:6df:83a9:67db with SMTP id os11-20020a170906af6b00b006df83a967dbmr16506869ejb.222.1648285074978; Sat, 26 Mar 2022 01:57:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648285074; cv=none; d=google.com; s=arc-20160816; b=KeULfLR52HFVWo/FSaBKUaIpHM0eMLTDv/uEEGYOi0ioz9+tO0S6HUlrniwbk//taj Q+1BjaDXBPiF2TzSfgUdRCzB0CSAb9qjsSy72yYIBt+CQmPaUUhELoaCFLFjlmSnPcWO L7j2J4au/+JqeRUDSl6rOHk8o3qc9uQajwWs0w54hB5Jnqozlxz5CB+MxTelHNZYrvDH oknUlyGuMHqPnngzMCiGAgyvDenVOaOO7ycs2XcVADT0dsfMNiidTmIEz/Aw4Co1XKbF ttJdCLJK1zZib+U7K+TqYXDEDTkP6ka5mAcL9MKhgQimwrce7BU1xWox/KfheJ+0IbGX ScWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=M7PZHa+qyQRnUy4nBBVj8v5f2FFMONTYj9J/lWladVc=; b=V3jJ4QT5GpplhduVjI/bK4S+OKoIcVutpOJ2AG+x+VGKVZ86tvEb0nNfCmJyxYv0al 0vua1LLmx5JVmzwrhIZypQnPRzY8aBLYtTZytCpgccsY5nPHQzGiuePds0GS+H4ydQwW MpSmtRujw2TslipTPYONPKZQC9cu52wtnm1nXA+V9EldQTRuPfv71Uh24ugvQGmPONEk fcoyASXLtx0Y6jG1NlhLGIkJDiyxJvUqFIQDBkcg2XBkTk9oi6CsX1Werx6An0BoQhVR nDjocM3velz32OPEaBowDSmeGconzf900Va4sIRrf/+vgM0o60Ah3BX5zkoeL0JEgM5p eWqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CLpm8T5g; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s7-20020a170906168700b006df76385c8esi5492632ejd.302.2022.03.26.01.57.25; Sat, 26 Mar 2022 01:57:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CLpm8T5g; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231671AbiCZIuK (ORCPT + 70 others); Sat, 26 Mar 2022 04:50:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiCZIuJ (ORCPT ); Sat, 26 Mar 2022 04:50:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A24A652C8 for ; Sat, 26 Mar 2022 01:48:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 21D1AB800C1 for ; Sat, 26 Mar 2022 08:48:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEF1CC2BBE4; Sat, 26 Mar 2022 08:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648284508; bh=CWs64S7u0xalXvKpz9zCgW770mWGSrIjJcogyJjbcLg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CLpm8T5gs5sWV1cTCVsyg7NwM+WUCv1k2ipHkDwfw06Ih6W7bCGNOUQaOO4/qk9GG EljLeUN9AsUEDu1nR/mThtH9muvX8cRGO7igJbHt1dAr+X/hE9ENhcbcBCAfFO+o1W xyea1DqyKEAh2ZnrLVDtIHxWluOqNLRUTFIKh5+IURC3s2gMmMErK5UgbDO0Q99bQM rBuWtkg8nn76Dd2WXbgbW6llegrgBPGLIJbRuQhSROKapeFDtS0Pxmu6xxmrjojC6d c25ys0smg+imOgRFLiTa8WucKB3NnYRdZcex3xMX0ZBvWJKpP1i0nRgN04leZBo9cU oGAIFrtIjq3Sw== From: Kalle Valo To: Jeff Johnson Cc: Maharaja Kennadyrajan , , Subject: Re: [PATCH v6 1/3] nl80211: Add support for beacon tx mode References: <20220325055949.3035053-1-quic_mkenna@quicinc.com> <20220325055949.3035053-2-quic_mkenna@quicinc.com> Date: Sat, 26 Mar 2022 10:48:23 +0200 In-Reply-To: (Jeff Johnson's message of "Fri, 25 Mar 2022 12:18:41 -0700") Message-ID: <87lewxnlpk.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jeff Johnson writes: > On 3/24/2022 10:59 PM, Maharaja Kennadyrajan wrote: > [...snip...] > >> +/** >> + * enum nl80211_beacon_tx_mode - Beacon Tx Mode enum. >> + * @NL80211_BEACON_STAGGERED_MODE: Used to configure beacon tx mode as >> + * staggered mode. This is the default beacon tx mode. > > Documentation doesn't match the code. There is now a default mode, and > that is, well, the default mode But what does the default mode mean in this case? :) Please document in detail what the driver is supposed to do in this mode. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches