Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp4753320pxb; Mon, 28 Mar 2022 02:51:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/2OjcFF3sKtanRtPw2KODqQbKB5ZBrbs2uT2+3WxST+4NInNcPA3w4esZ5JdKSfpbZn2U X-Received: by 2002:a17:907:3e82:b0:6da:6f15:ff38 with SMTP id hs2-20020a1709073e8200b006da6f15ff38mr26319502ejc.324.1648461100673; Mon, 28 Mar 2022 02:51:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648461100; cv=none; d=google.com; s=arc-20160816; b=n3QnN9jmJYBatlz8GDCs0TTzM/RinfKdHAFZI+B5tzna9lS2fjib77WTzRJSi8B4TT lPwoRmxWJPHRy6cYDmihPnN9YD8Yf8q+j338C3X5YzMbGzlmbeRp/tmvIt6MqgXe75xO 6RLTpX8aJxzws5kuVXzn3Vh/LmVTvscT0z98onDlfzn+v//NBMXpPJMwdlVQHOAmxMte VJLK/la5xCCpgbPh35H5ObHaQnHf+FMGWCGnHuRpR+eCuPZ2ZOEx5LeXKueQs86hCAnN GTuDD4/BvNfNXz/yAECiH5XJ3W276+TRXdhmmgap/cn+5PAEJfXhnZd9Ayga2cKVVZZR S0sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=LQyxRKXMf0S7uzGj5hH8/MvLm79Jjubtz0m602VOG1Y=; b=NMN+eoyUzwKKIADAXHWHGrMpGUCgFJGQi1vbePd/dSycTeTAVYQjO/DGdQCaqg5qmT DljaFY7/YSiK7lyJZoBRepdfkZCZw2lccUv+GPGMxmqw+C9xbhM7L48Ocvwyh8VPpUu2 Earxy4I6Um3k0yJadRSp3NHLTO/k1uQDizSzCTkmAAm+ZWYPl+SkFPAMTPSFaci6b9Mi fArFE9cNsSiwm2V8kVcUvWaQfvbACHCWMrEushMOunZJiZJnHVz4JZDZO9aNQRxvG9ob 9ieSNC4CAnoINkqi1kBvV7oOaLv+lQaWZWJ7X8dUFPPpSZt4zJmvaSbMmk5PRuasw0xi vlyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r5X52gFg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a17090607d000b006df76385e05si12339597ejc.677.2022.03.28.02.51.21; Mon, 28 Mar 2022 02:51:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r5X52gFg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238179AbiC1FuQ (ORCPT + 68 others); Mon, 28 Mar 2022 01:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235040AbiC1FuK (ORCPT ); Mon, 28 Mar 2022 01:50:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B582412A94; Sun, 27 Mar 2022 22:48:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 314846109A; Mon, 28 Mar 2022 05:48:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99C6AC340F0; Mon, 28 Mar 2022 05:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648446508; bh=LQyxRKXMf0S7uzGj5hH8/MvLm79Jjubtz0m602VOG1Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=r5X52gFgn7hx5pBW0q/WF5RxNd/bFfG97hhie/kXFd6DHGiu014p/NEc7mw71W4xZ JJpY+PSzyAACVYpBT6O0ZzdFiKjp6QJrXwz+v0jZ7x8AJTX6/l/NDBnYq1sqlVgnP4 TC9jttkCIwV4kZjwHq751BRBgg7/+OxOYMBKlQ/1/VEqBv9F3R4vDNzdzejBiC9izJ MwyCxqyS/J6At+JIUj9cKkOJws2Airt7fxk70wDV4zRR3FrKmDl6N3EgrhD7z/mJZs ndT9+LTH0vJ2Dvn9wSN5uSjcwCDucJNGGZLWHffCIeuhJtuxVUhgOof8UH0DuiljxA Bgz69gFqxOmfw== From: Kalle Valo To: "Gustavo A. R. Silva" Cc: Kees Cook , Luca Coelho , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] iwlwifi: mei: Replace zero-length array with flexible-array member References: <20220216195030.GA904170@embeddedor> <202202161235.F3A134A9@keescook> <20220326004137.GB2602091@embeddedor> Date: Mon, 28 Mar 2022 08:48:24 +0300 In-Reply-To: <20220326004137.GB2602091@embeddedor> (Gustavo A. R. Silva's message of "Fri, 25 Mar 2022 19:41:37 -0500") Message-ID: <87wngezkyf.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org "Gustavo A. R. Silva" writes: > On Wed, Feb 16, 2022 at 12:35:22PM -0800, Kees Cook wrote: >> On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote: >> > There is a regular need in the kernel to provide a way to declare >> > having a dynamically sized set of trailing elements in a structure. >> > Kernel code should always use =E2=80=9Cflexible array members=E2=80=9D= [1] for these >> > cases. The older style of one-element or zero-length arrays should >> > no longer be used[2]. >> >=20 >> > [1] https://en.wikipedia.org/wiki/Flexible_array_member >> > [2] >> > https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-len= gth-and-one-element-arrays >> >=20 >> > Link: https://github.com/KSPP/linux/issues/78 >> > Signed-off-by: Gustavo A. R. Silva >>=20 >> Reviewed-by: Kees Cook > > Hi all, > > Friendly ping: can someone take this, please? > > ...I can take this in my -next tree in the meantime. I'll take this. Luca, ack? --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes