Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220325074141.17446-1-tangmeng@uniontech.com>
In-Reply-To: <20220325074141.17446-1-tangmeng@uniontech.com>
From:   Stanislav Yakovlev <stas.yakovlev@gmail.com>
Date:   Tue, 29 Mar 2022 16:41:51 -0400
Message-ID: <CA++WF2NXLL4WjwyUYcBTJ9ogNAZnqZkU8KHqkvUbvE3k=RYroA@mail.gmail.com>
Subject: Re: [PATCH] ipw2200: Fix permissions setted by DEVICE_ATTR
To:     Meng Tang <tangmeng@uniontech.com>
Cc:     kvalo@kernel.org, Jakub Kicinski <kuba@kernel.org>,
        pabeni@redhat.com, wireless <linux-wireless@vger.kernel.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 25 Mar 2022 at 03:42, Meng Tang <tangmeng@uniontech.com> wrote:
>
> Because xcode_version and rtc only implement the show function
> and do not provide the store function, so ucode_version and rtc
> only need the read permission, not need the write permission more.
>
> So, remove the write permission from xcode_version and rtc.
>
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Looks fine, thanks!

Stanislav.