Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5.18] ath9k: Properly clear TX status area before reporting to mac80211
References: <20220330164409.16645-1-toke@toke.dk>
        <8ad2754c-c5bb-7b07-6b3f-5701d0434eee@gmail.com>
Date:   Thu, 31 Mar 2022 08:36:53 +0300
In-Reply-To: <8ad2754c-c5bb-7b07-6b3f-5701d0434eee@gmail.com> (Bagas Sanjaya's
        message of "Thu, 31 Mar 2022 12:06:45 +0700")
Message-ID: <87fsmyvg22.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 30/03/22 23.44, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> The ath9k driver was not properly clearing the status area in the
>> ieee80211_tx_info struct before reporting TX status to mac80211. Instead,
>> it was manually filling in fields, which meant that fields introduced la=
ter
>> were left as-is.
>>
>> Conveniently, mac80211 actually provides a helper to zero out the status
>> area, so use that to make sure we zero everything.
>>
>> The last commit touching the driver function writing the status informat=
ion
>> seems to have actually been fixing an issue that was also caused by the
>> area being uninitialised; but it only added clearing of a single field
>> instead of the whole struct. That is now redundant, though, so revert th=
at
>> commit and use it as a convenient Fixes tag.
>>
>> Fixes: cc591d77aba1 ("ath9k: Make sure to zero status.tx_time before rep=
orting TX status")
>> Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
>
> No regressions and UBSAN warning [1] reported on dmesg.
>
> Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
> However, there is something missing. I don't see Cc: stable@vger.kernel.o=
rg
> trailer in this patch. I think it should, because I reported that this is=
sue
> first occurred on v5.17, then still appeared on v5.17.1.

I can add that during commit.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes