Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Cc:     Bagas Sanjaya <bagasdotme@gmail.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5.18] ath9k: Properly clear TX status area before reporting to mac80211
References: <20220330164409.16645-1-toke@toke.dk>
        <8ad2754c-c5bb-7b07-6b3f-5701d0434eee@gmail.com>
        <87fsmyvg22.fsf@tynnyri.adurom.net> <87pmm2h64a.fsf@toke.dk>
Date:   Thu, 31 Mar 2022 12:31:58 +0300
In-Reply-To: <87pmm2h64a.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\=
 \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of
        "Thu, 31 Mar 2022 10:35:17 +0200")
Message-ID: <87bkxmv569.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> Kalle Valo <kvalo@kernel.org> writes:
>
>> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>>
>>> On 30/03/22 23.44, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>>>> The ath9k driver was not properly clearing the status area in the
>>>> ieee80211_tx_info struct before reporting TX status to mac80211. Inste=
ad,
>>>> it was manually filling in fields, which meant that fields introduced =
later
>>>> were left as-is.
>>>>
>>>> Conveniently, mac80211 actually provides a helper to zero out the stat=
us
>>>> area, so use that to make sure we zero everything.
>>>>
>>>> The last commit touching the driver function writing the status inform=
ation
>>>> seems to have actually been fixing an issue that was also caused by the
>>>> area being uninitialised; but it only added clearing of a single field
>>>> instead of the whole struct. That is now redundant, though, so revert =
that
>>>> commit and use it as a convenient Fixes tag.
>>>>
>>>> Fixes: cc591d77aba1 ("ath9k: Make sure to zero status.tx_time before r=
eporting TX status")
>>>> Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
>>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>
>>>
>>> No regressions and UBSAN warning [1] reported on dmesg.
>>>
>>> Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
>>>
>>> However, there is something missing. I don't see Cc: stable@vger.kernel=
.org
>>> trailer in this patch. I think it should, because I reported that this =
issue
>>> first occurred on v5.17, then still appeared on v5.17.1.
>>
>> I can add that during commit.
>
> Thanks! And sorry about that, I have gotten so used to the netdev policy
> of not including an explicit stable Cc that I totally forgot that this
> doesn't apply to the wireless tree.

No worries!

> In any case I think the stable tree autoselection bit should pick it up
> from the Fixes tag, though...

Yeah, I agree. I also only add the Fixes tag to my patches, and let the
stable team to choose if they want the commit or not. But if people ask
to add cc stable I'll do that, it's easy enough as I have the edit
command in my patchwork script :)

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes