Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <44ef1183-c3f1-5ada-c127-710ec116e559@intel.com>
Date:   Thu, 31 Mar 2022 21:14:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: Bug 215715 - PCI device (iwlwifi) is not working due to PCI power
 state change issues
Content-Language: en-US
To:     Thorsten Leemhuis <regressions@leemhuis.info>
CC:     "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Luca Coelho <luciano.coelho@intel.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <ad13371f-2883-bcf2-a62c-78104bfd615c@leemhuis.info>
 <07541714-5d44-dd84-5ab2-a9ce91bba715@leemhuis.info>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <07541714-5d44-dd84-5ab2-a9ce91bba715@leemhuis.info>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXlLaGNQZ3p4TThNckdQWXdNQUJtQm9TK0c3OWZnWm9nSXVUaXIwejM3ZXNu?=
 =?utf-8?B?aU9talJ1aTM2L1loeDhPc3dKWkJTb04rK05GOVFuTWp1OWhoNWQ4Q2o5M0Vz?=
 =?utf-8?B?WDFvbXk4RXhzVHdzcmJJOUxsQ2pua05ZZXp5dmRkQk54RVQrYlpsTlk2ZWZJ?=
 =?utf-8?B?OVB1TU9VSmh2a1R3bG9lRFYyVm02a3cwamt6L25oK3lQTE9YcW1wMmRnc3Nz?=
 =?utf-8?B?UjZJK1Q2Q1pxVzV6WGU4U1pRNnZ0MVNvckZYQ0IrRWVJUjFiZHY4MGtPSGZn?=
 =?utf-8?B?T3Fxc2d1dHNna3pYK252RjlkVEc0N0NsL1puU0hUa0FoVUZFQnJWaHIyWE5J?=
 =?utf-8?B?a29VZHhOTFY0YWtyOTlhQkRYQlQ4N1hHZUlKU3JiaXN4b25mZldEYXJHRTl1?=
 =?utf-8?B?cDYwQUlrWXU3bCtoMkIxb0krWTFXNnpDZ2dxSVRRR0txZ0dldVJhdTZxZUpW?=
 =?utf-8?B?MkhLTWFDYXluYUl5ZS9MVGs5Vm5OUEN1dDVhOFlKNE9oZU82azVUQUFSTWRn?=
 =?utf-8?B?QWdFK1B4cktOeFZnOThweXArZXlpb2ZSOWxDQ2o2ODBvSlVNN3ZqTG9RWm9Z?=
 =?utf-8?B?WC9CNm1iejVqVHk5MUR1RHpPdHVWUGFYK0Rxb2Q5YjhNYlNUcXRCQndraVhE?=
 =?utf-8?B?SCtTekp3MGhXZWxNVEJPTUJNMk9tMVF1czRpNGhYUlk2L1cxbFNYTHNXeWpN?=
 =?utf-8?B?K2VUWDFKbkpvMy9raWQwSHRwMFpiQk1tUEMrZUpjeUlaV0l5a2xjV2Fvd09C?=
 =?utf-8?B?eEhxa29MVUc2ckJJZnhaVXpMcG9SbnVSOFNpU1dmUU5MR1Z2R2trWSttZDA4?=
 =?utf-8?B?NGE2TWNENkVDa29wL3ZmZHFINmRzWkllK0RYVlA3MlEyTFBSQVlhMTdSVVNF?=
 =?utf-8?B?N0g4MWxKSFFJZ2p3dTBsUnY3WWFsbWJiaTU3Vzk0RktNWDgvWHl5b0NwZEFp?=
 =?utf-8?B?MG5xWmVhQ1M4VWJFVnpJbUhwR0crRjdjUmJmNyt4cDhieWVLbjFjdTRZN0Rp?=
 =?utf-8?B?K1Rkc3M4TGpkZnZVV1dhQUdLczJCWVpFUGFnY3ZCV1FRM2VYMWsyRjh3Mnpk?=
 =?utf-8?B?Mis2UHloVm1EeWR3Q3NTT0J2eWNKVmM2cXdzaXlrN3kwckxoa01KbVliYlNS?=
 =?utf-8?B?TmtDaEZTVTRyeDJwdXZuU2x3Qm9CeDA3SXpqYTZvbXk1Z2lQRjN1N2tDODAy?=
 =?utf-8?B?RVpiNHNwRDFUQlBkRXdFd00zSFpYMXpZaWRnenNlTmlha0JNWUhKeFhCbWNB?=
 =?utf-8?B?b2RLMWF4Nms0Ly9VQWRFWWY4SjhZVU1tZ291eUg4eVFqcytOK3FUd2JpT0hO?=
 =?utf-8?B?NTBuaXlxNldLR1VXMlJhOFZ2TUVwSUdLMmhySWdNVmRhcnZZQlpzM29abEMy?=
 =?utf-8?B?N0xmQkVzWE5lc25UaHhmcHRpSFhaL0lPM2NtRTZaRVBFZlRsSHEwTUhHZDYw?=
 =?utf-8?B?VmFqTW5FRFF0d2VTWGp4cTRuRHVGTG41dWNOSW0xVEQxT1lZQmZLTUhjMm9v?=
 =?utf-8?B?RmQwT1Zqd3E4Z3loQkxOL1kvRmxqdVpDMUY3K0w1STVXVXg5KzVqeHNIbjc4?=
 =?utf-8?B?SUFYTmk5WHJwZVhUYjB3ZWtXZHc5VFd3Rk9TRGZmcFNTZlYrY1hYVFFwMVJs?=
 =?utf-8?B?Ulh0L2E5a0lzOExMQUdPYi9iMFpnVTVwbWg0UjJsSVdjNzR4Q2RNcmtiRnUy?=
 =?utf-8?B?ODltYUxuYnUyWUdkazVNbVRRMWF5U2M0di9JclE1dE9Sd2Y1SkU0dTJCWng4?=
 =?utf-8?B?eXRIdzRqQWZTbk9yTTc4L3Y0YysvMHJtSFhUQXh1OVBoOS84YnNkcllpcUxz?=
 =?utf-8?B?MG1aazZ4WlY5LzlWaVJud0FCczNKekVDaEVuN29PSmtmOHl0WW9kNllSbjYx?=
 =?utf-8?B?UXJGSlpuUWViNjEyQTVWUmZUY1BTQnlESlh6MGpMb1lMVjllUVBmaEdDU3BH?=
 =?utf-8?B?TUFoNEQ5a2FVWDhMejVrNGtOWlhBK1RhMFFIUHMzci9tOWgvM2tyVGVIUnJR?=
 =?utf-8?B?U1VFOWR0QTNQamYyc1ZNbWllZjlSanFwUTNMMFAzQktCOERDY3RUWEZ3Mm5F?=
 =?utf-8?B?Tlg5VjNMZUJJTWNOKytWNzJrOXRIb01Ddzd3ay94RjlmUzlSWkh5RXVhLzN1?=
 =?utf-8?B?SFNEMTVobGJycmt2T3c1dVd1REJmcTZ6L0FBeU9vckF0MEhvZmEzY0F0NTBl?=
 =?utf-8?B?eDZhOVY3d1hlbjhacVF3TG9iQTE2WFk0b0ExM2h3UzYzcVJaeXFkQUpPZ250?=
 =?utf-8?B?YnhGQVc1Mm42V21wM2lRWnRreGQ3Nlp1Z2VrN21IZ091Y25JMVNPUnB6c3RC?=
 =?utf-8?B?amplVnBOMWM0SEZqMTZMYldjT0lvZUYzS0xLaitVaFlGeXV3WDcvaGl1YlQv?=
 =?utf-8?Q?3XnSuEksbbe6sRxg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 963672f4-24fd-4fb2-7e0e-08da134aa65a
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5825.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 19:14:16.7833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GbcHj75KInGi/CZP6h7HuLJHFJDv3orcYExjKVbhV4XeyOJJRunUAMclC36tYTud5dRWfxEN6yQZ9DWSV6JpUiMgiwuu11p7zC2hxJq0QMw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4438
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On 3/29/2022 10:49 AM, Thorsten Leemhuis wrote:
> On 28.03.22 15:33, Thorsten Leemhuis wrote:
>> Hi, this is your Linux kernel regression tracker.
>>
>> Rafael, I noticed a regression report in bugzilla.kernel.org that afaics
>> nobody acted upon since it was reported about a week ago, that's why I
>> decided to forward it to the lists, maintainers, and the author of the
>> culprit. To quote from
>> https://bugzilla.kernel.org/show_bug.cgi?id=215715 :

This turns out to be a platform firmware issue exposed by the commit 
indicated as the "first bad one".

It is being addressed by adding a quirk for the affected platform.


>>>   Stefan Gottwald 2022-03-21 13:31:43 UTC
>>>
>>> Created attachment 300589 [details]
>>> dmesg output from error case
>>>
>>> We got a Elo AIO i2 device which most current BIOS where WiFi was working with Kernel 5.12.x but stopped working since Kernel 5.13.19 and newer (5.17.0-rc5).
>>>
>>> The kernel error message is:
>>>
>>> [    3.419766] iwlwifi 0000:01:00.0: can't change power state from D3cold to D0 (config space inaccessible)
>>> [    3.419781] iwlwifi 0000:01:00.0: can't change power state from D3cold to D0 (config space inaccessible)
>>> [    3.419975] iwlwifi 0000:01:00.0: HW_REV=0xFFFFFFFF, PCI issues?
>>> [    3.420911] iwlwifi: probe of 0000:01:00.0 failed with error -5
>>>
>>> The issue can be solved by adding the iwlwifi driver to the initramfs so it is loaded much earlier and seems to work.
>>>
>>> To narrow down the issue I did an git bisect between v5.13.18 and v5.13.19 mainline kernel version which got me to following commit which if reverted fix the issue on this device.
>>>
>>> Reverting commit d0660d8ab123ea471064f0828f290bec9593e16b : PCI: Use pci_update_current_state() in pci_enable_device_flags()
>> FWIW, that afaics is d0660d8ab123 ("PCI: Use pci_update_current_state()
>> in pci_enable_device_flags()") in mainline.
> Sorry, I made a (obvious) cut-n-paste error there: the stable commit
> mentioned by the reporter is 14858dcc3b35 ("PCI: Use
> pci_update_current_state() in pci_enable_device_flags()") in mainline.
>
> #regzbot introduced: 14858dcc3b35
>
>>> resolve the issue also in the newer kernels. Seems like the function platform_pci_get_power_state is always returning PCI_D3cold on this device also if this is not true.
>> Could somebody take a look into this? Or was this discussed somewhere
>> else already? Or even fixed?
>>
>> Anyway, to get this tracked:
>>
>> #regzbot introduced: d0660d8ab123ea471064f0828f290bec9593e16b
>> #regzbot from: Stefan Gottwald <gottwald@igel.com>
>> #regzbot title: pci/iwlwifi: wifi is not working due to PCI power state
>> change issues
>> #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=215715
>>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>
>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>> reports on my table. I can only look briefly into most of them and lack
>> knowledge about most of the areas they concern. I thus unfortunately
>> will sometimes get things wrong or miss something important. I hope
>> that's not the case here; if you think it is, don't hesitate to tell me
>> in a public reply, it's in everyone's interest to set the public record
>> straight.
>>