Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Karthikeyan Kathirvel <kathirve@qti.qualcomm.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "Karthikeyan Kathirvel (QUIC)" <quic_kathirve@quicinc.com>
CC:     "ath11k@lists.infradead.org" <ath11k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] ath11k: Change max no of active probe SSID and BSSID to
 fw capability
Thread-Topic: [PATCH] ath11k: Change max no of active probe SSID and BSSID to
 fw capability
Thread-Index: AQHYQ34QPurJnYWn+E+xN/pBYmaGJqza97xqgAAAgRA=
Date:   Fri, 1 Apr 2022 11:58:22 +0000
Message-ID: <DM6PR02MB65282E7996A040343F1EF4F1ECE09@DM6PR02MB6528.namprd02.prod.outlook.com>
References: <20220329150221.21907-1-quic_kathirve@quicinc.com>
 <87wng9t3vu.fsf@kernel.org>
In-Reply-To: <87wng9t3vu.fsf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?43c91plLjSPOQqqaTKjRhoR05vjnPVTb+sAHVDXvfNuANcdrm9+aurwY793C?=
 =?us-ascii?Q?1xd8w9gD+RCaZaiArogygVPXmn7OmgX/cEeljh3hSgdzKfJiAglFPxl6+Pwf?=
 =?us-ascii?Q?Y5dxxaqlvcKEapI8/9iriiB9RNTK0SiO7NLm8bv9cnaIqvw7DrTkfqUHy1Z7?=
 =?us-ascii?Q?ARtphelTV8gn/kEwHEwNj8c93yxilmV9TVhxzG+g7EUuW8ibNCYJWhyDmKIf?=
 =?us-ascii?Q?uKfUItr9NFdG3TE+p72UjlQpJpu0FkvJowGfIBob+VdEglgOlZtFK5xawdPB?=
 =?us-ascii?Q?M2I4Upq/HAEsUzh5HrwNS2D6KFiReMKomNVez5GcmYGXMU7UGp0sDENMeKYA?=
 =?us-ascii?Q?dV4EC+1s0c7LwDmmYi6+6ds7wTgp7VnmJ9NKmf/r7qr1d54ilxsFcHOy7++r?=
 =?us-ascii?Q?NUbX9HbNh70Ld1gLEKRHVNLMY8vSyMUBdc/WYtUpngwcjDlPV9+vuLcp7Tly?=
 =?us-ascii?Q?mjfZH+Z+T/I6AgF6QwnM5l821d2VsSbxULXrK7IfJD3GW1P3tY+w2WcjAwB8?=
 =?us-ascii?Q?1Zbd0zx62apoO1OolzgoAVVz1jmpyukTFtLl8kXzi7LMcYtXljBtytKmWMYo?=
 =?us-ascii?Q?W5K54LeLBLTcO3n6UfxQuPCoyhC4apBOgBRDFFrkcqC4fEfxUL2rVCeI5U/1?=
 =?us-ascii?Q?15BbmOnBNIL/6zC7pKZ0CUbbEcPGF1nvBMm0CIopkGoAPzWyJqS+BEKIe3iM?=
 =?us-ascii?Q?EfrMbDzXyJ0E1t364A0Dd3dg5WYovzqpTfFdAN3txk8esz4/JrxN8fpNmXqY?=
 =?us-ascii?Q?PgdCHIQrD1IFi6GcYIVmxxEjaMiVZy33AsJ/74fqTooVxnQjVlfhvQiC6rar?=
 =?us-ascii?Q?yIMCDY0HFjlx/7oBwCUkPkka+GyjpKfVMToIOfkfcEnnOcfw9t+qp8k8EPCA?=
 =?us-ascii?Q?45E8Dwr28T75/OfMLSyrWWnH+oC2V57jP2NTHymHD5zxlnRz/nJ+n5HtMFXl?=
 =?us-ascii?Q?VUP3mVmD5jW/4aVst4rUPeJRnHmSQZC6YOETDYmXUsMK5WNwX1tWCKjN5X3y?=
 =?us-ascii?Q?rs1C5Q4TM76tvJTAksixOR1Vf/19ttoWAW52eg/ZhE+Si+GG65vDsOXd1hBv?=
 =?us-ascii?Q?SWOLvP3PEdsNjWhIfHtDo0dQrt+dY2/gZ+sNo4/25NxnuBqCEPJJLmjWhI4n?=
 =?us-ascii?Q?Rm5w+DIJOGyWnyxjZ/MjHqzk2OEeSfYkZIklqeYDovrKfp9fXMfXPjrpo53B?=
 =?us-ascii?Q?ORzKtdd6PcSyXHKxwTtEqHZ0q5Vmk52vCE4Of5HG/DNp2/I61WWYpDJhcET5?=
 =?us-ascii?Q?LRvt8o80NkY5g7wz0JELwhrsTzvpvXtsR4tuK7lDPGtwW4j1Cfnlq9Sv+Tp5?=
 =?us-ascii?Q?mgQWFK8tpECKmoymGkK0CqN5I8ZxGv0Hnj2r7xEZWyDCfu49jZu33aMR9IiX?=
 =?us-ascii?Q?61ehS3UMQaTDurGfygoBY+ssRFdRTzDlLiHfXddBtog9EFCqE9TSt4MnqfQq?=
 =?us-ascii?Q?DSRQlxWoe2CaagpUM4ONhvixFrJjfqq9UipOYTzN5J0AzT8DbEH7+aVyaj9P?=
 =?us-ascii?Q?ZbxWf5ZDt9fLzKJi0cn29doNYVICKMwjL9FH2K5FuhV1HzV2bFm2YTxU2O5c?=
 =?us-ascii?Q?lcHIKDHAtkFhwW4u3uqH3+cLjkXnGuwh8fI3QneeV8ydw4T1dHZmYTCW3HXl?=
 =?us-ascii?Q?aTxuUv6ta0SZ3XPPu46cGIQEkN9eU4oJDVtfHnwWnWQ8N5Yd9HhHxt2W2yUh?=
 =?us-ascii?Q?fZ6OX0TTc4K8QUb2Obh7uU5q2Ft4+zDaOwh0zohr2frR5pp8F5E2fEsJ0RD1?=
 =?us-ascii?Q?51mxoeRayg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: qti.qualcomm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR02MB6528.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60a07feb-5bd4-461d-ce49-08da13d6ebdb
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 11:58:22.6389
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3GQoQ/jb7bHcbPWsI4akNjI4ky8U2MrjQthXkqVeLT6Hn31rMNxD5uvsvnmgON+/oZRD4ytZqgScevS0S/ua8ID56XzqMWAZBX8CDAoStTk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2531
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi Kalle,

Sorry I missed to add the hw details, I tested on IPQ8074 hw2.0 AHB

Thanks
Karthikeyan

-----Original Message-----
From: Kalle Valo <kvalo@kernel.org>=20
Sent: Friday, April 1, 2022 5:25 PM
To: Karthikeyan Kathirvel (QUIC) <quic_kathirve@quicinc.com>
Cc: ath11k@lists.infradead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath11k: Change max no of active probe SSID and BSSID t=
o fw capability

WARNING: This email originated from outside of Qualcomm. Please be wary of =
any links or attachments, and do not enable macros.

Karthikeyan Kathirvel <quic_kathirve@quicinc.com> writes:

> The maximum number of SSIDs in a for active probe requests is=20
> currently reported as 16 (WLAN_SCAN_PARAMS_MAX_SSID) when registering the=
 driver.
> The scan_req_params structure only has the capacity to hold 10 SSIDs.
> This leads to a buffer overflow which can be triggered from=20
> wpa_supplicant in userspace. When copying the SSIDs into the=20
> scan_req_params structure in the ath11k_mac_op_hw_scan route, it can=20
> overwrite the extraie pointer.
>
> Firmware supports 16 ssid * 4 bssid, for each ssid 4 bssid combo probe=20
> request will be sent, so totally 64 probe requests supported. So set=20
> both max ssid and bssid to 16 and 4 respectively. Remove the redundant=20
> macros of ssid and bssid.
>
> Tested-on : WLAN.HK.2.7.0.1-01300-QCAHKSWPL_SILICONZ-1 v1

This is not correct format:

https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#=
tested-on_tag

On what hardware did you test this? I can then fix the tag.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes