Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [v5.18] ath9k: Properly clear TX status area before reporting to
 mac80211
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220330164409.16645-1-toke@toke.dk>
References: <20220330164409.16645-1-toke@toke.dk>
To:     =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Cc:     =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless@vger.kernel.org,
        Bagas Sanjaya <bagasdotme@gmail.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164879506244.20606.13026596473794143862.kvalo@kernel.org>
Date:   Fri,  1 Apr 2022 06:37:46 +0000 (UTC)
Precedence: bulk

Toke Høiland-Jørgensen <toke@toke.dk> wrote:

> The ath9k driver was not properly clearing the status area in the
> ieee80211_tx_info struct before reporting TX status to mac80211. Instead,
> it was manually filling in fields, which meant that fields introduced later
> were left as-is.
> 
> Conveniently, mac80211 actually provides a helper to zero out the status
> area, so use that to make sure we zero everything.
> 
> The last commit touching the driver function writing the status information
> seems to have actually been fixing an issue that was also caused by the
> area being uninitialised; but it only added clearing of a single field
> instead of the whole struct. That is now redundant, though, so revert that
> commit and use it as a convenient Fixes tag.
> 
> Fixes: cc591d77aba1 ("ath9k: Make sure to zero status.tx_time before reporting TX status")
> Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>

Patch applied to wireless.git, thanks.

037250f0a45c ath9k: Properly clear TX status area before reporting to mac80211

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220330164409.16645-1-toke@toke.dk/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches