Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <865be9e8-3702-af45-95e8-1371dd6c43b2@cornelisnetworks.com>
Date:   Thu, 31 Mar 2022 13:41:50 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH 11/22] rdmavt: Replace comments with C99 initializers
Content-Language: en-US
To:     Leon Romanovsky <leon@kernel.org>,
        =?UTF-8?Q?Benjamin_St=c3=bcrz?= <benni@stuerz.xyz>
Cc:     andrew@lunn.ch, sebastian.hesselbarth@gmail.com,
        gregory.clement@bootlin.com, linux@armlinux.org.uk,
        linux@simtec.co.uk, krzk@kernel.org, alim.akhtar@samsung.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, robert.moore@intel.com,
        rafael.j.wysocki@intel.com, lenb@kernel.org, 3chas3@gmail.com,
        laforge@gnumonks.org, arnd@arndb.de, gregkh@linuxfoundation.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl,
        mike.marciniszyn@cornelisnetworks.com, jgg@ziepe.ca,
        pali@kernel.org, dmitry.torokhov@gmail.com, isdn@linux-pingi.de,
        benh@kernel.crashing.org, fbarrat@linux.ibm.com, ajd@linux.ibm.com,
        davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        nico@fluxnic.net, loic.poulain@linaro.org, kvalo@kernel.org,
        pkshih@realtek.com, bhelgaas@google.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org,
        linux-acpi@vger.kernel.org, devel@acpica.org,
        linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-input@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org,
        wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
        linux-pci@vger.kernel.org
References: <20220326165909.506926-1-benni@stuerz.xyz>
 <20220326165909.506926-11-benni@stuerz.xyz> <YkAMlurdV15gNROq@unreal>
From:   Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
In-Reply-To: <YkAMlurdV15gNROq@unreal>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUNkTlp3bUdOcS9sNXFnNTRoL0M5bXNzcGRQRmNwb296bWlrYUp3MFFrNUUv?=
 =?utf-8?B?ajBOK3VIazlLMUx0bDd4Q2M3ZHRvREQ1aXNER3JSUXJZVk9TYmJJQ1FhV2Mx?=
 =?utf-8?B?bHUrZTJKdFNxYll1eGc4NVJHYzA3OE0zOFpZQ0piVTFNLy9Tam5NcUZaZm02?=
 =?utf-8?B?Z3NVMUc2bDZsdWlOUVVHbDJhZmZid0R2TEkrYTRGY25kdGJkMjBFbVloTURv?=
 =?utf-8?B?QSs0RnhhczJIRDJ5QmpCaTgvS2EzRC8wdDYyTDBRR2IrRnUxamFQSmEwNWZk?=
 =?utf-8?B?S2VLVFl0QlNUV3FBME9CWEp4aVJIZklOQm9JckZoenZMRjR6VzdOZlpnREdK?=
 =?utf-8?B?WEQzNnJBZDgzWE56WDNuNW5NdEtEalFpK0ZrQWhORU4wSnI5OXVKemtrbzNI?=
 =?utf-8?B?aTBCUjBDQUI2QzZONWgzOWxFbHlKbGJiWVhUd2VSYnhmOGhvWHNTbWRGK3ZH?=
 =?utf-8?B?dXlPeUxYNXZGd3dGenpiMzc2OTllR2RTQW96cUhjTGVJa0E3WXU2YTlMdExC?=
 =?utf-8?B?S3BYMEFVY1ZyZ05qR25rTUtzOWtjSHNSejBtUGdBQXJvT28vaXAzc0dEYzBn?=
 =?utf-8?B?b1ZWTG5FRGhjUjRxTlg1WDZuZnpNMGpyODF6T3JXTzVNLzVLNXNEQTMzY3R6?=
 =?utf-8?B?alFzTlVSLytzSXVHZTJxcUVFbVdmUloyelQwZG1CVG8wVVdxQkdoVUo3WjV0?=
 =?utf-8?B?N3F1a0ZHT2NuRlR0UlA1TnduTDc2YmdzUmkzSHRTNjQ3blNNUVVzQ0Z1cEdQ?=
 =?utf-8?B?cWZtWTRnWVllRlhKbGtiL0NZZUdLbUt3ekNTUndac2V0THdHMzZLYkxDVUZ3?=
 =?utf-8?B?NW55VWU5R2tYNlhUUjJwYnJaT2JTOFhpMzVpTEh5SVUzNXhlLzdidWN3VWpX?=
 =?utf-8?B?SmhXZUtnb2xNN1krbmcxSklmaUg5MitrOXJFVTR5emVIQXFtQVRXaEduNU1h?=
 =?utf-8?B?YnJvT0w2UmZFNHdIZUNVN250UlRuRHEzTFF1K1B6VVIwNDhtOXFtWGcxangz?=
 =?utf-8?B?NG1jcHNRdk1NdUx4ak01YXhYdEhaZlEweU5weGhHN1RzK2tGbi9DeHFWYmNF?=
 =?utf-8?B?L3llY01sdm10SGs4SjVPTEhXUG1XZFVyWitCeU5EQkJyVHpCNi9hd1JodWNs?=
 =?utf-8?B?bk1lWndHTEtBYndHMkhpRGRWbWVReE5SQWpHSDYrSi9SaHh2WGd6S2hsNlhH?=
 =?utf-8?B?dHQ1VENIZ3hPa1lVb3N1RVBFc3lUVWNzT1lQVHMxczMxRk5uUWNYMGtmb0lI?=
 =?utf-8?B?a0toMHZ4L005RmVhK3k2NngvZ3dTcStJdGk4ZFh2bGlHbjJ4S3B3TjlsMjlN?=
 =?utf-8?B?YXBnMHNBWHluaUtEalZPeW9wYWZxZGR6SFQzZmtXZ21GcHpFVEFOTFEvTUtC?=
 =?utf-8?B?TitDOWx4M0ZkVWZDTVdWVHpGY0NTVW9MTE04cTk4SU9pZklmZXhDSHZBVkNx?=
 =?utf-8?B?VEFGcTI5aDZoY3RCNlhHa2RYbG5KZWlObjl0Q2VJM1JVb1FMYVQzUVhHTkc0?=
 =?utf-8?B?MFdaR1BSaGhKWlRqcXl1K3l0K1Z6V3l6VVdVa2JQaVNjZnZsT0J3b0RVemxF?=
 =?utf-8?B?SEhYOFA5YXZVelBWWHd3dVNSS2lqaTMrY3k0RGw3WXhYVkV6WU1tU1lVSDhR?=
 =?utf-8?B?ZllReW9IcjdJZ3FNYjJtZFZmSUZwSEhnN1JPaDFoT3c5Zk1JSy9weDUyVWU3?=
 =?utf-8?B?bk9SNElDYkE0WUpYT1A2T2Q0ZUxXM2djR04zcWlkeUtMVGtzanQyV1N3M0Y0?=
 =?utf-8?B?c3BiVW82V2NpWUd2eE5GK3F0VVlTdkttWW9Lc0lCK0ptaDEvcDRQK2VYQndl?=
 =?utf-8?B?QzZIVWhEcmk3M3Uxb2kyRHQwZHZLUGtGVi9KbGwyYXIwR0oyc1pyUElad2gr?=
 =?utf-8?B?RTdTUEE1RFRUaFFSakY3aktVOWwxQWxyZ1Q3eE9QVzQ0aFNjZGJlZVBtREtC?=
 =?utf-8?B?WWxxOXJqczVhQXY5eUJITklQeXZ1WG5RYjkxRjBiU2d4aXJScGlzVVhCR2NW?=
 =?utf-8?B?WGplQitQWldRZEZyaCswdW1HeWNIV3NTOHl2Vy8xdVdaRURmQ3F1Y2Qxd2hN?=
 =?utf-8?B?Znhqam5FYlBMMFg4QllvWUk2VFEvVFlNb0E4U1Vld1kyVjkwWklraDVOeDZ5?=
 =?utf-8?B?VUFoUkpYa0tMM3A0QWY0OXBvWXBML1lqZmVmM0EyaitiaGlLQkVyZThTTnpY?=
 =?utf-8?B?bmN2d1NJaHBRVHhyZzdFQkxpRGdTbXFudXVSZ1VZaTNzZUw5dUFqZ3BKQ1Iv?=
 =?utf-8?B?ME9OdTdsNmV3WHo3bkxqdExuaGRneFRZY1JnaUlQTXpXeFN3MlNUL2xxSW5Z?=
 =?utf-8?B?aTlSS3RycEMzd0tlbTdwUitjMGJHcmpJSWRaRDJSSG8zMVFiNk9RODh4RHVi?=
 =?utf-8?Q?dTu9FF7dPua+g00boSWzEPduptu4VuScFaxp2?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f24229f2-4402-4b20-4bbc-08da133dc16b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB6439.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 17:41:58.9049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u4f40gDKtLc5nZzWwBrJLy9psIKU+mR/YNVKGDb0V6uhEBWCLlUIPr5nOmCQVy57yz8R2i5+/eSDcZvZoFLmwTPRjb87ZaNrwTwDkbOEAsNpMSG/uNvYpx/JWg5CzBL9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR01MB4628
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On 3/27/22 3:04 AM, Leon Romanovsky wrote:
> On Sat, Mar 26, 2022 at 05:58:58PM +0100, Benjamin Stürz wrote:
>> This replaces comments with C99's designated
>> initializers because the kernel supports them now.
>>
>> Signed-off-by: Benjamin Stürz <benni@stuerz.xyz>
>> ---
>>  drivers/infiniband/sw/rdmavt/rc.c | 62 +++++++++++++++----------------
>>  1 file changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/infiniband/sw/rdmavt/rc.c b/drivers/infiniband/sw/rdmavt/rc.c
>> index 4e5d4a27633c..121b8a23ac07 100644
>> --- a/drivers/infiniband/sw/rdmavt/rc.c
>> +++ b/drivers/infiniband/sw/rdmavt/rc.c
>> @@ -10,37 +10,37 @@
>>   * Convert the AETH credit code into the number of credits.
>>   */
>>  static const u16 credit_table[31] = {
>> -	0,                      /* 0 */
>> -	1,                      /* 1 */
>> -	2,                      /* 2 */
>> -	3,                      /* 3 */
>> -	4,                      /* 4 */
>> -	6,                      /* 5 */
>> -	8,                      /* 6 */
>> -	12,                     /* 7 */
>> -	16,                     /* 8 */
>> -	24,                     /* 9 */
>> -	32,                     /* A */
>> -	48,                     /* B */
>> -	64,                     /* C */
>> -	96,                     /* D */
>> -	128,                    /* E */
>> -	192,                    /* F */
>> -	256,                    /* 10 */
>> -	384,                    /* 11 */
>> -	512,                    /* 12 */
>> -	768,                    /* 13 */
>> -	1024,                   /* 14 */
>> -	1536,                   /* 15 */
>> -	2048,                   /* 16 */
>> -	3072,                   /* 17 */
>> -	4096,                   /* 18 */
>> -	6144,                   /* 19 */
>> -	8192,                   /* 1A */
>> -	12288,                  /* 1B */
>> -	16384,                  /* 1C */
>> -	24576,                  /* 1D */
>> -	32768                   /* 1E */
>> +	[0x00] = 0,
>> +	[0x01] = 1,
>> +	[0x02] = 2,
>> +	[0x03] = 3,
>> +	[0x04] = 4,
>> +	[0x05] = 6,
>> +	[0x06] = 8,
>> +	[0x07] = 12,
>> +	[0x08] = 16,
>> +	[0x09] = 24,
>> +	[0x0A] = 32,
>> +	[0x0B] = 48,
>> +	[0x0C] = 64,
>> +	[0x0D] = 96,
>> +	[0x0E] = 128,
>> +	[0x0F] = 192,
>> +	[0x10] = 256,
>> +	[0x11] = 384,
>> +	[0x12] = 512,
>> +	[0x13] = 768,
>> +	[0x14] = 1024,
>> +	[0x15] = 1536,
>> +	[0x16] = 2048,
>> +	[0x17] = 3072,
>> +	[0x18] = 4096,
>> +	[0x19] = 6144,
>> +	[0x1A] = 8192,
>> +	[0x1B] = 12288,
>> +	[0x1C] = 16384,
>> +	[0x1D] = 24576,
>> +	[0x1E] = 32768
>>  };
> 
> I have hard time to see any value in this commit, why is this change needed?
> 

I tend to agree. This doesn't really improve things. It's a NAK from me.

-Denny