Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1218560pxb; Fri, 1 Apr 2022 07:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz47ZIG0jdiKkmqET+aOHCmTYiUDlrYKllrybmpjIMyXsBNcMKVPt+tYpU/OlESNO7npgZ0 X-Received: by 2002:a17:907:9494:b0:6e0:ee8:4b29 with SMTP id dm20-20020a170907949400b006e00ee84b29mr97935ejc.337.1648824064576; Fri, 01 Apr 2022 07:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648824064; cv=none; d=google.com; s=arc-20160816; b=vdNtR8+3WL/on2ibm0pTzakpMlErdPMQgDKjvX3FA77bwC1eyj093VVn5cYGeiZx8f 3HfPJP5D08QyjyUf5zS5meOromBS9daJ2pD4n5m8QMna8EEf6oabLsMhN6htjZMyplRm qhof4+xle56VPaTrDAoMgJV+kuWHlhKAUfIqkr09NjwwJcII/Ie6Sk6uYHO2dxqfAPM4 Ao6ckwf3Vjch46YEoGEPKa9K0ALPs34hbspMToSgktsrmiNP0bHkoQJH+W9ldC2Rwer3 vwNJjZykVgI3htk2JMwj/3IJEHzPQIAl5FHAxm6moulFtaPksdpGFrr8zhN+1xu/Ry6j zouw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=0BeroMAEkbhHONAZJF+m4YDohy/at7ux0aCVDOzz8FM=; b=BLybAlvi4DG5vslRwOYYrWhWccXx1KbR1YoguV81FcDL4QHz65u5fA38x97NZpuieQ gxX9Rcc1L6kT8lRmxn4K7XTRmg5W/xJxRgSgjl+2On8SCLAJEhh+uAFgIfq5CESQhaol KrFWbQmbHwZjQso0itZBiksPOUs/m2BarJqTiFCsjLIucCpcW8lZfGR+T7XaG9mEqyVg PblurRnbNN3GzpsEbb3vF2Ek3EzFukpQVEn1PUVLTL9R7DL3MU8Dz+vSTdFISROwM0A5 0lDR5DnC30BVSM8YyagL5IN8Xh6mhwPC8PaKct2ihVeSn/bSnebfFfJikO+dcUi9ypVh I1qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P7yd6E74; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a509dc1000000b00418c2b5bd45si1796114edk.39.2022.04.01.07.40.46; Fri, 01 Apr 2022 07:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P7yd6E74; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345565AbiDALkH (ORCPT + 68 others); Fri, 1 Apr 2022 07:40:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344937AbiDALkF (ORCPT ); Fri, 1 Apr 2022 07:40:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1389D1DB89E for ; Fri, 1 Apr 2022 04:38:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BDD10B8245D for ; Fri, 1 Apr 2022 11:38:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA0F5C2BBE4; Fri, 1 Apr 2022 11:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648813093; bh=JeZ02QkfWVzX6ts+UvtEHBfdA9PpxWAQowCGmjr19R0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P7yd6E74dtHmw5gQgplfq0oqYqm9HXuoAt+DAPxAekQjzUHm6Mmcm+nyL9wX6Ij5u 4x6kDEZQdJyHO1mb3VCraxt1SXA01L6IiqVeSG8Kz6YVeF0QrnGznpiUG99FwRqBiw JjUHzmDemt/o6nUHKE2bOGjc/96S5gdJp0oVyIMHdabOebJT9GACwEojM8re73qMjK bnWuIN7fn4tZLkSC1hJjXo4V0Et99sRLElNOMQoYUCs5z86fM+nKCu+5EgPp9zcdUv 5ccoKK3SYXNXGXy9k3+o3p2tuyS0OO7K3Ff/xLBkqsZ+iu8V/V+Jw7ny56282suNZ9 GUZEBvodhBE3w== From: Kalle Valo To: Baochen Qiang Cc: , Subject: Re: [PATCH v3 1/2] ath11k: add support for extended wmi service bit References: <20220401073200.1195070-1-quic_bqiang@quicinc.com> Date: Fri, 01 Apr 2022 14:38:10 +0300 In-Reply-To: <20220401073200.1195070-1-quic_bqiang@quicinc.com> (Baochen Qiang's message of "Fri, 1 Apr 2022 15:31:59 +0800") Message-ID: <875yntuj8d.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Baochen Qiang writes: > From: Wen Gong > > Currently the wmi service bis is report from firmware, it is divided > to 128 bits for each segment. The first segment is processed by > ath11k_wmi_service_bitmap_copy(), the second segment is processed by > ath11k_service_available_event() with WMI_TAG_SERVICE_AVAILABLE_EVENT, > When the service bit exceed 256 bits, then firmware report it by tag > WMI_TAG_ARRAY_UINT32 in WMI_SERVICE_AVAILABLE_EVENTID. > > ath11k does not process the third segment, this is to extend the wmi > service bits from 256 to 384 for the third 128 bits. The 3 enum value > WMI_MAX_SERVICE(128)/WMI_MAX_EXT_SERVICE(256)/WMI_MAX_EXT2_SERVICE(384) > are convenient to process the service bits. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > > Signed-off-by: Wen Gong Baochen, you need to add your own s-o-b in the end. Please read: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin But remember to keep Wen's s-o-b, they should be never removed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches