Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2870143pxb; Mon, 4 Apr 2022 00:52:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybIp08pZIAQcTlfmPHxgdwFw3AYRalXTHeLWav8dkoX05k/dipYtUpvvGrR22paDmSWl6t X-Received: by 2002:a17:902:b582:b0:14c:a63d:3df6 with SMTP id a2-20020a170902b58200b0014ca63d3df6mr22318568pls.51.1649058722780; Mon, 04 Apr 2022 00:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649058722; cv=none; d=google.com; s=arc-20160816; b=r9j+9i7wmPsvNZpqv5sVnb6Jn18UYSh6Gq7H3bJBrI2Lbdl2OQp/SK8kXWjbbjqkLu TLWNWjPlxqMNnehDqh9DNqWjiBau2xW1Xp63bc9OykZCPf5MrkbJluEyPsHlqsz08/ti iM5QdOEJFxNrEQvQP46sN7pDhmYYFpZelW5uh5vODH5sa6c2rSFF7wp2EF0n9E2pYsKA YiYtA4qQxh9p4zvY27L1oJPD+TKpOMJEdhsRUd78G33LEYTgRJKHhSDQUfNot8VLaQtA NJH0gDZImIMUWGre1nYl1LmzPK2PjuH1YEs7AulKXzi8VnTm/Kc6iT3NdYJHGGwpmmVa Mrmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=CyguLt3rsoXOSKw3Uzg0mf/b90aC3lndIRX9xk/nvV0=; b=VnWL6ljC0E4X/pUQ1/CMEaOnd0Rrd+RG5O7plwLWAomQZZE1JdYc3a4f2kuxl3VWaA si1er9YBKrbzQRfxD99jRY8g4Jy8WxufxUfE3nn84Yf3qB1ObXjw5sYB16ZeLF3ctkuh PeAhKk66X8S+QAmYOdINNp3ZWRMGHKE8rIFd7z5ls6gpdy40ek/bm+EXyD5joK4YMelP SkNvGY1Y/PvuYgpeh5ahcoSYdR4COt0clmB3VGgblYQg4rf9kVyEhuVOqEqElnNG3snq ZnaLUgP9zFMTATkzz/8EWDV4Yai5P+x2qaOeSZq/KPJuqPBPeWwBoU0Jo2oBpfMdfmMs jkcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=PrLTLH2G; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q184-20020a6343c1000000b0038265eb37fasi9561114pga.780.2022.04.04.00.51.52; Mon, 04 Apr 2022 00:52:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=PrLTLH2G; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355237AbiDBNQs (ORCPT + 68 others); Sat, 2 Apr 2022 09:16:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346501AbiDBNQr (ORCPT ); Sat, 2 Apr 2022 09:16:47 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750556553; Sat, 2 Apr 2022 06:14:55 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1648905294; bh=vKZaNhqeUWallcqyw2qD7Jq/dDYxww72yxBWf+oyMPg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PrLTLH2G2H8yRMUcc0dRtL+PF+WsxF+LPJlZ0/5aBMOXOjuX2FnWMAT0NcKrIBps9 A80MrAAQGfoMWXl4hS3nwtM3LmBdpZYYavc80/uoto/Di6GAUGQUugBHdiLUWCfKyI WcbX5GIrxgSUHgAlInX99NjEitg6bEufXcZ8fdRAP9bXsthoqmu3cjNSmOC9SXrejC cv3N9lzM6/ZXeH3jYTchHx+VrKR9U7Ivcyv5rPSZBveljVQd2iNC+bouzcqTviTZg7 JILpZgjtozzf4UFHGmroOb/87404ROY3m86kJYHAHsO0js2CZbP7nlqG4I6BlOZH54 r/wxcukFQSSiA== To: Greg KH Cc: Kalle Valo , linux-wireless@vger.kernel.org, stable@vger.kernel.org, Peter Seiderer Subject: Re: [PATCH v5.18] ath9k: Save rate counts before clearing tx status area In-Reply-To: References: <20220402122752.2347797-1-toke@toke.dk> Date: Sat, 02 Apr 2022 15:14:53 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87o81jfwz6.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Greg KH writes: > On Sat, Apr 02, 2022 at 02:27:51PM +0200, Toke H=C3=B8iland-J=C3=B8rgense= n wrote: >> From: Toke H=C3=B8iland-J=C3=B8rgensen >>=20 >> The ieee80211_tx_info_clear_status() helper also clears the rate counts,= so >> we should restore them after clearing. However, we can get rid of the >> existing clearing of the counts of invalid rates. Rearrange the code a b= it >> so the order fits the indexes, and so the setting of the count to >> hw->max_rate_tries on underrun is not immediately overridden. >>=20 >> Cc: stable@vger.kernel.org >> Reported-by: Peter Seiderer >> Fixes: 037250f0a45c ("ath9k: Properly clear TX status area before report= ing to mac80211") >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> --- >> drivers/net/wireless/ath/ath9k/xmit.c | 25 +++++++++++++++---------- >> 1 file changed, 15 insertions(+), 10 deletions(-) > > What is the git commit id of this change in Linus's tree? You mean the commit referred to in the Fixes: tag, right? That's not in Linus' tree yet, it's a follow-up to a commit that was merged into the wireless tree yesterday and marked for stable, so the two commits should be added to stable together once they do hit Linus' tree. I forgot to add the stable Cc when sending out the previous patch, so Kalle added it when committing; so I guess you haven't seen that one? :) -Toke